Commit Graph

2514 Commits

Author SHA1 Message Date
Jorge Manrubia cfdf19db9d Replace conditional with presence 2025-05-07 14:59:16 +02:00
Jorge Manrubia 5e812b15ba Make undo transactional too 2025-05-07 14:52:49 +02:00
Jorge Manrubia 9c1185055e Instead of removing uncofirmed commands don't create them in the first place 2025-05-07 14:47:15 +02:00
Jorge Manrubia 6776e69ed8 Stop propagation so that it doesn't navigate back on ESC 2025-05-07 14:43:11 +02:00
Jorge Manrubia b017a3fd67 Destroy unconfirmed commands so that they don't end up in the user history 2025-05-07 14:43:11 +02:00
Jorge Manrubia bfc89124cf Reorder 2025-05-07 13:55:28 +02:00
Jorge Manrubia b9875033bc Remove unused 2025-05-07 13:54:47 +02:00
Jorge Manrubia 837de05baa Format 2025-05-07 13:54:22 +02:00
Jorge Manrubia 6d0855da28 Format 2025-05-07 13:50:58 +02:00
Jorge Manrubia 695383da7a Don't fail when no cards
This will prevent nil errors when parsing the command. Instead, the regular command validation will trigger and the error will be handled as expected.
2025-05-07 13:49:45 +02:00
Jorge Manrubia 87484dbca0 Add basic keyboard navigation support for the Fizzy do menu 2025-05-07 13:46:19 +02:00
Jorge Manrubia 0dcc6959da Extract constant to clarify regexp 2025-05-07 13:31:52 +02:00
Jorge Manrubia 4d2f2067ed Format 2025-05-07 12:13:45 +02:00
Jorge Manrubia ba1aa60423 Add separation space 2025-05-07 12:09:12 +02:00
Jorge Manrubia 189c7e4a87 Serve the last commands in reverse order so that the most recent one is just above 2025-05-07 12:07:13 +02:00
Jorge Manrubia 181e35b5b2 Restore command when clicking on it 2025-05-07 12:03:02 +02:00
Jorge Manrubia c9813f2fb1 Extract method 2025-05-07 11:38:17 +02:00
Jorge Manrubia 3e5c811bea Format and rename method 2025-05-07 11:37:47 +02:00
Jorge Manrubia 561e9fad0c Support selecting multiple cards by using a list of numbers (separated by comma, or space)
https://3.basecamp.com/2914079/buckets/37331921/todos/8620236700#__recording_8620273944
2025-05-07 11:30:58 +02:00
Jorge Manrubia dc28f4c9c5 Add command to close cards
https://3.basecamp.com/2914079/buckets/37331921/todos/8620236700
2025-05-07 11:00:22 +02:00
Jorge Manrubia 8697cabbe2 Show confirmation when submitting certain commands
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-07 10:20:32 +02:00
Jorge Manrubia 22c3c33c0b Merge pull request #460 from basecamp/fizzy-do-initial
Fizzy Do (initial)
2025-05-07 08:57:37 +02:00
Jorge Manrubia 26614c5f02 Fix test 2025-05-07 08:56:32 +02:00
Jorge Manrubia 6f382b68e0 Rename command controller => terminal controller and name the error class after terminal 2025-05-07 08:53:25 +02:00
Jorge Manrubia 55ea460d3e Handle form errors with a stimulus class
We need to keep the focus in place when submitting the form. We are using a data-turbo-permanent for that. We were rendering the error form with a turbo stream. The problem was that turbo streams ignore permanent elements as per this https://github.com/hotwired/turbo/pull/688, so the system wasn't updating the input field as expected.

Handling this as the stimulus level will also help with managing additional error states (such as the one we need for confirmations).
2025-05-07 08:46:47 +02:00
Jason Zimdars 34319ef053 Style 2025-05-06 18:07:00 -05:00
Jason Zimdars 6cb1762588 Update colors and adjust outline 2025-05-06 18:01:06 -05:00
Jason Zimdars 6695eac38e Unused 2025-05-06 17:53:20 -05:00
Jason Zimdars 94e2ab25f9 Make command a button 2025-05-06 17:45:05 -05:00
Jason Zimdars 10890df97f Style undo button 2025-05-06 17:32:45 -05:00
Jason Zimdars 521351da16 Add a keyboard shortcut 2025-05-06 16:15:19 -05:00
Jorge Manrubia cc039e0831 Add missing index to commands 2025-05-06 22:51:38 +02:00
Jason Zimdars eb986f2a5a Merge branch 'main' into default-collection
* main:
  Need a user for this
  We can't rely on count now so test that the specific collection no longer exists
  Accounts always start with a "Cards" collection
  Need to name the assignee(s)
  Adjust for svg icons
  Display obvious chip when filtering by stage
  Need to name the assignee(s)
  Adjust for svg icons
  Display obvious chip when filtering by stage
  Use black for completed card color
2025-05-06 15:48:35 -05:00
Jason Zimdars 6f70b8f3b1 Merge branch 'jz-5-6'
* jz-5-6:
  Need to name the assignee(s)
  Adjust for svg icons
  Display obvious chip when filtering by stage
2025-05-06 15:46:31 -05:00
Jason Zimdars 5b929619b4 Need a user for this 2025-05-06 15:45:28 -05:00
Jason Zimdars 40dbd51ab1 We can't rely on count now so test that the specific collection no longer exists 2025-05-06 15:45:28 -05:00
Jason Zimdars 16a174d87f Accounts always start with a "Cards" collection
- Deleting the last collection, immediately creates a new "Cards" collection
2025-05-06 15:45:28 -05:00
Jason Zimdars c2a563c699 Need to name the assignee(s) 2025-05-06 15:45:28 -05:00
Jason Zimdars d8c2591296 Adjust for svg icons 2025-05-06 15:45:28 -05:00
Jason Zimdars 36fb154ee1 Display obvious chip when filtering by stage 2025-05-06 15:45:28 -05:00
Jason Zimdars 7e8c45a0a5 Need to name the assignee(s) 2025-05-06 15:39:55 -05:00
Jason Zimdars b80969151e Adjust for svg icons 2025-05-06 15:33:17 -05:00
Jason Zimdars 018f22a037 Display obvious chip when filtering by stage 2025-05-06 13:58:28 -05:00
Andy Smith 54fff3bd2d Merge pull request #461 from basecamp/color-completed-cards
Use black for completed card color
2025-05-06 13:37:43 -05:00
Andy Smith d0c2212734 Use black for completed card color 2025-05-06 13:36:40 -05:00
Jason Zimdars ec4be7353b Need a user for this 2025-05-06 12:28:33 -05:00
Jason Zimdars 2d22bef203 We can't rely on count now so test that the specific collection no longer exists 2025-05-06 12:27:02 -05:00
Jason Zimdars 28e7b9f59b Merge branch 'main' into default-collection
* main:
  Separate default from selectable workflow colors
  Brighter card colors
  Add transition
  Larger click area for the clear notification button
  Remove empty line
  Use variables for card colors
  Subtle fading and overlapping grid lines
  Toggle should more closely resemble columns
  Add `No.` and tighten-up line
  Display card id
  Don't count the system user
  Handle the case where you can only see one collection
2025-05-06 12:18:24 -05:00
Andy Smith ca2669c56f Merge pull request #455 from basecamp/card-colors
Use variables for card colors
2025-05-06 11:59:41 -05:00
Andy Smith f1daa647fe Separate default from selectable workflow colors 2025-05-06 11:54:40 -05:00