Commit Graph

1950 Commits

Author SHA1 Message Date
David Heinemeier Hansson d00a0433e9 Inline anemic method 2025-04-16 15:34:28 +02:00
David Heinemeier Hansson 13c44ba650 Actually need it for the lazy load of course 2025-04-16 12:00:54 +02:00
David Heinemeier Hansson 980345d176 Drop the frame, we will do it with streams 2025-04-16 12:00:11 +02:00
David Heinemeier Hansson 3fc34257c4 No longer used 2025-04-16 11:59:58 +02:00
David Heinemeier Hansson 50e4587dd9 Fix trailing spaces 2025-04-16 11:56:21 +02:00
David Heinemeier Hansson 375afeac7b Fix test 2025-04-16 11:55:35 +02:00
David Heinemeier Hansson 73f272f132 Use one controller for all notification readings 2025-04-15 19:14:50 +02:00
David Heinemeier Hansson 2ea898324f We can just set the namespace directly in the class name 2025-04-15 16:36:40 +02:00
David Heinemeier Hansson ac65f39c0d Inline anemic partial 2025-04-15 16:32:56 +02:00
David Heinemeier Hansson b9f5293231 Style 2025-04-15 16:15:13 +02:00
David Heinemeier Hansson f30a9308d2 Line up scopes in order of the flow 2025-04-15 16:13:54 +02:00
David Heinemeier Hansson 8e479dddba Clearer still 2025-04-15 16:04:11 +02:00
David Heinemeier Hansson 5d22809e29 No public use of this concept, so inline it 2025-04-15 16:03:14 +02:00
David Heinemeier Hansson 680611503d Distinguish between administering and just changing 2025-04-15 16:00:29 +02:00
David Heinemeier Hansson a6a96fd5c8 Dont repeat the same checks from doing, make it clearer where the difference is 2025-04-15 15:55:29 +02:00
David Heinemeier Hansson 93178636cd Flesh out all the tests 2025-04-15 15:41:01 +02:00
David Heinemeier Hansson 2e8df45680 Flesh out tests for users controller 2025-04-15 15:36:11 +02:00
David Heinemeier Hansson af0a42080b Allow users to edit themselves 2025-04-15 15:35:39 +02:00
David Heinemeier Hansson abd2af3d8a Dont need an index for a single record 2025-04-15 15:35:28 +02:00
David Heinemeier Hansson 2ace519d91 There is only one account, so just check join code directly 2025-04-15 15:35:10 +02:00
David Heinemeier Hansson 7e5f71fedd We will only have one account record per account
Not sure why this was added in the first place.
2025-04-15 15:17:30 +02:00
Kevin McConnell 61b24483a7 Deploy to new node
Our production node has been replaced; `fizzy-app-101` is the new one.
2025-04-15 09:38:02 +01:00
Kevin McConnell 028a43e652 Title is on the related card 2025-04-14 15:50:24 +01:00
Andy Smith bc8060a2dd Merge pull request #399 from basecamp/consolidate-cards
Consolidate cards
2025-04-14 09:40:58 -05:00
Andy Smith a88264ed0a Merge branch 'main' into consolidate-cards
* main: (94 commits)
  Source order seems to be significant
  Use `card.title`
  Nicer flow
  Fix string interpolation
  Fix constant
  Use record lookup
  Always use sole
  Explained less and extracted nothing of value
  Weird double negative
  Remove anemic and indirect method that explained nothing
  Can use record lookup for workflows
  Access control has already been done through the card
  Style
  Use _path in all cases where we are not potentially changing the domain
  Clearer
  Spacing
  Get rid of card_title
  Join the two users controllers but split out role setting
  Ensure user is returned
  We are not using the parameter
  ...
2025-04-14 09:40:22 -05:00
Jason Zimdars 289487a383 Source order seems to be significant
Regressed in d3c5c86b21
2025-04-14 09:23:57 -05:00
Jason Zimdars 3cfdaf1129 Use card.title 2025-04-14 08:54:54 -05:00
David Heinemeier Hansson cfb345bc32 Nicer flow 2025-04-13 20:39:09 +02:00
David Heinemeier Hansson 80c518b7e1 Fix string interpolation 2025-04-13 20:36:16 +02:00
David Heinemeier Hansson e8a730c239 Fix constant 2025-04-13 20:36:07 +02:00
David Heinemeier Hansson 34232c0e31 Use record lookup 2025-04-13 20:30:03 +02:00
David Heinemeier Hansson d9a9690137 Always use sole 2025-04-13 20:29:10 +02:00
David Heinemeier Hansson 9e0b9c08c2 Explained less and extracted nothing of value 2025-04-13 20:28:35 +02:00
David Heinemeier Hansson 33278469ef Weird double negative 2025-04-13 20:26:58 +02:00
David Heinemeier Hansson a5df54015e Remove anemic and indirect method that explained nothing 2025-04-13 20:25:59 +02:00
David Heinemeier Hansson e2a931b657 Can use record lookup for workflows 2025-04-13 20:24:16 +02:00
David Heinemeier Hansson 366fe06113 Access control has already been done through the card 2025-04-13 20:22:53 +02:00
David Heinemeier Hansson e12ef119da Style 2025-04-13 20:17:24 +02:00
David Heinemeier Hansson dbf61f4fc3 Use _path in all cases where we are not potentially changing the domain 2025-04-13 08:17:36 +02:00
David Heinemeier Hansson 7b60748796 Clearer 2025-04-13 08:11:25 +02:00
David Heinemeier Hansson 4ef46ccd19 Spacing 2025-04-13 08:10:47 +02:00
David Heinemeier Hansson 5b524254b9 Merge pull request #403 from basecamp/commit-to-single-account
The tenanted db is the account scope
2025-04-13 07:58:12 +02:00
David Heinemeier Hansson cf93da6886 Get rid of card_title
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
David Heinemeier Hansson a106b1b6a7 Join the two users controllers but split out role setting 2025-04-12 20:30:47 +02:00
David Heinemeier Hansson c463f342bf Ensure user is returned 2025-04-12 20:30:28 +02:00
David Heinemeier Hansson a579e67057 We are not using the parameter 2025-04-12 20:08:42 +02:00
David Heinemeier Hansson 6bbf68a4f9 The tenanted db is the account scope 2025-04-12 20:06:34 +02:00
David Heinemeier Hansson 19dbd5b325 Merge pull request #402 from basecamp/drop-boosts
Drop boosts
2025-04-12 18:54:46 +02:00
David Heinemeier Hansson 760cbb6c99 Drop boosts
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson 1b732c41c7 Use render svg 2025-04-12 18:15:05 +02:00