Commit Graph

862 Commits

Author SHA1 Message Date
Jose Farias d65d8a899b Merge pull request #209 from basecamp/drag-jankiness
Fix divider drag jankiness
2025-01-16 15:13:05 -06:00
Jose Farias fb27cee9b0 Unnecessary parens 2025-01-16 15:11:44 -06:00
Jose Farias 8877d2e66d Use distance to nearest edge
This feels the smoothest
2025-01-16 15:09:46 -06:00
Jose Farias dc6da76b38 Simplify overlap logic 2025-01-16 14:01:25 -06:00
Jose Farias af0783d8ff Fix divider drag jankiness 2025-01-16 13:54:42 -06:00
Kevin McConnell 6f8c929898 Use cache-friendly "time ago"
Also introduces a local time helper that we can use to format dates and
times.
2025-01-16 17:47:25 +00:00
Jose Farias 26f714189b Merge pull request #207 from basecamp/drag-divider
Drag bubble divider
2025-01-15 20:59:43 -06:00
Jose Farias 622e340e83 positionedClass -> installedClass 2025-01-15 20:31:09 -06:00
Jose Farias 775e29fb8e Pull out moveDividerTo 2025-01-15 20:26:56 -06:00
Jose Farias 40085b16d6 Before comes before After 2025-01-15 20:14:30 -06:00
Jose Farias 3ab6ee84d0 DividerElement -> Divider 2025-01-15 20:13:18 -06:00
Jose Farias 9b1c140eef Clean up divider-controller 2025-01-15 20:10:54 -06:00
Jose Farias dac9aa9d26 Drag bubble divider 2025-01-15 17:22:25 -06:00
Jose Farias e6e7cb2f72 Merge pull request #188 from basecamp/dependabot/bundler/hotwire_combobox-c280da0
Bump hotwire_combobox from `57ee6c9` to `c280da0`
2025-01-15 17:03:36 -06:00
Jose Farias 07ee06ddbd Merge pull request #205 from basecamp/simplify-filters
Simplify filters
2025-01-15 17:03:17 -06:00
Jose Farias 5ac9063a84 default_fields -> default_values 2025-01-15 16:57:02 -06:00
Jose Farias 4441dc7cd8 Test passing params in different order 2025-01-15 16:55:57 -06:00
Jose Farias 8d75429431 Remove old digest_params method 2025-01-15 16:45:15 -06:00
Jose Farias 19874dcc2a Test creating an equivalent filter with a different user 2025-01-15 16:41:25 -06:00
Jose Farias e9a085f848 Simplify filters 2025-01-15 16:27:33 -06:00
Kevin McConnell e807c2a8d1 Migration shouldn't unpublish existing bubbles 2025-01-15 12:34:58 +00:00
Kevin McConnell 8a114e0d8d Merge pull request #195 from basecamp/drafts
Draft bubbles
2025-01-15 12:08:06 +00:00
Kevin McConnell dbb3fd3b9c Simplify 2025-01-15 12:03:56 +00:00
Kevin McConnell 056d853cc8 Don't notify while bubbles are still drafted 2025-01-15 11:42:35 +00:00
Kevin McConnell 731f93b55a Add test 2025-01-15 10:58:00 +00:00
Kevin McConnell 782259a678 Events should track published now
Previously when an item was `created`, we'd track the event, update the
summary text, and broadcast the notifications. But now that we have a
draft state, we shold do all of this when it's published instead.
2025-01-15 10:58:00 +00:00
Kevin McConnell cd1e6378d0 Add drafted and published states 2025-01-15 10:58:00 +00:00
Kevin McConnell f209c23e45 Cache notification partial 2025-01-15 10:57:27 +00:00
Kevin McConnell b85d300df1 Fix casing warning in Dockerfile 2025-01-15 10:57:27 +00:00
Kevin McConnell b5f4f7015e Add missing libyaml dependency in Docker image 2025-01-15 10:57:27 +00:00
Kevin McConnell bab5bc718d Rename deployment targets 2025-01-15 10:57:27 +00:00
Jason Zimdars e7819328e8 A little janky but we probably don't want to navigate when you're typing a comment 2025-01-14 17:00:32 -06:00
Jason Zimdars 6a40256969 Prevent back navigation when cancelling comment edits 2025-01-14 16:57:29 -06:00
Jason Zimdars d20288f929 Don't trigger esc to go back when closing dialog 2025-01-14 16:53:38 -06:00
Jason Zimdars 1f911b234b Avoid navigating back when closing the filter dialog 2025-01-14 16:49:21 -06:00
Jason Zimdars a596d7cea7 Cancel and go back for forms with autofocused inputs 2025-01-14 16:45:29 -06:00
Jason Zimdars 39ff31b14b esc to cancel here, too 2025-01-14 16:04:41 -06:00
Jason Zimdars 95f077672b esc to navigate back to buckets index 2025-01-14 15:57:55 -06:00
Jason Zimdars f7f063ae0c Can just use @bucket 2025-01-14 15:49:25 -06:00
Jason Zimdars 32532c53cb Add bucket link/title so you know where you are 2025-01-14 15:48:49 -06:00
Kevin McConnell 55e6efd137 Merge pull request #199 from basecamp/notifs
Notifications
2025-01-14 15:25:47 +00:00
Kevin McConnell 345acb1c0b Add test for readings controller 2025-01-14 14:38:46 +00:00
Kevin McConnell b8ecfa0125 Replace notifications on read, instead of removing
Previously when a notification was read, we'd remove it from the list.
This will often be fine, but if there were more unread notifications
that hadn't been loaded yet (because there were too many for the initial
page) then the list could become empty when really there are still more
items to show.

So instead of removing the items when they're read, we can reload the
list with the new page of items. This should allow the older
notifications to come into view when necessary.
2025-01-14 14:23:46 +00:00
Kevin McConnell 9fc5311ddc Add simple controller test 2025-01-14 14:10:24 +00:00
Kevin McConnell 9ddb7b260b Remove empty test 2025-01-14 14:07:21 +00:00
Kevin McConnell 415e872a2b Combine concerns 2025-01-14 13:57:48 +00:00
Kevin McConnell c11b5af5e0 Make Stimulus controller more generic 2025-01-14 13:37:54 +00:00
Kevin McConnell df260840ab Simplify test 2025-01-14 13:29:39 +00:00
Kevin McConnell 78b7fe0f3d Fix tests 2025-01-14 13:21:20 +00:00
Kevin McConnell ab154f2f35 Generate notification content in a helper 2025-01-14 13:08:12 +00:00