Commit Graph

868 Commits

Author SHA1 Message Date
David Heinemeier Hansson 9359cac330 Style 2025-04-12 11:24:02 +02:00
David Heinemeier Hansson b2b9c99745 Style 2025-04-12 11:23:48 +02:00
David Heinemeier Hansson b8c3ac8145 Cache busting should happen as a comment in the partial, not as an actual key component 2025-04-12 11:22:31 +02:00
David Heinemeier Hansson 6f3ac772ea Merge branch 'main' into comments-refactoring
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
Jason Zimdars 5e608d33e1 Add this for debugging empty event cards 2025-04-11 13:21:47 -05:00
Jason Zimdars d3584adf35 Some actions shouldn't be available to closed cards 2025-04-11 13:21:47 -05:00
Jason Zimdars 89f76a080a Nicer spacing when the large button isn't present 2025-04-11 13:21:47 -05:00
Jason Zimdars c5fc847372 Update card-color in a couple more places 2025-04-11 13:21:47 -05:00
Jason Zimdars a76488fd49 Don't show the engagement toggle on closed cards 2025-04-11 13:21:47 -05:00
Jason Zimdars df96ee80fa Style drafted cards 2025-04-11 12:21:14 -05:00
Jason Zimdars 76336a52d6 This item makes no sense until it's saved 2025-04-11 11:56:26 -05:00
Jason Zimdars ee8559343a Tighten engagement switch design, only display it for published cards 2025-04-11 11:50:09 -05:00
David Heinemeier Hansson 09dd073cf7 Record lookup works here 2025-04-11 18:47:11 +02:00
David Heinemeier Hansson 51341c36d1 New partial isnt cached 2025-04-11 18:45:44 +02:00
David Heinemeier Hansson c8fe83e8f3 Indention 2025-04-11 18:43:52 +02:00
David Heinemeier Hansson 6effc1568f No need for a separate body partial 2025-04-11 18:41:26 +02:00
David Heinemeier Hansson 9ecb85013b Spacing 2025-04-11 18:25:49 +02:00
David Heinemeier Hansson 442fe6087c Use form object so we dont have to manually set the text_field name 2025-04-11 18:25:24 +02:00
David Heinemeier Hansson 06a636bd8d Did need to separate them out for the broadcast 2025-04-11 18:19:33 +02:00
David Heinemeier Hansson f0aa48b75d Indention 2025-04-11 18:13:29 +02:00
David Heinemeier Hansson fadf167630 Avoid needing to pass an extra variable to the reactions partial
Thanks to inverse_of, there's no extra query getting the comment from
the reaction.
2025-04-11 18:12:52 +02:00
David Heinemeier Hansson 227d5a8757 It is both reacting and reactions
So stick with the simpler dom id scope
2025-04-11 18:10:26 +02:00
David Heinemeier Hansson 73f1989861 Fix indention 2025-04-11 18:05:50 +02:00
David Heinemeier Hansson 3b711161d7 No need for a manual dom_id
turbo_frame_tag can do this directly
2025-04-11 18:04:21 +02:00
David Heinemeier Hansson 1145260890 No idea why this was here 2025-04-11 18:01:21 +02:00
David Heinemeier Hansson 5aa2b7da84 No need to cache individual reactions
Both because the reactions partial actually depends on multiple
variables but also because its just not worth it when we are caching the
comment.
2025-04-11 17:58:48 +02:00
David Heinemeier Hansson 7861b7c087 Just open one turbo stream per card
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
David Heinemeier Hansson 263b3336db Add missing CR 2025-04-11 17:50:53 +02:00
David Heinemeier Hansson 0954cfe008 Add CR 2025-04-11 17:48:01 +02:00
David Heinemeier Hansson 79700162fc Use correct stream name
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
David Heinemeier Hansson dc4e50fba5 Move messages partial under cards 2025-04-11 17:34:49 +02:00
David Heinemeier Hansson f4ce57e308 Move comments under cards 2025-04-11 16:21:44 +02:00
Jorge Manrubia ba6eab509c Refresh timers when morphing happens 2025-04-11 13:26:01 +02:00
Jorge Manrubia 825bbf808e Extract helper for card articles, use classes to determine when to show golden status 2025-04-11 12:01:52 +02:00
Jorge Manrubia aef75feead Only consider golden those cards in "doing" 2025-04-11 11:49:52 +02:00
Jorge Manrubia 4f3f322528 Rename inconsistency: go with goldness 2025-04-11 10:22:18 +02:00
Jason Zimdars da7a30203c Style golden cards 2025-04-10 17:14:04 -05:00
Jason Zimdars 5560976091 Merge branch 'main' into gold-cards
* main:
  Try a segmented toggle for engagement
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
Jason Zimdars 81ee2ab64d Try a segmented toggle for engagement 2025-04-10 16:06:35 -05:00
Jason Zimdars e4110734eb Rework min card design and meta section for all cards 2025-04-10 14:39:50 -05:00
Jason Zimdars 296ac0c8b5 Remove sorting filter UI 2025-04-10 11:07:22 -05:00
Jorge Manrubia 9029853bdf Only show the button when card is in "doing" 2025-04-10 17:11:00 +02:00
Jorge Manrubia 2e5b25a30c Always place golden cards first 2025-04-10 17:05:30 +02:00
Jorge Manrubia 7406a1039f Add models to track gold cards and implement basic toggle behavior 2025-04-10 16:48:12 +02:00
Jason Zimdars 84276e85ba Ensure overflow cards are hidden 2025-04-10 09:43:09 -05:00
Jason Zimdars 6d610e6418 Dialog target needs to be present 2025-04-10 09:09:26 -05:00
Jason Zimdars 0746a63832 This isn't necessary in the mini card template 2025-04-10 09:09:16 -05:00
Jason Zimdars e3b071c603 Revert "The button and dialog need not render in previews"
This reverts commit 2c79ca09d7.
2025-04-10 08:45:43 -05:00
Jorge Manrubia c7b3b45977 Merge pull request #391 from basecamp/cards-pagination-2
Paginate collection cards
2025-04-10 15:10:54 +02:00
Jorge Manrubia 695247ae9b Paginate collection cards 2025-04-10 15:09:56 +02:00