Commit Graph

804 Commits

Author SHA1 Message Date
Kevin McConnell df1225e58d Style 2025-01-13 14:21:47 +00:00
Kevin McConnell febcb6c344 A partial is clearer than a helper here 2025-01-13 14:21:47 +00:00
Kevin McConnell 10c7b61af9 Split up a long line for clarity 2025-01-13 14:21:47 +00:00
Kevin McConnell 31ac7950ce Use turbo:click, not click
Otherwise Turbo falls back to a regular Browser navigation.
2025-01-13 14:21:47 +00:00
Kevin McConnell d536358228 Make fixture match expected content 2025-01-13 14:21:47 +00:00
Kevin McConnell 07fcb7ee6b More style shuffling 2025-01-13 14:21:47 +00:00
Kevin McConnell 6f7268f941 Set ID so a notification can't show up twice 2025-01-13 14:21:47 +00:00
Kevin McConnell 66d0f29d45 Notify on pop as well
And DRY up some duplication.
2025-01-13 14:21:47 +00:00
Kevin McConnell e67ac372d3 Fix test 2025-01-13 14:21:47 +00:00
Kevin McConnell fd1789ed58 Mark notifications read when clicked on 2025-01-13 14:21:47 +00:00
Kevin McConnell 58ce85ce36 Link comment notifications to the comment 2025-01-13 14:21:47 +00:00
Kevin McConnell 876083c697 Broadcast new notifications 2025-01-13 14:21:47 +00:00
Kevin McConnell a7d9ec908c Adjust styles 2025-01-13 14:21:47 +00:00
Kevin McConnell 58d5ed07a5 Create notifications when tracking events 2025-01-13 14:21:47 +00:00
Kevin McConnell fcce5b85e0 Show notifications on bucket index 2025-01-13 14:21:47 +00:00
Kevin McConnell dc53a39b93 Update notification body 2025-01-13 14:21:47 +00:00
Kevin McConnell 0c152b5439 Style the tray a little bit 2025-01-13 14:21:47 +00:00
Kevin McConnell 8a51597408 Add direct linking to comments 2025-01-13 14:21:47 +00:00
Kevin McConnell af5ac65116 Make notification target polymorphic 2025-01-13 14:21:47 +00:00
Kevin McConnell 952895ae67 WIP: show notifications in a tray 2025-01-13 14:21:47 +00:00
Kevin McConnell 6b5e098407 Use a better return value 2025-01-13 14:21:47 +00:00
Kevin McConnell a082eb75f5 Track events for new comments too 2025-01-13 14:21:47 +00:00
Kevin McConnell 5a56c16029 Add a factory for creating notifications 2025-01-13 14:21:47 +00:00
Kevin McConnell d0ae5b4bdc Add notification model 2025-01-13 14:21:47 +00:00
Kevin McConnell c84926692e Never show login page to a logged in user 2025-01-13 14:20:42 +00:00
Kevin McConnell e7bc04856f Broadcast bucket changes to index page
This will cause each filtered view to stay updated as the items in the
buckets change.

For filters that are specific to buckets, we listen to broadcasts on
those buckets; for filters on "All projects" we listen instead for
broadcasts on an account-specific channel. This is so that "All
projects" views will be aware of any new buckets that are added, while
also avoid unnecessary refreshes from buckets that are filtered out.
2025-01-09 09:14:22 +00:00
Kevin McConnell 22be073a92 Sanitize search terms 2025-01-08 16:49:40 +00:00
Kevin McConnell 90538afb3b Add Solid Queue
We'll run jobs via the Puma plugin for now, to simplify the deployment.
2025-01-08 14:02:45 +00:00
Kevin McConnell 2e892e0766 Add Solid Cache 2025-01-08 14:02:45 +00:00
Kevin McConnell 5c19c3422b Only show create button when in single bucket 2025-01-07 15:04:42 +00:00
Kevin McConnell 93536c3e41 Don't reload entire page when creating comment 2025-01-07 14:47:31 +00:00
Kevin McConnell 4a4b4113c8 Don't use a new request for every comment 2025-01-07 14:14:12 +00:00
Kevin McConnell 21632f30cd Use latest Thruster 2025-01-07 08:28:08 +00:00
Kevin McConnell 67f4038d46 Don't use fixtures as seeds
Otherwise each new deployment starts out with dev data instead of going
through the first run flow.
2025-01-06 10:58:09 +00:00
Kevin McConnell 6df4637309 Require 'logger' to prevent warning in Ruby 3.4 2025-01-06 10:48:52 +00:00
Kevin McConnell 15bd015c3b Add staging deploy config 2025-01-06 10:48:52 +00:00
Kevin McConnell 648e9b2296 Add solid_cable 2025-01-03 16:29:43 +00:00
Kevin McConnell 50b803aab1 Ruby 3.4.1 2025-01-03 15:21:14 +00:00
Jose Farias 7b2bf7b99c Merge pull request #179 from basecamp/dependabot/bundler/hotwire-spark-0.1.12
Bump hotwire-spark from 0.1.7 to 0.1.12
2024-12-29 12:14:45 -06:00
dependabot[bot] 25b84035e0 Bump hotwire-spark from 0.1.7 to 0.1.12
Bumps [hotwire-spark](https://github.com/hotwired/spark) from 0.1.7 to 0.1.12.
- [Release notes](https://github.com/hotwired/spark/releases)
- [Commits](https://github.com/hotwired/spark/compare/v0.1.7...v0.1.12)

---
updated-dependencies:
- dependency-name: hotwire-spark
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-26 20:25:54 +00:00
David Heinemeier Hansson 84a07343a4 Use stale_when_importmap_changes 2024-12-20 17:42:14 -08:00
Jason Zimdars a531e627c6 Polish comments 2024-12-20 17:12:28 -06:00
Jose Farias f8b7b1f10b Merge pull request #173 from basecamp/dependabot/bundler/hotwire-spark-0.1.7 2024-12-20 15:07:08 -06:00
dependabot[bot] 9108df743e Bump hotwire-spark from 0.1.4 to 0.1.7
Bumps [hotwire-spark](https://github.com/basecamp/hotwire_spark) from 0.1.4 to 0.1.7.
- [Release notes](https://github.com/basecamp/hotwire_spark/releases)
- [Commits](https://github.com/basecamp/hotwire_spark/compare/v0.1.4...v0.1.7)

---
updated-dependencies:
- dependency-name: hotwire-spark
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-20 20:55:59 +00:00
Jose Farias 4080db742d Merge pull request #163 from basecamp/dependabot/bundler/sentry-rails-5.22.1
Bump sentry-rails from 5.22.0 to 5.22.1
2024-12-19 18:06:06 -06:00
dependabot[bot] 2ce861c944 Bump sentry-rails from 5.22.0 to 5.22.1
Bumps [sentry-rails](https://github.com/getsentry/sentry-ruby) from 5.22.0 to 5.22.1.
- [Release notes](https://github.com/getsentry/sentry-ruby/releases)
- [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-ruby/compare/5.22.0...5.22.1)

---
updated-dependencies:
- dependency-name: sentry-rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-19 22:55:37 +00:00
Jose Farias 841333c064 Merge pull request #169 from basecamp/dependabot/bundler/debug-1.10.0
Bump debug from 1.9.2 to 1.10.0
2024-12-19 16:53:56 -06:00
Jose Farias 651a281037 Merge pull request #171 from basecamp/dependabot/bundler/hotwire-spark-0.1.4
Bump hotwire-spark from 0.1.3 to 0.1.4
2024-12-19 16:53:38 -06:00
Jason Zimdars 1530b76af8 Hit esc to navigate back after opening a bubble 2024-12-19 16:22:01 -06:00
dependabot[bot] cf1e7a40b5 Bump hotwire-spark from 0.1.3 to 0.1.4
Bumps [hotwire-spark](https://github.com/basecamp/hotwire_spark) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/basecamp/hotwire_spark/releases)
- [Commits](https://github.com/basecamp/hotwire_spark/compare/v0.1.3...v0.1.4)

---
updated-dependencies:
- dependency-name: hotwire-spark
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-19 20:21:38 +00:00