Commit Graph

7443 Commits

Author SHA1 Message Date
Jorge Manrubia e0d3e7f170 Merge pull request #1746 from basecamp/scroll-columns
Fix: scrolling to parent navigable list despite of setting
2025-11-27 18:06:44 +01:00
Jorge Manrubia 0a0a8642c9 Fix: scrolling to parent navigable list despite of setting
We need to check the setting of the parent controller

https://app.fizzy.do/5986089/cards/3184
2025-11-27 18:04:38 +01:00
Stanko Krtalić 3bd9daabd7 Merge pull request #1745 from basecamp/fix-join-codes-skipping-user-setup
Fix join codes skipping user setup
2025-11-27 18:04:37 +01:00
Stanko K.R. e3d91f4ba2 Fix join codes skipping user setup
If someone joined an account with the same identity as they were signed in with the old logic would skip the user setup step
2025-11-27 17:59:17 +01:00
Jason Zimdars bc16fae3ef Merge pull request #1738 from basecamp/done-column-expand-fix
Fix that 'closed'->'done' change broke this route
2025-11-27 09:19:53 -06:00
Jason Zimdars 29e62ac90c Fix that board button was leaking to the right of columns
See: https://app.fizzy.do/5986089/cards/3148
2025-11-27 09:18:33 -06:00
Jason Zimdars 5e971f41af Set entropy to 1 year so cards don't close before they can play 2025-11-27 09:18:33 -06:00
Mike Dalessio 2edf79672e Improve AGENTS.md with some loki suggestions
Suggested by Claude after I yelled at it when it was using string
matching instead of the structured fields.
2025-11-27 09:18:33 -06:00
Jorge Manrubia 0453526bf1 Prevent Fizzy menu from closing on page refreshes
https://app.fizzy.do/5986089/cards/3190
2025-11-27 09:18:33 -06:00
Mike Dalessio 887f100c50 Rename bin/gitleaks to gitleaks-audit
to prevent script recursion if bin is in user's $PATH
2025-11-27 09:18:33 -06:00
Jason Zimdars 4b9483112e Merge pull request #1739 from basecamp/fix-board-btn
Fix that board button was leaking to the right of columns
2025-11-27 09:18:04 -06:00
Jason Zimdars 980e497242 Set entropy to 1 year so cards don't close before they can play 2025-11-27 09:16:32 -06:00
Mike Dalessio 9d9c0ab2f3 Improve AGENTS.md with some loki suggestions
Suggested by Claude after I yelled at it when it was using string
matching instead of the structured fields.
2025-11-27 09:16:32 -06:00
Jorge Manrubia 67c77e1c23 Prevent Fizzy menu from closing on page refreshes
https://app.fizzy.do/5986089/cards/3190
2025-11-27 09:16:32 -06:00
Mike Dalessio 06730cbbb9 Rename bin/gitleaks to gitleaks-audit
to prevent script recursion if bin is in user's $PATH
2025-11-27 09:16:32 -06:00
Jason Zimdars 742f652ded Merge pull request #1740 from basecamp/playground-seeder
Set entropy to 1 year so cards don't close before they can play
2025-11-27 09:15:53 -06:00
Mike Dalessio 41dfcd6bee Improve AGENTS.md with some loki suggestions
Suggested by Claude after I yelled at it when it was using string
matching instead of the structured fields.
2025-11-27 09:13:57 -06:00
Jorge Manrubia e44524ebc3 Prevent Fizzy menu from closing on page refreshes
https://app.fizzy.do/5986089/cards/3190
2025-11-27 09:13:57 -06:00
Mike Dalessio fced0a48ee Rename bin/gitleaks to gitleaks-audit
to prevent script recursion if bin is in user's $PATH
2025-11-27 09:13:57 -06:00
Mike Dalessio afcd2a6132 Merge pull request #1736 from basecamp/flavorjones/improve-agents.md
Improve AGENTS.md with some loki suggestions
2025-11-27 08:47:42 -05:00
Jorge Manrubia 30ad851a77 Merge pull request #1743 from basecamp/refreshes
Prevent Fizzy menu from closing on page refreshes
2025-11-27 07:13:06 +01:00
Jorge Manrubia 5e23e6c3d3 Prevent Fizzy menu from closing on page refreshes
https://app.fizzy.do/5986089/cards/3190
2025-11-27 07:07:27 +01:00
Mike Dalessio a556fe9f8c Merge pull request #1741 from basecamp/flavorjones/fix-gitleaks-recursion
Rename bin/gitleaks to gitleaks-audit
2025-11-26 21:37:46 -05:00
Mike Dalessio f0b2603ba4 Rename bin/gitleaks to gitleaks-audit
to prevent script recursion if bin is in user's $PATH
2025-11-26 21:36:01 -05:00
Mike Dalessio e8671d11fa Improve AGENTS.md with some loki suggestions
Suggested by Claude after I yelled at it when it was using string
matching instead of the structured fields.
2025-11-26 17:48:37 -05:00
Jason Zimdars d46761d89c Set entropy to 1 year so cards don't close before they can play 2025-11-26 16:03:02 -06:00
Jason Zimdars 8ec1a5c760 Fix that board button was leaking to the right of columns
See: https://app.fizzy.do/5986089/cards/3148
2025-11-26 15:38:26 -06:00
Jason Zimdars 48d9a25820 Fix that 'closed'->'done' change broke this route 2025-11-26 14:58:17 -06:00
Mike Dalessio a83735d434 Merge pull request #1737 from basecamp/flavorjones/gitleaks
Introduce gitleaks to the codebase
2025-11-26 15:55:34 -05:00
Mike Dalessio 7f46063c25 Introduce gitleaks to the codebase
- `bin/setup` installs gitleaks
- add `gitleaks dir` command to CI
- configure gitleaks to ignore tmp, log, and encrypted files
- tag existing false positives with `gitleaks:allow`
- add historical false positives to the ignore list
2025-11-26 15:46:47 -05:00
Mike Dalessio 1534485477 Merge pull request #1735 from basecamp/flavorjones/simplify-current-with-account
Simplify Current.with_account and .without_account
2025-11-26 12:32:23 -05:00
Mike Dalessio 9446bc18d2 Simplify Current.with_account and .without_account
Co-authored-by: Jeffrey Hardy <jeff@37signals.com>
2025-11-26 12:31:49 -05:00
Jason Zimdars a9bb534d86 Merge pull request #1734 from basecamp/reactions-polish
Reactions polish
2025-11-26 11:31:37 -06:00
Jason Zimdars e26845709a Disable focus ring 2025-11-26 11:24:13 -06:00
Jason Zimdars 9ca4cda5e4 Larger emojis in picker, fit on narrow viewports 2025-11-26 11:13:18 -06:00
Rosa Gutierrez 3e716bfa26 Fix a couple of typos 2025-11-26 13:16:44 +01:00
Donal McBreen 9c08f68884 Merge pull request #1669 from basecamp/sqlite
Sqlite
2025-11-26 10:32:09 +00:00
Donal McBreen 761f86d78d Revert unnecessary fixture change 2025-11-26 10:30:02 +00:00
Donal McBreen 18fa877882 Switch to a pool size of 5 2025-11-26 10:27:06 +00:00
Donal McBreen a5fc6eeaec Update SQLite schema 2025-11-26 10:18:55 +00:00
Donal McBreen c4498212dc Merge branch 'main' into sqlite
* main: (116 commits)
  Ensure avatar thumbnails are square
  Update useragent to recognize twitterbot/facebot
  Add defensive styles for non-square avatar images
  Update test for copy changes
  Missed commit
  AI: standardize on https://agents.md
  Make it clear this is just notifications, not comprehensive activity
  AI: configure MCP servers for Chrome, Grafana, and Sentry (#1727)
  Allow requests from Google Image Proxy
  Update to basecamp's useragent fork
  Clean up a little bit the CSRF reporting code
  Claude: production observability guidance (#1725)
  Prevent autoscroll to the root columns container to prevent jump on page load
  Include full name string so you can type your name to filter
  Prioritize current user and assigned users in assignment dropdown
  Check and report on Sec-Fetch-Site header for forgery protection
  bundle update
  Bump bootsnap from 1.18.6 to 1.19.0
  Bump rails from `077c3ad` to `17f6e00`
  Fix cards getting stuck in edit mode
  ...
2025-11-26 10:07:41 +00:00
Donal McBreen b839340cf2 Tidy up modules and on_load points 2025-11-26 10:02:32 +00:00
Donal McBreen 9c86205510 Enforce SQLite column limits via CHECK constraints
Patch the sqlite adapter to add CHECK constraints for string and text
column limits. We'll do them inline, so that any column changes
automatically update the constraints.
2025-11-26 09:50:29 +00:00
Kevin McConnell e7d716c0f1 Merge pull request #1731 from basecamp/avatar-thumb-aspect-ratio
Ensure avatar thumbnails are square
2025-11-26 09:30:33 +00:00
Kevin McConnell ca5065a378 Ensure avatar thumbnails are square
Previously we were fitting the image inside a 256x256 box while keeping
it's original aspect ratio. But this can lead to images that are
squished and/or pixelated when we try to show them inside a square
container in the app.

Instead we can resize them to be square.
2025-11-26 09:21:46 +00:00
Mike Dalessio e1d356d063 Merge pull request #1730 from basecamp/flavorjones/twitterbot-facebot
Update useragent to recognize twitterbot/facebot
2025-11-25 18:09:56 -05:00
Mike Dalessio 60e1751cac Update useragent to recognize twitterbot/facebot
This UA was pulled from our logs.

ref: https://app.fizzy.do/5986089/cards/1775
2025-11-25 18:05:21 -05:00
Jason Zimdars abbf226c3a Merge pull request #1729 from basecamp/avatar-bulletproofing
Add defensive styles for non-square avatar images
2025-11-25 16:56:02 -06:00
Jason Zimdars d825447e6b Add defensive styles for non-square avatar images 2025-11-25 16:51:07 -06:00
Mike Dalessio 64a39b3139 Merge pull request #1726 from basecamp/flavorjones/better-useragent-behavior
Allow requests from Google Image Proxy
2025-11-25 17:15:38 -05:00