Commit Graph

26 Commits

Author SHA1 Message Date
Jason Zimdars 468a29c9ad Give them screen reader labels
See: https://fizzy.37signals.com/5986089/collections/2/cards/1106
2025-07-16 11:33:33 -05:00
Jason Zimdars f0235e7e07 Not needed
See: https://fizzy.37signals.com/5986089/collections/2/cards/1108
2025-07-16 11:08:06 -05:00
Andy Smith 757ff4ff2b Merge branch 'main' into focus-hover-styles 2025-07-03 15:14:14 -05:00
Andy Smith 4bc1b36d3d Clean up --hover variables 2025-07-02 16:14:34 -05:00
Jason Zimdars 985337a91c Esc should not propagate when closing dialogs 2025-07-02 14:29:15 -05:00
Andy Smith 8d1a4ec73a Close ghost space when no reactions exist 2025-05-07 15:15:28 -05:00
Andy Smith c69402a300 Get turboframes sorted out 2025-05-07 15:02:34 -05:00
Andy Smith 3710aa43e4 Stub out overflow reactions 2025-05-07 14:29:29 -05:00
Andy Smith 5b8f108316 Gentler react animation 2025-05-06 17:02:03 -05:00
Andy Smith 9034498f40 Fix hidden field value 2025-05-06 16:49:14 -05:00
Andy Smith 9b49606246 Consistently align and size all elements 2025-05-06 16:37:01 -05:00
Andy Smith d3d7a25d07 Stub out basic emoji presets 2025-05-06 10:43:56 -05:00
David Heinemeier Hansson 9ecb85013b Spacing 2025-04-11 18:25:49 +02:00
David Heinemeier Hansson 442fe6087c Use form object so we dont have to manually set the text_field name 2025-04-11 18:25:24 +02:00
David Heinemeier Hansson 06a636bd8d Did need to separate them out for the broadcast 2025-04-11 18:19:33 +02:00
David Heinemeier Hansson f0aa48b75d Indention 2025-04-11 18:13:29 +02:00
David Heinemeier Hansson fadf167630 Avoid needing to pass an extra variable to the reactions partial
Thanks to inverse_of, there's no extra query getting the comment from
the reaction.
2025-04-11 18:12:52 +02:00
David Heinemeier Hansson 227d5a8757 It is both reacting and reactions
So stick with the simpler dom id scope
2025-04-11 18:10:26 +02:00
David Heinemeier Hansson 73f1989861 Fix indention 2025-04-11 18:05:50 +02:00
David Heinemeier Hansson 3b711161d7 No need for a manual dom_id
turbo_frame_tag can do this directly
2025-04-11 18:04:21 +02:00
David Heinemeier Hansson 1145260890 No idea why this was here 2025-04-11 18:01:21 +02:00
David Heinemeier Hansson 5aa2b7da84 No need to cache individual reactions
Both because the reactions partial actually depends on multiple
variables but also because its just not worth it when we are caching the
comment.
2025-04-11 17:58:48 +02:00
David Heinemeier Hansson 7861b7c087 Just open one turbo stream per card
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
David Heinemeier Hansson 0954cfe008 Add CR 2025-04-11 17:48:01 +02:00
David Heinemeier Hansson 79700162fc Use correct stream name
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
David Heinemeier Hansson f4ce57e308 Move comments under cards 2025-04-11 16:21:44 +02:00