Commit Graph

4101 Commits

Author SHA1 Message Date
Andy Smith 8d60592ccd Merge pull request #720 from basecamp/notification-links
Notification links
2025-07-10 17:04:31 -05:00
Andy Smith 83b262aff8 Merge pull request #740 from basecamp/mobile-card-improvements
Mobile card improvements
2025-07-10 16:44:37 -05:00
Andy Smith 71ead7f35a Hide empty p tag 2025-07-10 16:34:11 -05:00
Jason Zimdars 70c2cc62a1 Merge branch 'main' into public-collection-cards
* main:
  Revert "Adjust borders"
  Don't allow wrapping initially
  Adjust borders
  Truncate long commands
  Try using env safe insets to avoid overlapping elements on mobile
  Correct asset width and remove caption input focus ring
  Revert "Make a focus-ring global variable"
  Make a focus-ring global variable
  Set `id` explicitly so the `label for` reference works
  Higher resolution image
  When adding a card out of context, default to most recently accessed collection
  Fine tuning to handle different attachment types
  Replace helper with view lookup
  Make nil safe
  Extract attachments to a partial
  Remove `card_published` check and render its own template
  Extract common concern to examine attachments
  This is a hack but we should be showing the card description and attachments for new cards
  Display attachments in events for comments
  Indicate cards with attachments in the description
2025-07-10 16:33:51 -05:00
Jason Zimdars 74ac6fae9e Merge branch 'mobile-insets'
* mobile-insets:
  Revert "Adjust borders"
  Don't allow wrapping initially
  Adjust borders
  Try using env safe insets to avoid overlapping elements on mobile
2025-07-10 16:31:34 -05:00
Andy Smith af097e3747 Move workflow below title when it won't fit comfortably on the side 2025-07-10 16:23:22 -05:00
Andy Smith cebbc390a1 Consistent card title size 2025-07-10 16:17:10 -05:00
Andy Smith bd8f37e742 Tighten up space below header 2025-07-10 16:16:52 -05:00
Andy Smith 35ea2c3921 Use vw units for main padding 2025-07-10 16:16:40 -05:00
Jason Zimdars aa32b482ae Revert "Adjust borders"
This reverts commit 14979f3000.
2025-07-10 16:06:58 -05:00
Jason Zimdars 74e0cd3af8 Don't allow wrapping initially 2025-07-10 14:50:36 -05:00
Jason Zimdars 14979f3000 Adjust borders 2025-07-10 14:48:50 -05:00
Andy Smith 0585c5f1e1 Truncate long commands 2025-07-10 14:44:22 -05:00
Jason Zimdars 0d1c0f4e75 Try using env safe insets to avoid overlapping elements on mobile 2025-07-10 14:26:58 -05:00
Andy Smith 221c2b30f5 Correct asset width and remove caption input focus ring 2025-07-10 14:04:27 -05:00
Andy Smith 20111d8830 Revert "Make a focus-ring global variable"
This reverts commit 39a8e60cbc.
2025-07-10 14:01:48 -05:00
Andy Smith 39a8e60cbc Make a focus-ring global variable 2025-07-10 14:00:00 -05:00
Jason Zimdars 4d65d2be85 Set id explicitly so the label for reference works 2025-07-10 12:56:59 -05:00
Andy Smith 073dfd2ae1 Tweak the hat padding 2025-07-10 11:34:08 -05:00
Andy Smith 5162677c44 Align dialog, shrink hat, canvas background 2025-07-10 11:20:37 -05:00
Jorge Manrubia 81560c73dd Use existing direct route 2025-07-10 14:57:20 +02:00
Jason Zimdars ed37bf0ff8 When adding a card out of context, default to most recently accessed collection 2025-07-09 15:37:39 -05:00
Jason Zimdars 32e967c1f9 Fine tuning to handle different attachment types 2025-07-09 14:46:33 -05:00
Jason Zimdars 7a058a18d9 Merge branch 'main' into card-attachments
* main:
  Add circle-on-mobile button class
2025-07-09 11:22:41 -05:00
Jason Zimdars a60eedf186 Merge branch 'main' into public-collection-cards
* main:
  Add circle-on-mobile button class
2025-07-09 11:20:41 -05:00
Jason Zimdars cd022fcc1c Not fit for public 2025-07-09 11:10:41 -05:00
Jason Zimdars 55f92e73f7 Not needed here 2025-07-09 11:08:09 -05:00
Jason Zimdars abc2b49992 We don't need this after all 2025-07-09 11:06:29 -05:00
Jason Zimdars b309f85d13 Match text style 2025-07-09 11:03:43 -05:00
Jason Zimdars 90419084c3 Ensure step checkboxes reflect status and can't be toggled 2025-07-09 11:01:54 -05:00
Jason Zimdars b142b08c05 Include lightbox viewer for background images 2025-07-09 10:58:23 -05:00
Jason Zimdars 4433e80691 Make steps non-interactive 2025-07-09 10:56:32 -05:00
Jason Zimdars dab3b844a2 We're not going to fake it to avoid turbo previews 2025-07-09 10:48:30 -05:00
Jason Zimdars 4cbe635faf No title links 2025-07-09 10:48:06 -05:00
Jason Zimdars bfa61705b6 Use existing preview templates 2025-07-09 10:47:39 -05:00
Jason Zimdars 9ac5f46875 This shouldn't ever appear on the index, we have a preview partial 2025-07-09 10:44:53 -05:00
Jason Zimdars f1337048bd This shouldn't need to be here, it would never be displayed and does nothing 2025-07-09 10:42:03 -05:00
Jason Zimdars 8f7a373aad Public card templates 2025-07-09 10:16:39 -05:00
Jorge Manrubia 78d446369c Replace helper with view lookup 2025-07-09 17:11:27 +02:00
Andy Smith 6627482f04 Add circle-on-mobile button class 2025-07-09 10:11:12 -05:00
Jason Zimdars badff5526d Move to layout so all public views display footer 2025-07-09 10:09:54 -05:00
Jason Zimdars e77710c6b6 Cards inherit their collection's publication status 2025-07-09 10:08:47 -05:00
Jason Zimdars 97e20c5cd7 Make nil safe 2025-07-08 16:57:48 -05:00
Jason Zimdars 642c03b51f Extract attachments to a partial 2025-07-08 16:34:10 -05:00
Jason Zimdars 8d162be5e3 Remove card_published check and render its own template 2025-07-08 16:16:33 -05:00
Jason Zimdars 485e575c40 Merge branch 'main' into card-attachments
* main: (45 commits)
  Display tag counts in the filter menu
  Move Add Card button to header
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  ...
2025-07-08 16:04:14 -05:00
Jason Zimdars 27285a3dcb Display tag counts in the filter menu
- Provides a little information scent
- Prevents being surprised by "no results"
2025-07-08 15:57:29 -05:00
Andy Smith fdbb9c185e Merge branch 'main' into collection-nav
* main: (203 commits)
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  Remove unused code
  Make sure we don't remove accesses if collection is accessible
  ...
2025-07-08 15:34:01 -05:00
Andy Smith 00d68a482c Move Add Card button to header 2025-07-08 15:30:43 -05:00
Andy Smith 0491cd0818 More subtle styles 2025-07-08 15:00:06 -05:00