Commit Graph

4101 Commits

Author SHA1 Message Date
Jason Zimdars 5d34cb3f51 Adjust screen for screen readers 2025-07-03 14:37:31 -05:00
Jason Zimdars 512cd32b2d Adjust icon sizing and uploading styles 2025-07-03 14:36:15 -05:00
Jason Zimdars 2f566bcaa2 Merge branch 'main' into jz-7-3-25
* main:
  Update lexical to fix problem with multi file uploads
  Update to include fix for Safari
  Broadcast when all notifications are cleared
2025-07-03 11:48:25 -05:00
Mike Dalessio 53ebb509d8 Broadcast when all notifications are cleared
Then make the turbo response to clearing all notifications a no-op.

This has the bonus side effect of properly clearing the notifications
try on all open pages.

ref: https://fizzy.37signals.com/5986089/collections/2/cards/796
2025-07-03 12:05:41 -04:00
Jason Zimdars 24fa687b2d Merge branch 'main' into jz-7-3-25
* main: (57 commits)
  Rename /add_card => /add
  Cards' "stalled" metric is reset when reconsidered
  Use composite commands even for single commands since they can carry custom titles, which is what we want with AI
  Fix merge issues
  More prompt tweaks
  Support completed by via natural language
  Add filter pill for completed by
  Add "close by" filter
  Add /reopen command
  Improved support to act on cards via ID
  Refine prompt
  Add more tests and fix failing ones
  Add clarifying comment
  Return standalone command when only one command
  Extract attachable concerns
  Format
  Update lexical
  Use your user gid to resolve yourself, so that this is not ambiguous
  Support trailing spaces in inserted commands
  Disable attachments in the terminal
  ...
2025-07-03 11:04:15 -05:00
Mike Dalessio 19af7c7c50 Merge pull request #704 from basecamp/flavorjones/reconsider-resets-stalling
Cards' "stalled" metric is reset when reconsidered
2025-07-03 11:26:30 -04:00
Jorge Manrubia f18b79d464 Rename /add_card => /add 2025-07-03 17:23:56 +02:00
Mike Dalessio d376d7aa0c Cards' "stalled" metric is reset when reconsidered
Specifically, reconsidering removes the existing activity spike (if
one exists). This happens whether the card is reconsidered by entropy
or manually by a user.

ref: https://fizzy.37signals.com/5986089/collections/2/cards/916
2025-07-03 11:15:08 -04:00
Jason Zimdars 954d209cbc Link should break out of frame 2025-07-03 10:13:09 -05:00
Jason Zimdars 1dfe541bd4 Allow deselecting a Workflow 2025-07-03 10:11:36 -05:00
Jason Zimdars 277965e8dc Don't show duplicate searches 2025-07-03 09:51:44 -05:00
Jason Zimdars 645d4b3497 Fix broken page title 2025-07-03 09:35:24 -05:00
Jorge Manrubia a1a8828191 Merge pull request #684 from basecamp/fizzy-do-prompts
Add prompts to the Fizzy menu
2025-07-03 16:28:31 +02:00
Jorge Manrubia 702169384c Use composite commands even for single commands since they can carry custom titles, which is what we want with AI 2025-07-03 16:26:52 +02:00
Jorge Manrubia bd7b9a442e Merge branch 'main' into fizzy-do-prompts
* main: (57 commits)
  Untenanted access in authenticated controllers should request auth
  dep: bundle update
  dep: update Rails
  dep: bump AR::Tenanted
  Clean up the cable meta tag
  Fix activity feed pagination to fetch on demand
  Create a "published" event if a card is created published
  Scatter Honcho seeds over a 30 day period
  Fix the PWA manifest to use slugged URLs
  Collection publication edits render a turbo frame
  Collection workflow edits render a turbo frame
  Collection entropy config edits render a turbo frame
  Use automatic sizing where supported
  Introduce a separate controller for collection entropy config
  Add `card_id` to index
  Move to scope and inline method
  Prefer modern syntax
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  ...

# Conflicts:
#	db/schema.rb
#	db/schema_cache.yml
2025-07-03 16:11:00 +02:00
Mike Dalessio b667c1f9cd PWS manifest uses paths and not URLs 2025-07-03 10:10:03 -04:00
Jorge Manrubia 7794dd2fc4 More prompt tweaks 2025-07-03 16:07:21 +02:00
Mike Dalessio 0c341d14e1 Untenanted access in authenticated controllers should request auth 2025-07-03 10:05:55 -04:00
Mike Dalessio a268a5f00b Merge pull request #697 from basecamp/flavorjones/fix-pwa
Fix the PWA manifest to use slugged URLs
2025-07-03 10:05:46 -04:00
Jorge Manrubia f4147bda27 Support completed by via natural language 2025-07-03 15:52:11 +02:00
Jorge Manrubia 5ccb69a8d4 Add filter pill for completed by
This is pending to de-duplicate and tidy up, will do separately
2025-07-03 14:38:28 +02:00
Jorge Manrubia cd9955d938 Add "close by" filter 2025-07-03 14:32:03 +02:00
Jorge Manrubia ac2400a657 Add /reopen command 2025-07-03 13:52:12 +02:00
Jorge Manrubia a2ca8b1dc0 Improved support to act on cards via ID 2025-07-03 13:09:10 +02:00
Jorge Manrubia 75387891d5 Refine prompt 2025-07-03 12:54:24 +02:00
Jorge Manrubia ca4628b457 Add more tests and fix failing ones 2025-07-03 12:46:36 +02:00
Jorge Manrubia 98e568482a Add clarifying comment 2025-07-03 11:42:29 +02:00
Jorge Manrubia 96faca3ff6 Return standalone command when only one command
this avoids unnecessary redirects
2025-07-03 11:39:46 +02:00
Jorge Manrubia 9b897191d0 Extract attachable concerns 2025-07-03 11:25:47 +02:00
Jorge Manrubia 3684eaa7a0 Format 2025-07-03 11:22:43 +02:00
Jorge Manrubia 8e7268cd6e Use your user gid to resolve yourself, so that this is not ambiguous 2025-07-03 10:09:01 +02:00
Jorge Manrubia 11d2b005a2 Support trailing spaces in inserted commands 2025-07-03 09:57:01 +02:00
Jorge Manrubia 75a8316609 Disable attachments in the terminal 2025-07-03 09:35:38 +02:00
Mike Dalessio 02ec9d436a Clean up the cable meta tag
to avoid a "//" appearing in the path.
2025-07-03 01:49:35 -04:00
Mike Dalessio a565504113 Fix activity feed pagination to fetch on demand
Commit 01c642e6 restructured the page so that the "next page" link was
always in view, meaning the page always loaded the entire history.

Now we load the next day as the user scrolls to the bottom, as intended.
2025-07-03 01:36:21 -04:00
Mike Dalessio 31007c7bdb Create a "published" event if a card is created published
This isn't the normal workflow in the app, but this problem will show
up if we create cards programmatically (e.g., the seeds)
2025-07-03 01:08:53 -04:00
Mike Dalessio 59548ac7eb Fix the PWA manifest to use slugged URLs
ref: https://fizzy.37signals.com/5986089/collections/2/cards/991
2025-07-02 23:51:00 -04:00
Mike Dalessio ccf961dad2 Merge pull request #696 from basecamp/flavorjones/collection-workflow-save
Collection edit page uses turbo frames to avoid resetting the user access form
2025-07-02 22:28:51 -04:00
Mike Dalessio 4589360dd1 Collection publication edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:25:09 -04:00
Mike Dalessio 0799ad050b Collection workflow edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:24:49 -04:00
Mike Dalessio 263bc486ed Collection entropy config edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:24:41 -04:00
Jason Zimdars 462878630e Use automatic sizing where supported 2025-07-02 16:42:27 -05:00
Mike Dalessio 36727ba5ea Introduce a separate controller for collection entropy config
which opens the door to rendering turbo frames in the responses to
collection edits.
2025-07-02 17:41:29 -04:00
Andy Smith a2f9339cdb Remove unused --outline vars 2025-07-02 16:40:59 -05:00
Andy Smith 7c30fd6674 Focus ring for collection select 2025-07-02 16:18:12 -05:00
Andy Smith a07c827cdf Clarify comment 2025-07-02 16:15:16 -05:00
Andy Smith 4bc1b36d3d Clean up --hover variables 2025-07-02 16:14:34 -05:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 27aaa815c7 Prefer modern syntax 2025-07-02 16:12:37 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00