Commit Graph

4101 Commits

Author SHA1 Message Date
Mike Dalessio d111fb50c3 Default collection permissions to "all access"
ref: https://37s.fizzy.37signals.com/buckets/693169853/bubbles/999008744
2025-04-07 12:48:43 -04:00
David Heinemeier Hansson 23892296da Move readings under bubbles and out of double nesting 2025-04-07 14:06:56 +02:00
David Heinemeier Hansson bcd6c6dd66 Move bubble stagings out from double nesting 2025-04-07 14:00:30 +02:00
David Heinemeier Hansson 28c106fd83 Fix indention 2025-04-07 13:58:41 +02:00
David Heinemeier Hansson 3b32b40264 Move bubble recovery out from double nesting 2025-04-07 13:57:00 +02:00
David Heinemeier Hansson 481be72162 Move bubbles publish out from the double nesting 2025-04-07 13:55:12 +02:00
David Heinemeier Hansson ce0c6146be Move bubble pops out from double nesting 2025-04-07 13:45:51 +02:00
David Heinemeier Hansson c60b86cbaa Move controller to delete bubble image out from double nesting under bucket 2025-04-07 13:43:51 +02:00
Jorge Manrubia 2106fb464a Revert "Scope searches by user"
This reverts commit 47552dd8d7.
2025-04-07 13:42:57 +02:00
Jorge Manrubia 47552dd8d7 Scope searches by user 2025-04-07 13:42:27 +02:00
Jorge Manrubia fea5463642 Merge pull request #372 from basecamp/scope-accesses
Scope data by account
2025-04-07 13:35:44 +02:00
Jorge Manrubia 93b9f08d58 Merge pull request #373 from basecamp/engagement-nesting
Remove nesting under "bucket" for engagements
2025-04-07 13:35:18 +02:00
David Heinemeier Hansson 86a360f6a0 Few more lazy loading avatars! 2025-04-07 13:32:10 +02:00
David Heinemeier Hansson 7e9b851f64 Another lazy loading point 2025-04-07 13:31:14 +02:00
Jorge Manrubia e4f7837ebe Remove double nesting under bubbles for engagement 2025-04-07 13:30:31 +02:00
David Heinemeier Hansson 8e0394a090 Lets just preload all avatars for now
They are small, they cache well, scrolling will be less jittery. Small
cost in bandwidth for that.
2025-04-07 13:29:59 +02:00
David Heinemeier Hansson 84c0ec8a35 No need for an array when there is only one dependency 2025-04-07 13:23:16 +02:00
Jorge Manrubia ca0526f9ac Merge pull request #370 from basecamp/back-fallback
Extract helper with fallback for the "go to back" and use consistently
2025-04-07 13:10:54 +02:00
Jorge Manrubia cb2b2f409a Merge pull request #368 from basecamp/avatar-cache
Remove max_age for your own avatar
2025-04-07 13:10:45 +02:00
Jorge Manrubia 9b4169c7ca Scope data by account
With a single database this problem is not as bad, but it feels
safer to do things right. Also, not everyone in an account has access
to all the bubbles.
2025-04-07 13:09:49 +02:00
Jorge Manrubia 67398926df Prefer aria-label 2025-04-07 12:54:37 +02:00
Jorge Manrubia 8d7d8e76f2 Avoid # since it confuses screen readers 2025-04-07 12:45:53 +02:00
Jorge Manrubia a7aae833d1 Extract helper with fallback for the "go to back" and use consistently 2025-04-07 11:28:03 +02:00
Jorge Manrubia 598d933565 Merge pull request #369 from basecamp/unique-tags
Ignore case when matching tags
2025-04-07 10:47:38 +02:00
Jorge Manrubia a0579f7b6f Inject a span with a class with the value so that we can style it
https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008854
2025-04-07 10:46:24 +02:00
Jorge Manrubia 8e01a277ad Add daysago formatter and extract common helper to reuse with indays formatter 2025-04-07 10:46:22 +02:00
Jorge Manrubia f403ed070c Downcase tag titles 2025-04-07 10:43:23 +02:00
Jorge Manrubia 40df93eed7 Max max age for your own avatar
So that you don't get confused when you don't see it update
after changing it.
2025-04-07 06:59:36 +02:00
Jorge Manrubia 99584a17f4 Ignore case when trying to match tags 2025-04-07 06:01:43 +02:00
Mike Dalessio 2e917b90a2 Fix the DaysAgoFormatter output to say "days ago"
and not "in N days" 😅
2025-04-06 22:08:51 -04:00
David Heinemeier Hansson 565ee0f548 Dont have to spell this out when there are no other formats 2025-04-06 21:09:49 +02:00
David Heinemeier Hansson 26c123c41c Template dependency should be closest to direct use 2025-04-06 21:05:28 +02:00
David Heinemeier Hansson c06802856e Move boosts under bubbles
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
David Heinemeier Hansson d925c64c59 Remove anemic partial 2025-04-06 20:07:21 +02:00
David Heinemeier Hansson 4fd1472fae Move bubble watch out from the needless bucket nesting 2025-04-06 19:22:40 +02:00
David Heinemeier Hansson eb0614c44f Use a more ergonomic API for watching
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson 352ba6e05e No longer need the turbo frame designation as this isnt wrapped in a frame 2025-04-06 19:17:26 +02:00
David Heinemeier Hansson 95cd60b919 Style 2025-04-06 18:49:19 +02:00
David Heinemeier Hansson 78c82584cf Reads nicer now that we are using long form operations 2025-04-06 18:45:58 +02:00
David Heinemeier Hansson 21211cedca These really are anemic too 2025-04-06 18:16:47 +02:00
David Heinemeier Hansson cc0c88d999 Remove anemic finder 2025-04-06 18:15:13 +02:00
David Heinemeier Hansson 084c4d8948 Spacing and indention 2025-04-06 13:50:15 +02:00
David Heinemeier Hansson 7fe87bfce5 This neednt be a turbo frame
Just because we are targeting something with a stream update does not
mean it needs to be a frame. The frame is only necessary when there is
lazy loading or we are creating a closed update loop.
2025-04-06 13:47:27 +02:00
David Heinemeier Hansson 7900c475e9 This is going to churn too much
Depends directly on the Current.account. If we need something like this,
we need a much more narrow key.
2025-04-06 13:32:30 +02:00
David Heinemeier Hansson eb047aec4d Neater 2025-04-06 13:30:20 +02:00
David Heinemeier Hansson b8bcfdee40 This is not just param extraction, we sanitize too 2025-04-06 13:29:43 +02:00
David Heinemeier Hansson 5e78a1dab1 Make it clearer that this takes a title string not a tag object 2025-04-06 13:28:52 +02:00
David Heinemeier Hansson a58fcd3123 Nicer API 2025-04-06 13:26:10 +02:00
David Heinemeier Hansson cdd78b41ee Tag exclusively by title 2025-04-06 13:19:22 +02:00
David Heinemeier Hansson ee22e69e6e Move taggings to bubbles 2025-04-05 22:19:12 +02:00