Commit Graph

5430 Commits

Author SHA1 Message Date
Jose Farias 2dd719e94b Don't summarize boosts if there are none 2024-10-24 17:36:26 -06:00
Jose Farias c57f18c20c Materialize abstract thread
The domain language is clearer if we just persist a thread. Also rename some models so their purpose is clear.
2024-10-24 17:36:14 -06:00
Jose Farias 7132fdd962 Might be ok for some events not to have rollups
e.g. if we add events that don't get rolled up
2024-10-24 16:04:12 -06:00
Jose Farias 3543121d3d thread-controller -> created-by-current-user-controller 2024-10-24 16:00:09 -06:00
Jose Farias ad88f90302 Fine not to denormalize user names in events 2024-10-24 15:50:00 -06:00
Jose Farias e2f608eb71 Remove *_names accessors for bucket views 2024-10-24 15:47:39 -06:00
Jose Farias 08184d0ec8 Give rollups a min height 2024-10-24 15:14:19 -06:00
Jose Farias d1f70ae2f8 Write template dependency comments 2024-10-24 15:14:10 -06:00
Jose Farias 28a024b1da Pull out Threadable::TYPES 2024-10-24 11:36:24 -06:00
Jose Farias 86e69c3989 Reorder events fixtures attributes 2024-10-24 11:33:06 -06:00
Jose Farias 042bc2c10e Use Proc for Threadable after_create 2024-10-24 11:31:06 -06:00
Jose Farias 70ff52f883 Move inverse_of further up 2024-10-24 11:28:59 -06:00
Jose Farias e3db8e8700 Inline thread entry creation 2024-10-24 11:25:50 -06:00
Jose Farias c41da5837c Add back bubble association to events 2024-10-24 11:22:23 -06:00
Jose Farias 5fed37a8c4 Refactor Bubble::Thread#latest_rollup 2024-10-24 10:55:30 -06:00
Jose Farias a49c6dc3f6 Refactor Bubble#toggle_stage 2024-10-24 10:51:23 -06:00
Jose Farias 804be0a971 Create thread entry in a callback 2024-10-24 10:38:59 -06:00
Jose Farias 60f8ae7c4c Remove boost_event_tag helper 2024-10-23 19:22:26 -06:00
Jose Farias ab0492f56a Remove stray newline 2024-10-23 19:15:48 -06:00
Jose Farias e1f03fb8fd comment! -> comment 2024-10-23 19:13:35 -06:00
Jose Farias ca85326638 Simplify Bubble#comment! 2024-10-23 19:07:48 -06:00
Jose Farias a0c1c7d0ed Move rollup param further up 2024-10-23 19:06:55 -06:00
Jose Farias 8233254de3 Make comments cache-safe 2024-10-23 18:58:10 -06:00
Jose Farias 208ace7214 Delegate Current.user to session 2024-10-23 18:49:40 -06:00
Jose Farias cf22fb454a not_popped -> active 2024-10-23 18:32:27 -06:00
Jason Zimdars 3abfb24e1d Stub bookmark buttons 2024-10-23 19:26:21 -05:00
Jose Farias 77e00488af Move rollup further up 2024-10-23 18:09:32 -06:00
Jose Farias 11efca5af9 Bubbles don't have events anymore 2024-10-23 18:08:01 -06:00
Jose Farias f1d65782d3 Fix tests 2024-10-23 17:35:18 -06:00
Jose Farias 973fd0a73d Redirect to bubble after staging 2024-10-23 17:32:34 -06:00
Jose Farias 398baed6a6 Assignments should touch their bubbles 2024-10-23 17:29:49 -06:00
Jose Farias 567dec2197 Simplify threadable<>bubble relationships 2024-10-23 17:29:24 -06:00
Jose Farias c575cb4bc4 Make boosts span temporary 2024-10-23 16:21:33 -06:00
Jason Zimdars 78279cb191 Move delete to filters index 2024-10-23 16:16:04 -05:00
Jason Zimdars 17f744cf0f Move edit to the index 2024-10-23 16:09:47 -05:00
Jose Farias ae497aae85 Clear up dependency destruction chain
Buckets destroy their bubbles, which destroy their thread entries, which destroy their threadables, which is how comments end up destroyed, and then rollups end up deleting their events
2024-10-23 14:51:12 -06:00
Jose Farias 3e5b902e76 Move thread to its own partial 2024-10-23 14:28:21 -06:00
Jose Farias 5221807847 Render threadables 2024-10-23 14:12:28 -06:00
Jose Farias 35a31e3203 Model threadables 2024-10-23 14:10:04 -06:00
Jose Farias 06ea38a9f7 Denormalize event data 2024-10-23 13:38:00 -06:00
Jose Farias 0a5854e02e Merge pull request #121 from basecamp/workflows-spike
Spike workflows
2024-10-22 11:32:44 -06:00
Jose Farias c74dce6002 Remove unnecessary turbo_confirms 2024-10-22 10:50:33 -06:00
Jose Farias 79670c04c3 Remove unnecessary parens 2024-10-22 10:49:08 -06:00
Jose Farias 6a9ffe3103 Remove unnecessary calls to #id 2024-10-22 10:45:32 -06:00
Jeremy Daer 0ea5719431 Ruby 3.3.5 (#122) 2024-10-21 21:42:51 -07:00
Jose Farias d2667ba04a Fix tag test 2024-10-21 21:40:51 -07:00
Jose Farias 876f1d0564 Use params.expect 2024-10-21 16:02:08 -06:00
Jose Farias b182124358 Account for workflow path de-nesting 2024-10-21 15:57:54 -06:00
Jose Farias 34df819e30 Fix tag test 2024-10-21 15:50:15 -06:00
Jason Zimdars 128fc22eb1 Make it look like the filter 2024-10-21 16:39:39 -05:00