Jose Farias
2d422d7bff
Merge branch 'main' into new-filters
...
* main:
Simplify
Another round of design on the stage picker UI
2024-11-11 13:46:25 -06:00
Jose Farias
0baaf5d87f
Wire up filter form sans search
2024-11-11 13:46:15 -06:00
Jose Farias
d455b72906
Hash filter params
2024-11-08 15:17:55 -06:00
Jason Zimdars
171922a9b7
Simplify
2024-11-08 10:33:09 -06:00
Jason Zimdars
110d2a30b7
Another round of design on the stage picker UI
2024-11-07 22:11:08 -06:00
Jose Farias
b1570e34ed
Remove unused files
2024-11-07 17:05:19 -06:00
Jose Farias
3db6e230c9
Update links to use new system
2024-11-07 17:03:52 -06:00
Jose Farias
1383766cd8
Merge branch 'main' into new-filters
...
* main: (24 commits)
Increase filter tests specificity
Add some more tests for bubble filters
Simplify filter destruction
Add derived_params alias
Split out `fields` and `params` for filters
exists? -> any?
Assert params after resource removal
Put includes on the same line
Comment on the query merger controller
Test param sanitization
Sanitize params after initialization
Unnecessary parens
Improve denormalized filters note
idempotent_create -> persist
Pull out `strip_default_params`
Update denormalization comment
Unnecessary newline
No need to set resources in `to_params` anymore
Delegate default_params to class
Add tests
...
2024-11-07 16:55:00 -06:00
Jose Farias
75d2b793a3
Increase filter tests specificity
2024-11-07 16:52:49 -06:00
Jose Farias
6b3d7e7274
Merge pull request #130 from basecamp/unnested-filters
...
Unnest bubble filters
2024-11-07 16:15:41 -06:00
Jose Farias
da37fa56d8
Add some more tests for bubble filters
2024-11-07 16:13:00 -06:00
Jose Farias
5cc4aa0634
Simplify filter destruction
2024-11-07 16:09:12 -06:00
Jose Farias
aca9a69ce1
Add derived_params alias
2024-11-07 12:48:27 -06:00
Jose Farias
77a9b267d8
Split out fields and params for filters
2024-11-07 12:44:26 -06:00
Jose Farias
fb08ff394d
exists? -> any?
2024-11-07 11:35:26 -06:00
Jose Farias
201a543a9b
Assert params after resource removal
2024-11-07 11:34:56 -06:00
Jose Farias
8f17152108
Put includes on the same line
2024-11-07 11:32:44 -06:00
Jose Farias
4c02a46867
Comment on the query merger controller
2024-11-07 11:32:21 -06:00
Jose Farias
ec04ccef4d
Test param sanitization
2024-11-06 18:22:10 -06:00
Jose Farias
f53ee0ddac
Sanitize params after initialization
2024-11-06 18:19:19 -06:00
Jose Farias
e73f44cde9
Unnecessary parens
2024-11-06 18:16:18 -06:00
Jose Farias
f7495ac1fa
Improve denormalized filters note
2024-11-06 18:13:05 -06:00
Jose Farias
9efe94a277
idempotent_create -> persist
2024-11-06 18:09:55 -06:00
Jose Farias
32618debf6
Pull out strip_default_params
2024-11-06 18:05:15 -06:00
Jose Farias
49f3894bcb
Update denormalization comment
2024-11-06 18:01:40 -06:00
Jose Farias
be0973705c
Unnecessary newline
2024-11-06 17:56:46 -06:00
Jose Farias
a853f75ef9
No need to set resources in to_params anymore
...
They're denormalized now
2024-11-06 17:54:43 -06:00
Jose Farias
e6cf8d3571
Delegate default_params to class
2024-11-06 17:52:31 -06:00
Jose Farias
12ce07639d
Add tests
2024-11-06 17:49:14 -06:00
Jason Zimdars
8c29a59ac2
Stub design for new filtering UI
2024-11-06 14:23:48 -06:00
Jose Farias
3d9d169477
Many-to-many relationship for filters and filterables
2024-11-05 21:21:46 -06:00
Jose Farias
ca6d018106
Attribute filter fixture to david
2024-11-05 15:45:13 -06:00
Jose Farias
f3b456c551
Fix tests
2024-11-05 14:14:33 -06:00
Jose Farias
f2706d0f74
Unnest bubble filters
2024-11-05 13:04:05 -06:00
Jason Zimdars
26af27ba26
Needs to be scoped to index view
2024-11-01 16:19:21 -05:00
Jason Zimdars
167c1d0275
Consistent perma rendering
2024-11-01 15:56:23 -05:00
Jason Zimdars
df5ed70ea9
Include list view
2024-11-01 10:03:14 -05:00
Jason Zimdars
c74e2ecd1d
Improve bubble animation effect
2024-11-01 09:32:12 -05:00
Jason Zimdars
fa808e8970
A11y
2024-10-31 14:26:17 -05:00
Jason Zimdars
deba15f2f0
Needs these for PWA
2024-10-31 14:25:47 -05:00
Jason Zimdars
d3acbd2a55
Render bubbles without inline SVG, try a more fluid animation
2024-10-30 17:44:15 -05:00
Jason Zimdars
132ae12cdf
Start improving Workflows UI
2024-10-28 17:43:01 -05:00
Jason Zimdars
5740a4be23
Tighten up users lists
2024-10-28 17:20:49 -05:00
Jason Zimdars
49f1520978
Undo this change from the Montreal presentation
2024-10-28 17:18:39 -05:00
Jose Farias
33afd180a4
Make event summaries not null
...
We can do this now that the data has been migrated
2024-10-28 12:33:09 -06:00
Jose Farias
ed176def10
Merge pull request #124 from basecamp/threadables
...
Build threads from a single table
2024-10-28 12:20:35 -06:00
Jose Farias
017eff6b1e
Remove extra newline
2024-10-28 11:23:03 -06:00
Jose Farias
2f7baaff29
create -> create!
2024-10-28 10:47:49 -06:00
Jose Farias
cf9b07711a
Document left_joins_messageable smell
2024-10-28 10:27:50 -06:00
Jose Farias
5cdf83163c
Document with_status name smell
2024-10-28 10:25:56 -06:00