 Jason Zimdars
|
ee8559343a
|
Tighten engagement switch design, only display it for published cards
|
2025-04-11 11:50:09 -05:00 |
|
|
David Heinemeier Hansson
|
09dd073cf7
|
Record lookup works here
|
2025-04-11 18:47:11 +02:00 |
|
|
David Heinemeier Hansson
|
51341c36d1
|
New partial isnt cached
|
2025-04-11 18:45:44 +02:00 |
|
|
David Heinemeier Hansson
|
c8fe83e8f3
|
Indention
|
2025-04-11 18:43:52 +02:00 |
|
|
David Heinemeier Hansson
|
6effc1568f
|
No need for a separate body partial
|
2025-04-11 18:41:26 +02:00 |
|
|
David Heinemeier Hansson
|
6f1c802292
|
Content being required via UI and db constraint is enough
We are not using/displaying model validations anywhere
|
2025-04-11 18:28:23 +02:00 |
|
|
David Heinemeier Hansson
|
9ecb85013b
|
Spacing
|
2025-04-11 18:25:49 +02:00 |
|
|
David Heinemeier Hansson
|
442fe6087c
|
Use form object so we dont have to manually set the text_field name
|
2025-04-11 18:25:24 +02:00 |
|
|
David Heinemeier Hansson
|
aefae634c3
|
Anemic params method
Wont ever get reused here since there is no update
|
2025-04-11 18:21:44 +02:00 |
|
|
David Heinemeier Hansson
|
8d36f13fab
|
No longer needing that extra local
|
2025-04-11 18:20:28 +02:00 |
|
|
David Heinemeier Hansson
|
06a636bd8d
|
Did need to separate them out for the broadcast
|
2025-04-11 18:19:33 +02:00 |
|
|
David Heinemeier Hansson
|
5fa8007397
|
Loaded directly in the partial
|
2025-04-11 18:19:10 +02:00 |
|
|
David Heinemeier Hansson
|
f0aa48b75d
|
Indention
|
2025-04-11 18:13:29 +02:00 |
|
|
David Heinemeier Hansson
|
fadf167630
|
Avoid needing to pass an extra variable to the reactions partial
Thanks to inverse_of, there's no extra query getting the comment from
the reaction.
|
2025-04-11 18:12:52 +02:00 |
|
|
Andy Smith
|
4a8398e318
|
Remove unused partials
|
2025-04-11 11:11:31 -05:00 |
|
|
David Heinemeier Hansson
|
227d5a8757
|
It is both reacting and reactions
So stick with the simpler dom id scope
|
2025-04-11 18:10:26 +02:00 |
|
|
Andy Smith
|
c9b1d6d868
|
Style pinned cards
|
2025-04-11 11:09:04 -05:00 |
|
|
David Heinemeier Hansson
|
73f1989861
|
Fix indention
|
2025-04-11 18:05:50 +02:00 |
|
|
David Heinemeier Hansson
|
3b711161d7
|
No need for a manual dom_id
turbo_frame_tag can do this directly
|
2025-04-11 18:04:21 +02:00 |
|
|
David Heinemeier Hansson
|
1145260890
|
No idea why this was here
|
2025-04-11 18:01:21 +02:00 |
|
|
David Heinemeier Hansson
|
5aa2b7da84
|
No need to cache individual reactions
Both because the reactions partial actually depends on multiple
variables but also because its just not worth it when we are caching the
comment.
|
2025-04-11 17:58:48 +02:00 |
|
|
David Heinemeier Hansson
|
7861b7c087
|
Just open one turbo stream per card
Per comment is excessive and needless
|
2025-04-11 17:58:11 +02:00 |
|
|
David Heinemeier Hansson
|
263b3336db
|
Add missing CR
|
2025-04-11 17:50:53 +02:00 |
|
|
David Heinemeier Hansson
|
0954cfe008
|
Add CR
|
2025-04-11 17:48:01 +02:00 |
|
|
David Heinemeier Hansson
|
79700162fc
|
Use correct stream name
comment, :comments makes no sense for a stream for the reactions
|
2025-04-11 17:47:35 +02:00 |
|
|
David Heinemeier Hansson
|
eec76d0d4f
|
Use modern params#expect
|
2025-04-11 17:43:31 +02:00 |
|
|
David Heinemeier Hansson
|
f9bb779b61
|
Use local vars so ivar dependency is only from before actions
|
2025-04-11 17:42:30 +02:00 |
|
|
David Heinemeier Hansson
|
3ecf150636
|
Use proper access control
Otherwise you could react to any comment on the entire account. And then
you might as well just do Comment.find.
|
2025-04-11 17:41:28 +02:00 |
|
|
David Heinemeier Hansson
|
dc4e50fba5
|
Move messages partial under cards
|
2025-04-11 17:34:49 +02:00 |
|
|
David Heinemeier Hansson
|
5084bbf3b7
|
Use modern params#expect syntax
|
2025-04-11 17:01:19 +02:00 |
|
|
David Heinemeier Hansson
|
8a4a087a00
|
Fine to let destroying something destroyed be a no-op
Would be an edge-casey race condition, but its possible
|
2025-04-11 17:00:08 +02:00 |
|
|
David Heinemeier Hansson
|
256d536009
|
Always use _path unless we are changing domains
|
2025-04-11 16:58:56 +02:00 |
|
|
David Heinemeier Hansson
|
16c1583133
|
Usually the order comes last
|
2025-04-11 16:58:47 +02:00 |
|
|
David Heinemeier Hansson
|
5ecf0ce3f6
|
Stick with one term
|
2025-04-11 16:57:03 +02:00 |
|
|
David Heinemeier Hansson
|
a8aa2c4f80
|
Clean up the controller
|
2025-04-11 16:49:55 +02:00 |
|
|
David Heinemeier Hansson
|
f2811803d3
|
Needed to come first
|
2025-04-11 16:32:06 +02:00 |
|
|
David Heinemeier Hansson
|
adabfba636
|
In order of appearance
|
2025-04-11 16:31:16 +02:00 |
|
|
David Heinemeier Hansson
|
0084dde686
|
Merge pull request #397 from basecamp/move-comments-under-cards
Move comments under cards
|
2025-04-11 16:26:43 +02:00 |
|
|
David Heinemeier Hansson
|
cbdb9aa113
|
Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones
|
2025-04-11 16:24:38 +02:00 |
|
|
David Heinemeier Hansson
|
f4ce57e308
|
Move comments under cards
|
2025-04-11 16:21:44 +02:00 |
|
|
David Heinemeier Hansson
|
64b529ce94
|
Fix indention
|
2025-04-11 16:12:18 +02:00 |
|
|
Jorge Manrubia
|
67917ff4d1
|
Merge pull request #396 from basecamp/fix-turbo-morph-issue
Refresh timers when morphing happens
|
2025-04-11 13:26:38 +02:00 |
|
|
Jorge Manrubia
|
ba6eab509c
|
Refresh timers when morphing happens
|
2025-04-11 13:26:01 +02:00 |
|
|
Jorge Manrubia
|
4e91d8a666
|
Merge pull request #395 from basecamp/golden-doing
Only consider golden those cards in "doing"
|
2025-04-11 12:04:00 +02:00 |
|
|
Jorge Manrubia
|
825bbf808e
|
Extract helper for card articles, use classes to determine when to show golden status
|
2025-04-11 12:01:52 +02:00 |
|
|
Jorge Manrubia
|
aef75feead
|
Only consider golden those cards in "doing"
|
2025-04-11 11:49:52 +02:00 |
|
|
Jorge Manrubia
|
1275abd99e
|
Fix recently completed order for good!
|
2025-04-11 11:37:02 +02:00 |
|
|
Jorge Manrubia
|
66b5732264
|
Place recently closed cards first
|
2025-04-11 11:27:38 +02:00 |
|
|
Jorge Manrubia
|
bf038c7a74
|
Merge pull request #392 from basecamp/gold-cards
Gold cards
|
2025-04-11 10:49:45 +02:00 |
|
|
Jorge Manrubia
|
17aa9b97e9
|
Monkey patch a prepend_order method
|
2025-04-11 10:28:12 +02:00 |
|