e379721c2f
Merge branch 'main' into mobile-app/prepare-webviews
...
* main: (107 commits)
Document the new sign in method
Replace handle_ naming
Use same constant for fake magic links
Replace FakeMagicLink with a temporary object
Tidy up session_token
Clean up interfaces
Split tests by controller or responsibility
Simplify auth logic
Fix due to unit test when creating with invalid emails
Restore sessions_controller test on creating invalid email address
Move magic link api tests to their own files
Rename test to clarify what they're about
Cleanup session creation
Update to always return a pending auth token for JSON responses.
Update API test for cross code
Change test expectation on single tenant mode account creation
Add unit tests for the new endpoints
Pass a server token when creating a magic link via API
Simplify code a bit
Simplify session create logic for both html and json
...
2025-12-19 13:52:04 -05:00
3a41ac3e23
Merge pull request #1941 from basecamp/mobile/native-log-in
...
Mobile: Native log in
2025-12-19 19:26:58 +01:00
0cb4822ae0
Document the new sign in method
2025-12-19 19:21:58 +01:00
ca388c2b84
Replace handle_ naming
2025-12-19 19:21:58 +01:00
df1dfde2b3
Use same constant for fake magic links
2025-12-19 19:21:58 +01:00
3af8bdbe37
Replace FakeMagicLink with a temporary object
2025-12-19 19:21:58 +01:00
52d57c4681
Tidy up session_token
2025-12-19 19:21:57 +01:00
e0270c6c49
Clean up interfaces
...
I talked to the mobile team, and to keep things simple we agreed to send
the token via a cookie.
2025-12-19 19:21:57 +01:00
23fc7b594f
Split tests by controller or responsibility
2025-12-19 19:21:57 +01:00
1a1f4a077b
Simplify auth logic
2025-12-19 19:21:57 +01:00
cddddcf83a
Fix due to unit test when creating with invalid emails
2025-12-19 19:21:57 +01:00
fb487f598c
Restore sessions_controller test on creating invalid email address
2025-12-19 19:21:57 +01:00
be447f90ba
Move magic link api tests to their own files
2025-12-19 19:21:57 +01:00
6be20e215b
Rename test to clarify what they're about
2025-12-19 19:21:57 +01:00
b3c8d02709
Cleanup session creation
2025-12-19 19:21:57 +01:00
6e8d6a3df0
Update to always return a pending auth token for JSON responses.
2025-12-19 19:21:57 +01:00
fbf829b346
Update API test for cross code
2025-12-19 19:21:57 +01:00
9009e0fb49
Change test expectation on single tenant mode account creation
2025-12-19 19:21:57 +01:00
a2333623b6
Add unit tests for the new endpoints
2025-12-19 19:21:57 +01:00
877f82c0cc
Pass a server token when creating a magic link via API
2025-12-19 19:21:57 +01:00
a75a939289
Simplify code a bit
2025-12-19 19:21:57 +01:00
360e14352f
Simplify session create logic for both html and json
2025-12-19 19:21:57 +01:00
e5bdb3b071
Add back missing development magic link prompt
2025-12-19 19:21:57 +01:00
c0a0786539
Return the session cookie
...
We had a call about this. In short, we could reuse access tokens but then the user would see access tokens for every mobile device they have without any indication as to what is going on. So, since this really is just logging in instead of an integration which seems to be the primary purpose of access tokens, we can just use our regular session cookie for authentication.
2025-12-19 19:21:57 +01:00
58a92f0bb7
Add tests for sign in via API
2025-12-19 19:21:57 +01:00
54ceb4df7c
Remove email address and users from magic link response
...
The identity endpoint can be used to fetch that information
2025-12-19 19:21:57 +01:00
b92982b244
Cleanup & simplify sign in
2025-12-19 19:21:57 +01:00
093240c6f7
Return email and users too
2025-12-19 19:21:57 +01:00
ab0f7a3ea5
Dev: Set magic link as header when JSON request in development
2025-12-19 19:21:57 +01:00
7644bb7411
Allow JSON requests submitting a magic link code
2025-12-19 19:21:57 +01:00
c8eb592746
Allow JSON requests to send a magic link
2025-12-19 19:21:57 +01:00
f2a41d6552
Merge pull request #2210 from basecamp/bump-aws-sdk-s3
...
Update aws-sdk-s3
2025-12-19 19:21:22 +01:00
090582cd98
Update SAAS AWS dependencies
2025-12-19 19:16:39 +01:00
6be2f94581
Update aws-sdk-s3
...
Fixes a security warning raised by gem audit
2025-12-19 19:09:40 +01:00
031d98c096
Change tap highlight
2025-12-19 16:40:30 +01:00
f2ac4e67f0
Remove underline on search results
2025-12-19 16:14:21 +01:00
7203a7ca24
Make sticky headers on activity feed full width
2025-12-19 16:07:17 +01:00
fa21bc9b61
Merge pull request #2169 from basecamp/flavorjones/better-hex-uuid
...
Extract `hex_to_base36` and `base36_to_hex` methods in `Uuid` type
2025-12-19 10:06:36 -05:00
50691ae385
Merge pull request #2205 from basecamp/base-url-env
...
Add `BASE_URL` environment variable
2025-12-19 14:58:08 +00:00
573ffe0ee4
Add titles to pins and search permas
2025-12-19 15:44:36 +01:00
711f69d3cc
Merge pull request #2209 from basecamp/flavorjones/require-libvips
...
Raise a clear exception if libvips is not installed
2025-12-19 09:31:30 -05:00
b04dee31d0
Raise a clear exception if libvips is not installed
2025-12-19 09:22:55 -05:00
766cde4775
Tidy up test
2025-12-19 15:15:00 +01:00
c52a1593d0
Merge pull request #2208 from basecamp/flavorjones/fix-prod-logging
...
Move the :fatal log setting into the SaaS config
2025-12-19 09:12:14 -05:00
28250b340c
Move the :fatal log setting into the SaaS config
...
This should only be set if the app is using the
rails-structured-logging gem, which means it should only be set in the
SAAS config. I think this is just something we missed in one of the
decoupling exercises we did.
2025-12-19 09:09:40 -05:00
407f2a3a6a
Add BASE_URL environment variable
...
When running a Docker deployment, we need a way to set the app's base
URL. Otherwise links in emails, or generated in jobs etc., can not be
correctly constructed.
2025-12-19 12:21:37 +00:00
f9409c15a0
Merge pull request #2202 from gchp/doc-fix
...
Fix fizzy-saas link to point to the vendored gem instead of the archived repo
2025-12-19 12:17:40 +01:00
eb1d112013
Merge pull request #2203 from basecamp/remove-unused-param
...
Remove unused `tag_ids` parameter from `CardsController#update`
2025-12-19 12:16:32 +01:00
b49aa9cbf1
Don't load the navigable list controller on mobile
2025-12-19 12:16:04 +01:00
b5ca348eb9
Merge pull request #2195 from Heliem/patch-1
...
Update API documentation for card retrieval
2025-12-19 12:15:25 +01:00
Jay Ohms