Commit Graph

3024 Commits

Author SHA1 Message Date
Kevin McConnell e998783155 Use VFS-based Beamer 2025-06-05 11:59:30 +01:00
Mike Dalessio e67d59e341 Introduce a staging environment
ref: https://3.basecamp.com/2914079/buckets/21350690/card_tables/cards/8708868711
2025-06-04 11:06:09 -04:00
Jason Zimdars 7355b09382 Expose button so you can delete drafts 2025-06-03 17:48:08 -05:00
Jason Zimdars 029daece9b Save button should match card color 2025-06-03 16:46:09 -05:00
Jason Zimdars 37dc14c0c6 x interferes with string entry, try SHIFT+ENTER to toggle checkboxes 2025-06-03 16:35:55 -05:00
Jason Zimdars b942794d15 Remove unnecessary param and update condition
This should have been removed in #581 when this was moved to a separate controller
2025-06-03 16:18:51 -05:00
Jason Zimdars ff403021cc Wire-up keyboard navigation
- Introduces a distinct controller and individual forms for each option so they behave like other pop-ups
- Adds `filter` and `navigable-list` behaviors
2025-06-03 11:05:39 -05:00
Jason Zimdars acfc7da551 Merge pull request #548 from basecamp/change-collection
Change collection
2025-06-03 08:56:00 -05:00
Jason Zimdars 98c1f32e1c Spell it all out for now 2025-06-03 08:54:37 -05:00
Jason Zimdars 6045b7a736 Correct hotkey 2025-06-03 08:49:03 -05:00
Jason Zimdars 9ebb1ffeb1 Use x to toggle filter checkboxes 2025-06-03 07:55:19 -05:00
Jorge Manrubia 651ee5f6fe Use CTRL-ENTER or CMD-ENTER to toggle, since space is a legit search character 2025-06-03 06:32:38 +02:00
Jorge Manrubia b9c1e8aa72 Merge pull request #567 from basecamp/filter-revamp
Revamp filter menu
2025-06-03 06:14:22 +02:00
Jorge Manrubia 199a78ee08 Merge branch 'main' into filter-revamp
* main:
  `event.assignees` collection doesn't include `event.creator` when self-assigning
  Consistent verb forms
  Autolinking shouldn't include final punctuation.
  dep: update kamal to edge
  No need to delegate auto_closing? anymore
  Extract common method to query when entropy is cleaned
  Invalidate card caches when editing workflows

# Conflicts:
#	app/javascript/controllers/navigable_list_controller.js
2025-06-03 06:12:34 +02:00
Jorge Manrubia 55c1e53624 Skip if no checkbox 2025-06-03 06:06:51 +02:00
Jorge Manrubia e33dd22fad Toggle selected item with space 2025-06-03 06:05:15 +02:00
Jason Zimdars 8072a74562 event.assignees collection doesn't include event.creator when self-assigning 2025-06-02 22:37:58 -05:00
Jorge Manrubia e2939e846c Consistent verb forms 2025-06-03 02:53:03 +02:00
Jason Zimdars 2c75c9e746 Let's try it without the explicit submit
Later on we could consider adding an explicit button that only shows up when the filter has no matches and there is something typed in the filter input
2025-06-02 16:37:58 -05:00
Jason Zimdars f796b62aa8 Update markup to match assignments list
Drifted due to neglect (I guess)
2025-06-02 16:28:47 -05:00
Jason Zimdars de8fce5eee Prefer ul for a11y 2025-06-02 16:12:34 -05:00
Jason Zimdars 63808ff567 Just say "Filter…", since it can match other things 2025-06-02 16:09:18 -05:00
Jason Zimdars 84b52f8fae Ensure these can be matched by the filter, too 2025-06-02 15:56:46 -05:00
Jason Zimdars dc5c8d17a4 Handle these special case options a different way 2025-06-02 15:49:44 -05:00
Mike Dalessio 76a3564c28 Merge pull request #571 from basecamp/flavorjones/autolink-punctuation
Autolinking shouldn't include final punctuation.
2025-06-02 16:47:32 -04:00
Jason Zimdars 0be387bb41 Add distinct navigation selected styles 2025-06-02 15:18:27 -05:00
Mike Dalessio 1302fe9da2 Autolinking shouldn't include final punctuation. 2025-06-02 14:16:02 -04:00
Mike Dalessio 01f286b2a6 Merge pull request #570 from basecamp/flavorjones/kamal-host
dep: update kamal to edge
2025-06-02 13:35:53 -04:00
Mike Dalessio 1f694cf7f1 dep: update kamal to edge
so we can use KAMAL_HOST
2025-06-02 13:25:28 -04:00
Mike Dalessio ba2340ff57 Merge pull request #569 from basecamp/flavorjones/remove-auto-close-delegation
No need to delegate `Card#auto_closing?` anymore
2025-06-02 12:43:55 -04:00
Mike Dalessio 3a5ce1ca4c No need to delegate auto_closing? anymore
Related to #568
2025-06-02 12:41:55 -04:00
Jorge Manrubia 61fbad218b Make tag filters selectable/navigable too 2025-06-02 18:39:44 +02:00
Jorge Manrubia c0cd5e1967 Merge pull request #566 from basecamp/fix-caching
Invalidate card caches when editing workflows
2025-06-02 18:09:52 +02:00
Jorge Manrubia 334ea7f76b Merge pull request #568 from basecamp/fix-entropy-nil-error
Fix entropy nil error
2025-06-02 18:05:19 +02:00
Jorge Manrubia 08c5abfbdb Extract common method to query when entropy is cleaned
We were always quering auto_close_at
https://37s.fizzy.37signals.com/collections/2/cards/743
2025-06-02 18:04:14 +02:00
Jorge Manrubia 5c31ef1aa6 Make dialog close on ESC 2025-06-02 17:17:13 +02:00
Jason Zimdars 3ab0cb7422 Down arrow glyph 2025-06-02 10:02:27 -05:00
Jason Zimdars 902a99ca56 Merge branch 'main' into change-collection
* main: (25 commits)
  Add controller to retarget links
  Use more complete regexp
  dep: bundle update
  refactor: Extract a Card::Entropy concern
  Autolink emails and URLs at rendering time
  Remove the "mirror" storage service
  Update production storage to write to the Pure blob store
  Clean up the purestorage config, and add explanatory comments.
  Drop the action_text_markdowns table
  Mount mission control under `/admin/jobs`
  dep: add mission_control-jobs
  Flip the storage mirror to write to Pure as the primary
  Production mirrors Active Storage to `:purestorage`
  Make sure Sentry is configured for the beta env.
  Update lexical
  update lexical
  update lexical
  Create a distinct "beta" environment
  Revert "Patch for cards missing description"
  Add a kamal "ssh" alias
  ...
2025-06-02 09:34:01 -05:00
Jorge Manrubia b10ab3063b Add class I lost by mistake 2025-06-02 15:32:39 +02:00
Jorge Manrubia ca40e36a79 Make dialog to assign users searchable and navigable 2025-06-02 15:30:55 +02:00
Jorge Manrubia 10ee5611c9 Make collection's filter searchable too 2025-06-02 15:22:34 +02:00
Jorge Manrubia 231239f8d6 Reduce debounce period 2025-06-02 15:10:36 +02:00
Jorge Manrubia 29c1f3133d Remove unused classes from controller 2025-06-02 15:08:34 +02:00
Jorge Manrubia edf7153ced Remove trace 2025-06-02 14:59:04 +02:00
Jorge Manrubia 37fd2b248d Revamp filters menu (WIP)
- Make them navigable by keyboard (UP, DOWN, ENTER to activate option).
- Filter based on the actual text in the element, use containment condition instead of CSS selector on value prefix.
- Make all the elements in the filter searchable and reachable by keyboard.
2025-06-02 14:51:03 +02:00
Jorge Manrubia a3866348fd Aria selected is a better fit here 2025-06-02 13:37:29 +02:00
Jorge Manrubia 51dcf8b25f Invalidate card caches when editing workflows
https://37s.fizzy.37signals.com/collections/2/cards/607
2025-06-02 13:08:54 +02:00
Jorge Manrubia db9ee1b3b2 Merge pull request #564 from basecamp/auto-link-render
Autolink emails and URLs at rendering time
2025-06-02 12:12:39 +02:00
Jorge Manrubia d7c06702e3 Add controller to retarget links
So that internal links can skip turbo frames, and external links
open in new pages
2025-06-02 12:04:43 +02:00
Jorge Manrubia e973df97e2 Use more complete regexp
https://github.com/basecamp/fizzy/pull/564/files#r2119855866
2025-06-02 11:43:07 +02:00