ea66845e71
There is always an action
2025-04-23 15:27:58 +02:00
e8e95bd511
Use it
2025-04-23 15:27:25 +02:00
4bef466df2
1-line
2025-04-23 15:22:41 +02:00
ad58de9e76
Remove access checks when watching
...
https://github.com/basecamp/fizzy/pull/425#discussion_r2056039581
2025-04-23 15:22:18 +02:00
a9df2d48d1
Remove delegate
2025-04-23 15:17:51 +02:00
6ff9f7a154
Fix identation
2025-04-23 15:07:02 +02:00
469fb9f049
Simplify the logic to determine action text changes
2025-04-23 15:02:31 +02:00
e446080367
Don't create duplicated mentions
...
E.g: when editing a comment or description with a mention
2025-04-23 14:45:56 +02:00
f43629f849
Format
2025-04-23 14:39:10 +02:00
dc5f64ab30
Remove redundant default queue declaration
2025-04-23 14:37:09 +02:00
ab73417e73
Leverage existing resolve route for comments
2025-04-23 14:34:59 +02:00
07d3447e7e
Resolve notifications URLs
2025-04-23 14:34:59 +02:00
2eae58725a
Remove notifications' resource relationship
...
Is confusing since "source" already captures the origin of the notifications. It's
needed to interpret things at rendering time, so we can query things as needed there.
2025-04-23 13:52:47 +02:00
696732a90a
Rename mentions' container => source
2025-04-23 13:41:34 +02:00
7c0aff0680
Don't indent case
2025-04-23 13:36:39 +02:00
043230394e
Tidy up event helper code
...
Also, revert to using a helper method to determine the event action, since this is purely a view concern. Keep method at the event model to identify initial assignments.
2025-04-23 13:35:09 +02:00
2e3ffcfb9d
Remove identation
2025-04-23 13:35:08 +02:00
755c9b45c7
Rename and fix problem where after_touch was overriding the saved content
2025-04-23 12:38:33 +02:00
edcc9e3279
Add mentionees as watchers
2025-04-23 12:38:06 +02:00
8ebb3f2fa9
We need to remember on after_touch so that the mechanism triggers when touch-cascading records automatically via associations
2025-04-23 11:38:34 +02:00
8b6cfccded
Rename to clarify usage
2025-04-23 11:20:33 +02:00
ab54cafd84
Inline event notifiers
2025-04-23 11:06:43 +02:00
b510ca0318
Don't choke for nil values
2025-04-23 10:56:00 +02:00
68e2e96076
Fix indentation
2025-04-23 10:44:42 +02:00
af8701567a
Extract method
2025-04-23 10:35:18 +02:00
c3cd873588
Rename collect => create
2025-04-23 10:30:30 +02:00
cdadc0373a
Don't trigger unless the mentionable content changes
...
This is also needed to prevent incorrect triggering on cascade touches!
2025-04-22 18:10:27 +02:00
a567e662e2
Fix: wrong delegation
2025-04-22 17:23:47 +02:00
9b4fec936e
Move mentions to comments
...
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
81961a3523
Fix unclosed tag
2025-04-22 15:30:03 +02:00
c75d4cb329
Fix broken permalinks
2025-04-22 15:26:56 +02:00
3bf73a0b71
Rename to match actual action
2025-04-22 14:22:23 +02:00
beac61699c
Not needed
2025-04-22 14:21:26 +02:00
d5f0359338
Extract mentionable content using reflection to remove duplicated logic and the need for additional concerns
2025-04-22 14:19:45 +02:00
9db675e589
Format
2025-04-22 14:15:40 +02:00
22df208f9a
Render proper content for mentions, don't send mentions to yourself
2025-04-22 14:11:21 +02:00
8aa99e34b4
Persist notification's creator
...
Instead of delegating. With a polymorphic relationship, relying on a certain
attribute implies doing things like aliasing "mentioner" to "creator" or similar.
2025-04-22 13:48:43 +02:00
4f06473405
Notifications for mentions showing up
2025-04-22 12:02:48 +02:00
aa3acfeaa8
Add plain text mentions
2025-04-22 11:26:56 +02:00
5b10b3a16e
Merge pull request #421 from basecamp/flavorjones-dep-rails-e9ee790d
...
dep: update rails to `e9ee790d`
2025-04-21 13:05:52 -04:00
01d741b3f4
dep: update rails
2025-04-21 13:03:49 -04:00
6d4691f32b
Merge pull request #420 from basecamp/descriptions-fix
...
Add card's description field
2025-04-21 17:28:18 +02:00
4f0cf0f5cb
Fix autosave working with the new description field
2025-04-21 17:05:35 +02:00
2c3ec3e806
Fix: Create new cards wasn't working
2025-04-21 17:00:25 +02:00
1680095266
Remove invalid "
2025-04-21 16:45:35 +02:00
b0aae3ad9e
Reapply "Add a description field for cards"
...
This reverts commit a4cc143b09
2025-04-21 16:45:24 +02:00
6392180493
Merge pull request #419 from basecamp/revert-408-add-card-description
...
Revert "Add a description field for cards"
2025-04-21 16:42:09 +02:00
a4cc143b09
Revert "Add a description field for cards"
2025-04-21 16:41:33 +02:00
4d1a1382e1
Fix seeds for new descriptions
2025-04-21 16:21:20 +02:00
9ecd7f7a60
Merge pull request #408 from basecamp/add-card-description
...
Add a description field for cards
2025-04-21 16:06:47 +02:00
Jorge Manrubia