Commit Graph

4058 Commits

Author SHA1 Message Date
Jason Zimdars f15fac94d9 Make output scrollable 2025-07-24 17:09:56 -05:00
Jorge Manrubia ef7403c600 Merge pull request #803 from basecamp/ai-improvements
Semantic searches + Get Insight about cards with gpt-4o
2025-07-24 17:48:51 +02:00
Jorge Manrubia c128b07203 Add test 2025-07-24 17:47:42 +02:00
Jorge Manrubia 18597aabad Make sure we sort closed cards by recency by default
So that the filter used for the insight context fetches the most recent cards when using indexed_by closed
2025-07-24 17:46:40 +02:00
Jorge Manrubia 95e065a0c4 Reduce the injected load a bit 2025-07-24 17:33:40 +02:00
Jorge Manrubia 523f3f0acb Set some hard limits on the prompt lenghts we inject 2025-07-24 17:32:50 +02:00
Jorge Manrubia 0429dc28f3 Fix for injecting the current context
This is a workaround to make the prototype work. We create a context on the fly to execute AI-derived
commands. When those require listing cards, we ended up losing the notion of "being on a perma screen".
2025-07-24 17:27:32 +02:00
Jorge Manrubia c2120fe83d Remove results when pressing up 2025-07-24 16:58:36 +02:00
Jorge Manrubia b7200509f4 Bundle after merge issues 2025-07-24 16:49:22 +02:00
Jorge Manrubia 7de45cc061 Remove vcr_record! and fix VCR fixtures due to different timestamps 2025-07-24 16:48:06 +02:00
Jorge Manrubia b2ee79bbd0 Format 2025-07-24 16:48:06 +02:00
Jorge Manrubia e61ee25b47 Suite passing 2025-07-24 16:48:05 +02:00
Jorge Manrubia 4574c0d85c Include stage information about the card 2025-07-24 16:48:05 +02:00
Jorge Manrubia ba97ec05d6 Remove transaction as the AI commands can hold the transaction for too long 2025-07-24 16:48:05 +02:00
Jorge Manrubia 5ad2d09eae Move the hack to fetch completed cards to the insight command logic
We need to rework this as part of the filters revamp. "indexed_by" being
a mix of filters keeps biting us.
2025-07-24 16:48:05 +02:00
Jorge Manrubia fc26329daf Restore default to open cards. Use special "all" value instead.
The change could have side effects (e.g: when running commands).

This also include further changes.
2025-07-24 16:48:04 +02:00
Jorge Manrubia 018c746d2a Make the prompt smarter about the current context to make better calls 2025-07-24 16:48:03 +02:00
Jorge Manrubia 8bb7783215 Extract "prompt generation" logic to models for events, comments and cards
So that we can reuse in other scenarios
2025-07-24 16:48:03 +02:00
Jorge Manrubia dd28e3d1e9 Replace special value with just not asuming that filters are about open cards by default 2025-07-24 16:48:03 +02:00
Jorge Manrubia 9d0887f6bd Use a workaround with a special indexed_by filter to "query all" 2025-07-24 16:48:02 +02:00
Jorge Manrubia 83d743fe2a Make the translator use the /insight command 2025-07-24 16:48:02 +02:00
Jorge Manrubia 7a8bf4895c More prompt fixes 2025-07-24 16:48:01 +02:00
Jorge Manrubia 4d3e7bf0af Fix: llm model 2025-07-24 16:48:01 +02:00
Jorge Manrubia 1c6adf54a8 Restore semantic searches 2025-07-24 16:47:57 +02:00
Jorge Manrubia df9c1e0674 Make sure we pass expressions as a single term
Multiple terms refine the search on each term and works way
worse with the semantic approach
2025-07-24 16:47:54 +02:00
Jorge Manrubia 6080c2aa9b Refine when to filter by cards, make it more relaxes with the expressions it accepts 2025-07-24 16:47:53 +02:00
Jason Zimdars 8febb2b3a1 Merge pull request #804 from basecamp/fix-app-icons
App icons should have backgrounds
2025-07-24 09:31:09 -05:00
Jason Zimdars 50d5955be3 App icons should have backgrounds
Also: create a proper, padded maskable version for Android
2025-07-24 09:27:23 -05:00
Stanko Krtalić 9d9244a1c9 Merge pull request #802 from basecamp/fix-typo-in-abandoned-card-recovery-message
Fix typo in the card recovery message
2025-07-24 15:38:02 +02:00
Stanko K.R. 66a8d35060 Fix typo in the card recovery message 2025-07-24 15:26:26 +02:00
Jason Zimdars 3a53d8359c This didn't update the page because it never hit the format.html render 2025-07-23 18:32:02 -05:00
Jason Zimdars be9c4b706f This needs to always be present to so we can mark unread when there are no unreads 2025-07-23 17:57:12 -05:00
Jason Zimdars 046d66fbed Consistent with Mark as read 2025-07-23 17:45:12 -05:00
Jason Zimdars 250d38768f Rename helper since it now handles both actions 2025-07-23 17:44:52 -05:00
Jason Zimdars db92de7a27 data-controller = form needs to be on the form or it causes errors
- The whole reason we're using `form.submit` here is to prevent clicks on the card link
2025-07-23 17:43:15 -05:00
Jason Zimdars 99df4b1a12 No longer used 2025-07-23 17:33:56 -05:00
Jason Zimdars 43e515f2a7 Always display the mark-as-unread button in previously seen 2025-07-23 17:32:07 -05:00
Jason Zimdars 84f19183be Add model test for read and unread 2025-07-23 17:28:15 -05:00
Jason Zimdars 6ef390f201 Test the destroy action 2025-07-23 17:26:01 -05:00
Jason Zimdars 4276aad5a7 Mark notifications as unread from the index 2025-07-23 17:01:59 -05:00
Andy Smith 939d1b267c Merge pull request #800 from basecamp/pinned-stages-position
Make room for pin clear button when dialog is expanded
2025-07-23 16:03:52 -05:00
Andy Smith e722cc63a6 Make room for pin clear button when dialog is expanded 2025-07-23 15:50:51 -05:00
Jason Zimdars dc9b31b6e6 Merge pull request #781 from basecamp/web-push
Web push
2025-07-23 12:58:38 -05:00
Andy Smith 4b7a7aeea5 Merge pull request #785 from basecamp/hide-placeholder-when-bullets-exist
Hide placeholder when list is inserted
2025-07-23 12:40:35 -05:00
Jason Zimdars 8f154b36c0 Add vapid keys for remaining environments 2025-07-23 12:31:23 -05:00
Andy Smith 2b80447a41 Merge pull request #795 from basecamp/hide-attachment-icon-when-closed
Align elements in mini-closed state
2025-07-23 12:29:06 -05:00
Andy Smith af542a164b Merge branch 'main' into hide-attachment-icon-when-closed
* main: (46 commits)
  Regenerate fixtures
  Let summaries know about collections
  Regenerate fixtures
  More tweaks
  Regenerate fixtures after tweaking prompt
  Fix model selection (I had broken it!)
  Some prompt refinements
  Some of us have basecamp.com email addresses
  Update nokogiri and thor to addres CVEs
  Fix tests
  Format
  Move model options to helper
  Tidy up the admin tool for prompts
  Extract methods
  Format
  Default to the current summary
  Make models selectable
  Add an animated effect for the generating state
  Remove debug
  Wrap them both in the container so the generating state looks right
  ...
2025-07-23 12:16:06 -05:00
Jason Zimdars 4619429db0 Update Gemfile.lock 2025-07-23 11:53:10 -05:00
Jason Zimdars dfb6198e94 Merge branch 'main' into web-push
* main: (50 commits)
  Regenerate fixtures
  Let summaries know about collections
  Regenerate fixtures
  More tweaks
  Regenerate fixtures after tweaking prompt
  Fix model selection (I had broken it!)
  Some prompt refinements
  Some of us have basecamp.com email addresses
  Update nokogiri and thor to addres CVEs
  Fix tests
  Format
  Move model options to helper
  Tidy up the admin tool for prompts
  Extract methods
  Format
  Default to the current summary
  Make models selectable
  Add an animated effect for the generating state
  Remove debug
  Wrap them both in the container so the generating state looks right
  ...
2025-07-23 11:50:35 -05:00
Jorge Manrubia 295e7f4f75 Merge pull request #796 from basecamp/card-collection
Let summaries know about collections
2025-07-23 16:59:43 +02:00