Commit Graph

510 Commits

Author SHA1 Message Date
Jose Farias f53ee0ddac Sanitize params after initialization 2024-11-06 18:19:19 -06:00
Jose Farias e73f44cde9 Unnecessary parens 2024-11-06 18:16:18 -06:00
Jose Farias f7495ac1fa Improve denormalized filters note 2024-11-06 18:13:05 -06:00
Jose Farias 9efe94a277 idempotent_create -> persist 2024-11-06 18:09:55 -06:00
Jose Farias 32618debf6 Pull out strip_default_params 2024-11-06 18:05:15 -06:00
Jose Farias 49f3894bcb Update denormalization comment 2024-11-06 18:01:40 -06:00
Jose Farias be0973705c Unnecessary newline 2024-11-06 17:56:46 -06:00
Jose Farias a853f75ef9 No need to set resources in to_params anymore
They're denormalized now
2024-11-06 17:54:43 -06:00
Jose Farias e6cf8d3571 Delegate default_params to class 2024-11-06 17:52:31 -06:00
Jose Farias 12ce07639d Add tests 2024-11-06 17:49:14 -06:00
Jose Farias 3d9d169477 Many-to-many relationship for filters and filterables 2024-11-05 21:21:46 -06:00
Jose Farias ca6d018106 Attribute filter fixture to david 2024-11-05 15:45:13 -06:00
Jose Farias f3b456c551 Fix tests 2024-11-05 14:14:33 -06:00
Jose Farias f2706d0f74 Unnest bubble filters 2024-11-05 13:04:05 -06:00
Jason Zimdars 26af27ba26 Needs to be scoped to index view 2024-11-01 16:19:21 -05:00
Jason Zimdars 167c1d0275 Consistent perma rendering 2024-11-01 15:56:23 -05:00
Jason Zimdars df5ed70ea9 Include list view 2024-11-01 10:03:14 -05:00
Jason Zimdars c74e2ecd1d Improve bubble animation effect 2024-11-01 09:32:12 -05:00
Jason Zimdars fa808e8970 A11y 2024-10-31 14:26:17 -05:00
Jason Zimdars deba15f2f0 Needs these for PWA 2024-10-31 14:25:47 -05:00
Jason Zimdars d3acbd2a55 Render bubbles without inline SVG, try a more fluid animation 2024-10-30 17:44:15 -05:00
Jason Zimdars 132ae12cdf Start improving Workflows UI 2024-10-28 17:43:01 -05:00
Jason Zimdars 5740a4be23 Tighten up users lists 2024-10-28 17:20:49 -05:00
Jason Zimdars 49f1520978 Undo this change from the Montreal presentation 2024-10-28 17:18:39 -05:00
Jose Farias 33afd180a4 Make event summaries not null
We can do this now that the data has been migrated
2024-10-28 12:33:09 -06:00
Jose Farias ed176def10 Merge pull request #124 from basecamp/threadables
Build threads from a single table
2024-10-28 12:20:35 -06:00
Jose Farias 017eff6b1e Remove extra newline 2024-10-28 11:23:03 -06:00
Jose Farias 2f7baaff29 create -> create! 2024-10-28 10:47:49 -06:00
Jose Farias cf9b07711a Document left_joins_messageable smell 2024-10-28 10:27:50 -06:00
Jose Farias 5cdf83163c Document with_status name smell 2024-10-28 10:25:56 -06:00
Jose Farias dbad5a1a8c Document intention to persist summary body 2024-10-28 10:24:43 -06:00
Jose Farias 79869858da Pull out new_comment_placeholder helper 2024-10-28 10:23:40 -06:00
Jose Farias 404755c9d9 Clean up Bubble#track_event 2024-10-28 10:20:39 -06:00
Jose Farias e6622a1e7d Use targets for created-by-current-user-controller 2024-10-28 10:14:39 -06:00
Jose Farias c571c4400d Inline EventSummary#tallied_boosts 2024-10-28 10:07:25 -06:00
Jose Farias 8b062b4432 Pull out Bubble#activity_count 2024-10-28 10:07:12 -06:00
Jose Farias e8eb5ac243 Pass filter to filter helpers 2024-10-28 10:06:56 -06:00
Jose Farias e92da7c73a Test EventSummary bodies 2024-10-27 20:30:15 -06:00
Jose Farias ca0abdb3a5 Test capturing 2024-10-27 20:23:28 -06:00
Jose Farias a64752e573 Clear up messages integration test 2024-10-27 20:21:32 -06:00
Jose Farias c220a305e7 Ignore left_joins_messageable interpolation for Brakeman 2024-10-27 20:19:03 -06:00
Jose Farias 9e60362ca7 Write messages integration test 2024-10-27 20:17:34 -06:00
Jose Farias 46d1ce4702 Make it clear where the boost_count is coming from 2024-10-27 19:53:37 -06:00
Jose Farias 2fb6ed76b3 Fix comments-dependent scopes 2024-10-27 19:50:06 -06:00
Jose Farias 3bb6419c08 Remove boosted action partial 2024-10-27 17:56:37 -06:00
Jose Farias 61d68bf79d Account for event summaries with no boosts 2024-10-27 17:53:00 -06:00
Jose Farias 287a956364 Let EventSummary do the work to summarize events 2024-10-27 17:41:48 -06:00
Jose Farias 0727414017 Lean into delegated types APIs 2024-10-27 17:39:30 -06:00
Jose Farias f782b43ef5 find_or_create_next_summary -> find_or_create_active_summary 2024-10-27 12:36:37 -06:00
Jose Farias 4cd5dc0b35 Fix event tests 2024-10-27 12:33:51 -06:00