Commit Graph

710 Commits

Author SHA1 Message Date
Jason Zimdars fdf93b2bc0 Make close and trash more distinct 2024-12-17 10:10:31 -06:00
Jason Zimdars 1eb40a318b Update test 2024-12-16 17:49:21 -06:00
Jason Zimdars 33d2d098f1 Wire up comment deletion 2024-12-16 17:46:01 -06:00
Jason Zimdars bcc57d66dd Whitespace 2024-12-16 17:29:07 -06:00
Jason Zimdars 4644fe43ee Wire up editing comments 2024-12-16 17:28:27 -06:00
Jason Zimdars 520bead27f Open the title field for editing after creating a new bubble 2024-12-16 16:59:31 -06:00
Jose Farias 6157cfcdc0 Merge pull request #157 from basecamp/everyone
Implement all-access buckets
2024-12-16 12:46:02 -06:00
Jason Zimdars b8d256d68d Improve the flow for editing bubble titles
- Keyboard shortcuts (ctrl-enter, meta-enter, esc)
- Visible submit button
- Hide tags while editing (so we can edit them inline later)
2024-12-16 12:04:21 -06:00
Jose Farias 285bde1e52 Use path helpers in tests 2024-12-16 11:36:24 -06:00
Jose Farias 292b323ab9 Revising access shouldn't do a replace turbo-action 2024-12-16 11:36:11 -06:00
Jose Farias e085cb7497 Split into new tests 2024-12-16 11:35:50 -06:00
Jose Farias d13d558a0b Merge branch 'main' into everyone
* main:
  Update this test, too
  Adjust tests to match new behavior
  Don't autocomplete
  Rework boosts form so you can enter any integer
2024-12-16 11:19:36 -06:00
Jason Zimdars 5fdea98b8d Update this test, too 2024-12-16 11:15:56 -06:00
Jason Zimdars 6bd15dd653 Adjust tests to match new behavior 2024-12-16 10:42:11 -06:00
Jose Farias aed33620ba Reapply "Destroy equivalent filters upon resource removal"
This reverts commit 5e09fddbe0.
2024-12-13 18:51:22 -06:00
Jose Farias 5e09fddbe0 Revert "Destroy equivalent filters upon resource removal"
This reverts commit 6c69bf7dc1.
2024-12-13 18:49:41 -06:00
Jose Farias 6c69bf7dc1 Destroy equivalent filters upon resource removal 2024-12-13 17:26:30 -06:00
Jason Zimdars b6d4e8a07e Don't autocomplete 2024-12-13 17:02:11 -06:00
Jason Zimdars 0b28a18c05 Rework boosts form so you can enter any integer 2024-12-13 16:54:11 -06:00
Jose Farias 4482a7e5e9 Pull out access_menu_tag 2024-12-13 14:59:31 -06:00
Jose Farias 2f7c3d0fd3 Punt on removing filters for inaccessible buckets
Current behavior just stops querying for bubbles in inaccessible buckets. That might be fine.
2024-12-13 14:41:10 -06:00
Jose Farias 4095eba266 Can't see bubbles in buckets you've lost access to 2024-12-13 14:37:19 -06:00
Jose Farias ce0577d3c1 Users can remove themselves from buckets 2024-12-13 14:07:48 -06:00
Jose Farias 738590bcaf Merge branch 'main' into everyone
* main:
  Bump rails from `91d4563` to `5520bd8`
  dep: bundle update everything except rails
  dep: update sqlite3 gem to v2.4.1
2024-12-12 20:25:04 -06:00
Jose Farias 6ea3053f7f Fix redirect assertion 2024-12-12 20:15:06 -06:00
Jose Farias da6e32e218 Fix redirect assertion 2024-12-12 20:14:41 -06:00
Jose Farias d7e5e0d236 Submit form when toggling all-access + caching 2024-12-12 20:14:09 -06:00
Jose Farias 230a13b1e2 Unnecessary parens 2024-12-12 19:34:30 -06:00
Jose Farias 065b73f889 Can't revoke access to all-access bucket 2024-12-12 19:08:36 -06:00
Jose Farias 688f812336 Unnecessary parens 2024-12-10 19:52:42 -06:00
Jose Farias 4e460041e0 Use #with_defaults 2024-12-10 19:49:48 -06:00
Jose Farias 59c66923f0 Implement all_access buckets 2024-12-10 19:46:40 -06:00
Mike Dalessio 7d7a8ae65d Merge pull request #153 from basecamp/dependabot/bundler/rails-5520bd8
Bump rails from `91d4563` to `5520bd8`
2024-12-09 14:15:27 -05:00
dependabot[bot] ef39cb1d8b Bump rails from 91d4563 to 5520bd8
Bumps [rails](https://github.com/rails/rails) from `91d4563` to `5520bd8`.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](https://github.com/rails/rails/compare/91d456366638ac6c3f6dec38670c8ada5e7c69b1...5520bd835e3724ffafe3f719f9aafe951567f2f3)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-09 19:13:37 +00:00
Mike Dalessio fd97bae414 Merge pull request #154 from basecamp/flavorjones-bundle-update
dep: bundle update everything except rails
2024-12-09 14:12:16 -05:00
Mike Dalessio 3764f0dfa1 dep: bundle update everything except rails 2024-12-09 14:10:20 -05:00
Mike Dalessio 37e4543c4e Merge pull request #152 from basecamp/flavorjones-dep-bump-sqlite
dep: update sqlite3 gem to v2.4.1
2024-12-09 14:08:49 -05:00
Mike Dalessio df4af0808c dep: update sqlite3 gem to v2.4.1 2024-12-09 14:06:23 -05:00
Jason Zimdars f8f320d76c Adjust position of settings buttons 2024-12-06 17:21:34 -06:00
Jason Zimdars 1292729226 Actually, no need for a max-size, just let it grow 2024-12-06 17:05:12 -06:00
Jason Zimdars 4d383c7a77 Improve comment form design 2024-12-06 17:01:25 -06:00
Jason Zimdars e2372fae93 Same style as combobox pop-ups 2024-12-05 15:39:48 -06:00
Jason Zimdars c84e1b4685 Ensure bubbles are clickable anyplace in windshield 2024-12-05 11:46:33 -06:00
Jason Zimdars 23b936010f Deal with truncation in the list layout, too 2024-12-04 17:58:14 -06:00
Jason Zimdars 245e2ea3bd Ensure tags don't affect the bubble shape or spill out of the container 2024-12-04 17:42:47 -06:00
Jason Zimdars 259bb4d8c3 Style pop-up UI for selecting assignments and tags 2024-12-04 17:26:32 -06:00
Jason Zimdars a8e24ffdda Adjust position now that bubbles won't be so vertical 2024-12-04 17:26:32 -06:00
Jason Zimdars 792a862e9f Fix that bubbles could collapse in some situations 2024-12-04 17:26:32 -06:00
Mike Dalessio 710ca21f86 Merge pull request #149 from basecamp/flavorjones-dep-rails-edge
dep: update to Rails edge
2024-12-04 18:12:06 -05:00
Mike Dalessio a95aa1ea97 dep: bump rexml to address dependabot alert
- https://github.com/basecamp/fizzy/security/dependabot/8
- https://www.ruby-lang.org/en/news/2024/10/28/redos-rexml-cve-2024-49761/
2024-12-04 17:42:38 -05:00