Commit Graph

98 Commits

Author SHA1 Message Date
Andy Smith 3fb45c14e3 Merge branch 'main' into mobile-columns-pt-iii
* main:
  Update Rails
  Ignore hotkeys with modifiers
  Fix 1Password account ID (was user UUID) (#2278)
  Switch 1Password account to 37signals.1password.com (#2276)
  Remove CSS testing comments
  Max card count equals geared pagination size
  Block IPv4-compatible IPv6 addresses in SSRF protection (#2273)
  Only enable transitions on user interaction
  Don't update counter if value hasn't changed
2026-01-02 14:50:27 -06:00
Andy Smith 5b6fdbfeae Fix mini bubble cropping, filters padding, and grid-style 2026-01-02 12:45:53 -06:00
Andy Smith b4096d9f22 Move card__list outside pagination 2026-01-02 11:42:00 -06:00
Andy Smith 711eec133a Max card count equals geared pagination size 2025-12-30 12:30:55 -06:00
Andy Smith b9c11ad768 Only enable transitions on user interaction 2025-12-29 15:30:55 -06:00
Andy Smith 58a330aa17 Merge branch 'main' into mobile-columns-pt-iii
* main: (55 commits)
  Add padding to upgrade message on larger screens
  Add test coverage for autolinking multiple URLs
  Add "noopener" to autolinks' rel attribute
  Avoid string manipulation when autolinking.
  Only bump z-index when nav is open
  Move nav and related elements above footer
  Delete Dockerfile.dev
  fix: use the right gh-cli arch package (#2232)
  Bump actions/attest-build-provenance from 3.0.0 to 3.1.0 (#2257)
  Bump docker/setup-buildx-action from 3.11.1 to 3.12.0 (#2256)
  Consider user avatars always public
  Implement authorization for Active Storage endpoints
  Update documentation
  Expose the card ID and URL on comments
  Don't run application recurring jobs in betas
  This link is reduntant if you're over the limits
  Add obvious upgrade button when you're out of storage
  Internaly only view
  Target comment elements more precisely
  Better name for helper method
  ...
2025-12-29 14:07:00 -06:00
Jason Zimdars 6de7b40024 Explicitly diable hotkeys in Not Now and Done 2025-12-22 14:14:50 -06:00
Andy Smith b7951718f3 Position New Column absolutely to center collapsed columns 2025-12-19 15:27:18 -06:00
Jason Zimdars 6e90a6dbfb Add hotkeys for triaging cards in columns
Hover to select items
2025-12-19 14:33:47 -06:00
Andy Smith c3a3aa108a Merge branch 'main' into mobile-columns-pt-iii
* main: (318 commits)
  Document the new sign in method
  Replace handle_ naming
  Use same constant for fake magic links
  Replace FakeMagicLink with a temporary object
  Tidy up session_token
  Clean up interfaces
  Split tests by controller or responsibility
  Simplify auth logic
  Fix due to unit test when creating with invalid emails
  Restore sessions_controller test on creating invalid email address
  Move magic link api tests to their own files
  Rename test to clarify what they're about
  Cleanup session creation
  Update to always return a pending auth token for JSON responses.
  Update API test for cross code
  Change test expectation on single tenant mode account creation
  Add unit tests for the new endpoints
  Pass a server token when creating a magic link via API
  Simplify code a bit
  Simplify session create logic for both html and json
  ...
2025-12-19 13:13:15 -06:00
Italo Matos fd89a452c3 Optimize card count queries to avoid duplicates
Replace duplicate .count calls with cached variables using .size method.
This reduces database queries by approximately 50% on mobile board views.

Changes:
- Cache card counts in local variables (postponed, awaiting_triage, closed, active)
- Use .size instead of .count (more intelligent - leverages preload when available)
- Reuse cached values instead of making duplicate SQL queries

Impact:
- Mobile columns view: reduced from ~6 to ~3 COUNT queries
- Better performance with no visual changes to the UI
2025-12-18 07:09:57 -03:00
Andy Smith e24569584d Move board-tools inside list 2025-12-15 15:51:53 -06:00
Andy Smith ea4520575a Hide scrollbars on lists 2025-12-15 15:48:40 -06:00
Andy Smith adceae2e71 Scrolling in place (borked padding) 2025-12-15 15:13:14 -06:00
Andy Smith f2591e7da6 Basic scrolling setup 2025-12-15 14:56:27 -06:00
Andy Smith bf62c97c25 Fix horizontal scrolling 2025-12-12 16:18:47 -06:00
Andy Smith 44e7e662a8 Adjust padding on new card element 2025-12-12 14:54:03 -06:00
Andy Smith a94f6e8f0d Remove old mobile columns stuff 2025-12-12 14:40:20 -06:00
Andy Smith c6bfeb6982 Handle Maybe column state at desktop breakpoint 2025-12-12 13:49:17 -06:00
Andy Smith 3b08041a3e Only use grid layout when centering the Maybe column 2025-12-12 13:16:45 -06:00
Andy Smith b3cfae3529 Consolidate UI elements from "the stream" and "Considering" to "Maybe?" 2025-12-12 12:29:01 -06:00
Tomas Costantino 5ece8f7c33 replace destroy column turbo stream for redirect_back_or_to 2025-12-11 10:42:44 +01:00
Tomas Costantino 2e629db9d6 rename to use refresh adjacent columns turbo stream 2025-12-11 10:29:25 +01:00
Tomas Costantino df7e597066 Merge branch 'main' into update-columns-on-actions 2025-12-11 10:17:15 +01:00
Andy Smith bed0e4bd9e Merge pull request #2009 from nqst/clickable-checkbox-labels
Make toggle switch labels clickable
2025-12-10 14:47:51 -06:00
Stanko K.R. 3257e4a6e9 Inline partials 2025-12-10 15:27:56 +01:00
Stanko K.R. 7b30ca203e Add index actions for Comments and Columns
Also, fix crash when a deactivated user is serialized (they don't have
an identity).
2025-12-10 09:23:52 +01:00
Stanko K.R. f3ff0c605e Add pagination to most places and fix cards pagination 2025-12-10 09:23:52 +01:00
Stanko K.R. 7a0554774c Add API for columns 2025-12-10 09:23:52 +01:00
David Heinemeier Hansson ea697b7143 Add API to boards 2025-12-10 09:23:52 +01:00
Tomas Costantino 8e6e761798 update views to use refresh_surroundings stream 2025-12-09 11:28:42 +01:00
Tomas Costantino 8a7abc3796 refresh sibling columns on column creation and deletion 2025-12-09 10:13:46 +01:00
Alexander Zaytsev 7c010ead87 Add cursor-pointer utility and apply to icon labels 2025-12-08 22:33:31 +01:00
Alexander Zaytsev f64de1c0ae Cleanup: apply classes to <form>, remove extra div 2025-12-08 22:26:17 +01:00
Alexander Zaytsev 98d5d317be Don't use IDs, wrap input inside label instead 2025-12-08 22:21:37 +01:00
Mike Dalessio 48730d67e0 Disable board edit buttons for select all/none when not privileged
ref: https://github.com/basecamp/fizzy/discussions/1992
2025-12-08 13:32:41 -05:00
Alexander Zaytsev a992be8143 Make board publication switch icons clickable 2025-12-08 16:22:43 +01:00
Justin Starner 330be4ec72 Position modal buttons using justify-center. 2025-12-05 15:25:24 -05:00
Justin Starner fc3b63bb52 Refactor board deletion to use custom modal
Applies the custom dialog modal pattern to the board deletion workflow, matching the card deletion updates.
2025-12-04 21:49:30 -05:00
Andy Smith 1c5ead0096 Merge pull request #1930 from basecamp/prevent-blank-board-names
Prevent board names with only spaces and show validation message
2025-12-04 14:50:17 -06:00
Jorge Manrubia a380492b32 Animate the column height with a stimulus controller so that it does not depend to the server to update when you D&D 2025-12-04 19:15:38 +01:00
Andy Smith 23ec3f129a Support custom validation messages 2025-12-04 11:43:55 -06:00
Andy Smith 5c4fe9fe8b Prevent board names with only spaces and show validation message 2025-12-04 11:37:27 -06:00
Jorge Manrubia 539d3721db Keep the column color when D&D cards 2025-12-04 18:31:23 +01:00
Jorge Manrubia 104bb5faa9 Add container to drop cards when the stream is empty 2025-12-04 18:31:23 +01:00
Jorge Manrubia 19051aec3e Append dropped cards instead of relying on server-side rendering to refresh the columns
This implements a simple strategy to optimistically insert cards in columns without waiting for the column refresh. Cards will be placed at the top respecting golden cards.

This uses sorting by "created at" with sorting by "updated at" for the _Not now_ column, so that the treatment everywhere is homogenous.
2025-12-04 18:31:23 +01:00
Andy Smith 78ea18b5da Merge pull request #1872 from basecamp/filters-no-results
Nicer blank slates
2025-12-04 10:52:08 -06:00
Andy Smith 0ef6f8a822 Nicer blank slates 2025-12-03 14:11:08 -06:00
Jason Zimdars 8f2ec267f6 Merge pull request #1820 from dcchambers/delete-board-confirmation
Add card deletion warning to board deletion confirmation message
2025-12-03 13:42:06 -06:00
Dakota Chambers a98cb58348 Update app/views/boards/edit/_delete.html.erb
Co-authored-by: Jason Zimdars <jz@37signals.com>
2025-12-03 13:04:29 -06:00