Jeremy Daer
a52b6f1c87
* Add explicit wrap_parameters to controllers for flat JSON API support Virtual attributes (has_rich_text, has_one_attached, delegated setters, ActiveModel attrs) are not in Model.attribute_names, so wrap_parameters auto-detection silently drops them from flat JSON requests. Add explicit include: lists matching each controller's permitted params. * Convert short-form wrap_parameters to explicit include: lists Defense-in-depth: these controllers only have real-column params today, so auto-detection works, but explicit lists prevent future regressions if virtual attributes are added. * Add flat JSON param tests for all wrap_parameters controllers 17 new tests covering every controller with wrap_parameters, verifying that flat (unwrapped) JSON payloads are correctly wrapped and processed. Focuses on virtual attributes that would be silently dropped without explicit include: lists.
45 lines
1016 B
Ruby
45 lines
1016 B
Ruby
class Account::JoinCodesController < ApplicationController
|
|
wrap_parameters :account_join_code, include: %i[ usage_limit ]
|
|
|
|
before_action :set_join_code
|
|
before_action :ensure_admin, only: %i[ update destroy ]
|
|
|
|
def show
|
|
end
|
|
|
|
def edit
|
|
end
|
|
|
|
def update
|
|
if @join_code.update(join_code_params)
|
|
respond_to do |format|
|
|
format.html { redirect_to account_join_code_path }
|
|
format.json { head :no_content }
|
|
end
|
|
else
|
|
respond_to do |format|
|
|
format.html { render :edit, status: :unprocessable_entity }
|
|
format.json { render json: @join_code.errors, status: :unprocessable_entity }
|
|
end
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@join_code.reset
|
|
|
|
respond_to do |format|
|
|
format.html { redirect_to account_join_code_path }
|
|
format.json { head :no_content }
|
|
end
|
|
end
|
|
|
|
private
|
|
def set_join_code
|
|
@join_code = Current.account.join_code
|
|
end
|
|
|
|
def join_code_params
|
|
params.expect account_join_code: [ :usage_limit ]
|
|
end
|
|
end
|