"Stalled" not "Stale"
The latter sounds like old bread.
This commit is contained in:
@@ -20,11 +20,11 @@ class Bubble < ApplicationRecord
|
||||
scope :indexed_by, ->(index) do
|
||||
case index
|
||||
when "most_active" then ordered_by_activity
|
||||
when "most_stale" then ordered_by_staleness
|
||||
when "most_discussed" then ordered_by_comments
|
||||
when "most_boosted" then ordered_by_boosts
|
||||
when "newest" then reverse_chronologically
|
||||
when "oldest" then chronologically
|
||||
when "stalled" then ordered_by_staleness
|
||||
when "popped" then popped
|
||||
end
|
||||
end
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
module Filter::Fields
|
||||
extend ActiveSupport::Concern
|
||||
|
||||
INDEXES = %w[ most_discussed most_boosted most_stale newest oldest popped ]
|
||||
INDEXES = %w[ most_discussed most_boosted newest oldest stalled popped ]
|
||||
|
||||
delegate :default_value?, to: :class
|
||||
|
||||
|
||||
@@ -111,8 +111,8 @@ class FilterTest < ActiveSupport::TestCase
|
||||
filters(:jz_assignments).update!(stages: [], assignees: [], tags: [], buckets: [ buckets(:writebook) ])
|
||||
assert_equal "Most discussed in Writebook", filters(:jz_assignments).summary
|
||||
|
||||
filters(:jz_assignments).update!(indexed_by: "most_stale")
|
||||
assert_equal "Most stale in Writebook", filters(:jz_assignments).summary
|
||||
filters(:jz_assignments).update!(indexed_by: "stalled")
|
||||
assert_equal "Stalled in Writebook", filters(:jz_assignments).summary
|
||||
end
|
||||
|
||||
test "params without a key-value pair" do
|
||||
|
||||
Reference in New Issue
Block a user