bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1143 from basecamp/restore-search

Browse Source 
Restore filter targets so that search works!
This commit is contained in:
Jorge Manrubia
2025-09-19 17:44:02 +02:00
committed by GitHub
parent e7912fbb58 3b83d218ea
commit 5a8bfbfdb0
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/views/filters/settings/_assignees.html.erb
+2 -2
View File
@@ -25,7 +25,7 @@
<ul class="popup__list" data-filter-target="list" role="listbox">
<%= tag.li class: "popup__item", data: {
navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: "unassigned", multi_selection_combobox_label: "No one" },
filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: "unassigned", multi_selection_combobox_label: "No one" },
role: "checkbox", aria: { checked: filter.assignment_status.unassigned? } do %>
<button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#clear form#submit filter-settings#change">
<span class="overflow-ellipsis flex-item-grow">No one</span>
@@ -35,7 +35,7 @@
<% user_filtering.users.each do |user| %>
<%= tag.li class: "popup__item", data: {
navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
role: "checkbox", aria: { checked: filter.assignees.include?(user) } do %>
<button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#change form#submit filter-settings#change">
<span class="overflow-ellipsis flex-item-grow"><%= user.name %></span>
app/views/filters/settings/_closers.html.erb
+1 -1
View File
@@ -27,7 +27,7 @@
<ul class="popup__list" data-filter-target="list" role="listbox">
<% user_filtering.users.each do |user| %>
<%= tag.li class: "popup__item", data: {
navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
role: "checkbox", aria: { checked: filter.closers.include?(user) } do %>
<button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#change form#submit filter-settings#change">
<span class="overflow-ellipsis flex-item-grow"><%= user.name %></span>
app/views/filters/settings/_creators.html.erb
+1 -1
View File
@@ -27,7 +27,7 @@
<ul class="popup__list" data-filter-target="list" role="listbox">
<% user_filtering.users.each do |user| %>
<%= tag.li class: "popup__item", data: {
navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
role: "checkbox", aria: { checked: filter.creators.include?(user) } do %>
<button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#change form#submit filter-settings#change">
<span class="overflow-ellipsis flex-item-grow"><%= user.name %></span>
app/views/filters/settings/_tags.html.erb
+1 -1
View File
@@ -26,7 +26,7 @@
<ul class="popup__list" data-filter-target="list" role="listbox">
<% user_filtering.tags.each do |tag| %>
<%= content_tag(:li, class: "popup__item", data: {
navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: tag.id, multi_selection_combobox_label: tag.hashtag },
filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: tag.id, multi_selection_combobox_label: tag.hashtag },
role: "checkbox", aria: { checked: filter.tags.include?(tag) }) do %>
<button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#change form#submit filter-settings#change">
<span class="overflow-ellipsis flex-item-grow"><%= tag.hashtag %></span>