Settle on "Moved to Done"

This commit is contained in:
Jason Zimdars
2025-10-17 16:56:26 -05:00
parent 4373b74fbb
commit 8ca9e80c6c
6 changed files with 6 additions and 6 deletions
+1 -1
View File
@@ -84,7 +84,7 @@ module EventsHelper
when "card_published"
"#{h event_creator_name(event) } added <span style='color: var(--card-color)'>\"#{h title }\"</span>".html_safe
when "card_closed"
"#{h event_creator_name(event) } marked <span style='color: var(--card-color)'>\"#{h title }\"</span> as done".html_safe
"#{h event_creator_name(event) } moved <span style='color: var(--card-color)'>\"#{h title }\"</span> to done".html_safe
when "card_reopened"
"#{h event_creator_name(event) } reopened <span style='color: var(--card-color)'>\"#{h title }\"</span>".html_safe
when "card_due_date_added"
+1 -1
View File
@@ -10,7 +10,7 @@ module NotificationsHelper
name = event.creator.name
case event_notification_action(event)
when "card_closed" then "Marked as “Done by #{name}"
when "card_closed" then "Moved to Done by #{name}"
when "card_reopened" then "Reopened by #{name}"
when "card_published" then "Added by #{name}"
when "comment_created" then comment_notification_body(event)
+1 -1
View File
@@ -1,7 +1,7 @@
module WebhooksHelper
ACTION_LABELS = {
card_assigned: "Card assigned",
card_closed: "Card marked as Done",
card_closed: "Card moved to Done",
card_collection_changed: "Card collection changed",
card_due_date_added: "Card due date added",
card_due_date_changed: "Card due date changed",
@@ -19,7 +19,7 @@ class Card::Eventable::SystemCommenter
when "card_unassigned"
"#{event.creator.name} <strong>unassigned</strong> from #{event.assignees.pluck(:name).to_sentence}."
when "card_closed"
"<strong>Marked</strong> as “Done by #{ event.creator.name }"
"<strong>Moved</strong> to Done by #{ event.creator.name }"
when "card_reopened"
"<strong>Reopened</strong> by #{ event.creator.name }"
when "card_title_changed"
+1 -1
View File
@@ -60,7 +60,7 @@ class NotificationPusher
)
when "card_closed"
base_payload.merge(
body: card.closure ? "Marked as “Done by #{event.creator.name}" : "Closed by #{event.creator.name}"
body: card.closure ? "Moved to Done by #{event.creator.name}" : "Closed by #{event.creator.name}"
)
when "card_reopened"
base_payload.merge(
@@ -22,7 +22,7 @@ class Card::Eventable::SystemCommenterTest < ActiveSupport::TestCase
end
test "card_closed" do
assert_system_comment "Marked as “Done by David" do
assert_system_comment "Moved to Done by David" do
@card.close
end
end