Merge pull request #2233 from basecamp/assignee-spacing

Replace span with li
This commit is contained in:
Andy Smith
2025-12-22 16:08:21 -06:00
committed by GitHub
2 changed files with 2 additions and 4 deletions
+1 -1
View File
@@ -1,4 +1,4 @@
<li class="popup__item" data-filter-target="item" data-navigable-list-target="item" aria-checked="<%= card.assignees.include?(user) %>">
<li class="popup__item" data-filter-target="item" data-navigable-list-target="item" <%= tag.attributes(data: local_assigns.fetch(:data, {})) %> aria-checked="<%= card.assignees.include?(user) %>">
<%= button_to card_assignments_path(card, params: { assignee_id: user.id }), method: :post,
class: "popup__btn btn", form_class: "max-width flex-item-grow" do %>
<span class="overflow-ellipsis flex-item-grow"><%= local_assigns.fetch(:user_label, user.name) %></span>
+1 -3
View File
@@ -23,9 +23,7 @@
<% end %>
<%= render collection: @assigned_to, partial: "user", locals: { card: @card } %>
<% @users.each do |user| %>
<span data-assignment-limit-target="unassigned">
<%= render "user", card: @card, user: user %>
</span>
<%= render "user", card: @card, user: user, data: { assignment_limit_target: "unassigned" } %>
<% end %>
</ul>