Commit Graph

5545 Commits

Author SHA1 Message Date
Jorge Manrubia 2de27634d4 Merge pull request #1258 from basecamp/cleanup-workflows
Cleanup workflow/stages
2025-10-07 11:17:16 +02:00
Jorge Manrubia 1d1a3da9cf Cleanup workflow/stages
This was pending after moving to columns
2025-10-07 11:10:10 +02:00
Jorge Manrubia 6af1b3a40a Merge pull request #1257 from basecamp/filter-drafts
Exclude drafts from filtered cards
2025-10-07 10:34:49 +02:00
Jorge Manrubia 7cb575b329 Exclude drafts from filtered cards 2025-10-07 10:32:10 +02:00
Jorge Manrubia b7ea9d80ee Merge pull request #1256 from basecamp/comment-links
Fix: anchor links to comments not working
2025-10-07 10:13:16 +02:00
Jorge Manrubia 6af27c91d8 Fix: anchor links to comments not working
The problem was having the turbo frames as targets: their display: contents would make
auto-scrolling not working!

https://fizzy.37signals.com/5986089/cards/2190
2025-10-07 10:11:05 +02:00
Jorge Manrubia d4b9513d55 Merge pull request #1255 from basecamp/fix-syntax
Fix: no syntax highlighting for Lexxy code in production
2025-10-07 09:44:23 +02:00
Jorge Manrubia 59db345484 Don't lose existing values in case they had been set 2025-10-07 09:42:25 +02:00
Jorge Manrubia 2d2cc3bc23 Merge pull request #1254 from basecamp/pagination-improvements
Pagination improvements
2025-10-07 09:00:45 +02:00
Jorge Manrubia fe559cbca0 Brakeman ignore 2025-10-07 09:00:07 +02:00
Jorge Manrubia 00a9682bdf Prepare pagination link to be styled 2025-10-07 08:56:29 +02:00
Mike Dalessio 624d0662dd Merge pull request #1253 from basecamp/fix-script
Update the load-prod-db-in-dev script to handle migrations
2025-10-07 02:51:18 -04:00
Jorge Manrubia 543469965a Make all the pagination automatic 2025-10-07 08:50:33 +02:00
Mike Dalessio 73faf76976 Fix seeds script
broken in eb9ed86f
2025-10-07 02:50:15 -04:00
Jorge Manrubia 4e6866bd2e Add pagination to searches 2025-10-07 08:49:05 +02:00
Mike Dalessio 6f43fa3b2b Update the load-prod-db-in-dev script to handle migrations
This is obviously not a good fix, but it gets the job done. Permanent
fix will be researched at https://fizzy.37signals.com/5986089/cards/545
2025-10-07 02:45:54 -04:00
Jorge Manrubia 85907e2a4e Paginate filtered cards 2025-10-07 08:44:56 +02:00
Jorge Manrubia 0aca2a24bc Keep params when paginating, so that filters are kept 2025-10-07 08:41:48 +02:00
Jorge Manrubia 7ed5d31512 Merge pull request #1252 from basecamp/refactor-watchers
Use new method to fetch collection watchers
2025-10-07 08:34:50 +02:00
Jorge Manrubia 72ca4616b1 Update VCR fixtures 2025-10-07 08:34:08 +02:00
Jorge Manrubia e7db336a84 Use new method to fetch collection watchers 2025-10-07 08:33:14 +02:00
Jorge Manrubia d3d52fee2c Merge pull request #1241 from basecamp/fix-script 2025-10-07 08:15:05 +02:00
Mike Dalessio a94971ddd5 Merge pull request #1251 from basecamp/flavorjones/fix-cleanslate-seeds
Fix cleanslate seeds
2025-10-07 00:17:19 -04:00
Mike Dalessio 9bfd21c096 ci: remove outdated ignores from brakeman config 2025-10-07 00:16:47 -04:00
Mike Dalessio 3df6683736 Fix filter title when there's only one Collection in the account 2025-10-07 00:04:38 -04:00
Mike Dalessio eb9ed86f64 seeds: make sure the admin has the secret password 2025-10-06 23:57:39 -04:00
Mike Dalessio 0425a83577 seeds: drop the 'bare' option 2025-10-06 23:44:42 -04:00
Mike Dalessio c1372e34c9 Merge pull request #1250 from basecamp/flavorjones/assert-better-on-login-tests
test: assert on the redirect in the login helper
2025-10-06 17:20:15 -04:00
Mike Dalessio ffe9fdb099 test: assert on the redirect in the login helper
which can help diagnose more subtle Rails errors like in https://github.com/basecamp/activerecord-tenanted/issues/210
2025-10-06 17:00:36 -04:00
Andy Smith 09c29b5547 Merge pull request #1249 from basecamp/update-error-page-logo
Inline a shared logo for 404 page and fizzy-menu
2025-10-06 15:47:20 -05:00
Andy Smith 9c536361a6 Inline a shared logo for 404 page and fizzy-menu 2025-10-06 15:28:57 -05:00
Andy Smith c0ac0fb0f2 Merge pull request #1247 from basecamp/a11y-column-picker
Add proper radio functionality to column picker
2025-10-06 14:32:56 -05:00
Andy Smith 7affff16fd Add proper radio functionality to column picker 2025-10-06 14:25:07 -05:00
Andy Smith a2b21b75ee Merge pull request #1246 from basecamp/a11y-column-header
Use button instead of header for expander
2025-10-06 14:10:47 -05:00
Jason Zimdars 96f00bf122 Merge branch 'JZ/10/6/2025' 2025-10-06 14:07:01 -05:00
Jason Zimdars 609f6cfe6a Ensure you can click through to results below the header 2025-10-06 14:01:36 -05:00
Andy Smith efb0fd5237 Use button instead of header for expander 2025-10-06 13:59:02 -05:00
Jason Zimdars e077edc17a We need this for mobile rendering 2025-10-06 13:55:22 -05:00
Jason Zimdars bfb60deb80 Fix display of button in varying conditions 2025-10-06 13:34:18 -05:00
Jason Zimdars 0ff0ed796f Fix that pins were still hoverable and clickable when hidden 2025-10-06 13:29:31 -05:00
Jason Zimdars ae3a3b99da A little more space for Windows 2025-10-06 13:26:26 -05:00
Jason Zimdars 37c20caf98 Tighten up, remove keyboard nav hint
You'll only rarely need to use this, no need to explain a feature most
people don't need
2025-10-06 13:24:52 -05:00
Jason Zimdars f2abbb5d59 Display email address for users
Helps identify invited people
2025-10-06 13:10:19 -05:00
Andy Smith 5057b18027 Merge pull request #1245 from basecamp/follower-overflow
Fade out overflow on watcher avatars
2025-10-06 12:00:20 -05:00
Andy Smith 9b1cd84f96 Fade out overflow on watcher avatars 2025-10-06 11:37:16 -05:00
Jason Zimdars 31f2e941b2 Fix that background effect overlapped the pagination buttons 2025-10-06 09:27:56 -05:00
Jorge Manrubia 6073f79191 Invalidate cards when watching/unwatching
Follow up to https://fizzy.37signals.com/5986089/cards/2198
2025-10-06 16:13:33 +02:00
Jorge Manrubia dcffcd3d7b Merge pull request #1244 from basecamp/invalidate-watches
Invalidate cards when watchers change
2025-10-06 15:49:57 +02:00
Jorge Manrubia c846221208 Invalidate cards when watchers change 2025-10-06 15:44:12 +02:00
Jorge Manrubia 7dac096629 Merge pull request #1243 from basecamp/highlights-fixes
More fixes for highlights generation
2025-10-06 15:21:42 +02:00