Commit Graph

806 Commits

Author SHA1 Message Date
Andy Smith 649b4801bb Use preview instead of mini cards 2025-04-10 11:45:50 -05:00
Andy Smith 5cb7643274 Merge branch 'main' into btn-dropdown
* main: (21 commits)
  Migration to migrate URLs after renaming bubbles => cards
  Remove migration
  Restore bubbles.css since some styles are used
  Fix issues with styling card__ components
  Remove bubbles.css
  Fix renames that the scripts missed
  Reorganize templates to remove cards/cards redundancy
  Rename bubbles => cards
  Safari sure loves outlines
  Use a number field, and improve focus styles
  Fix boosting via number input
  Embed additional video formats
  Fix that notifications weren't marked as read
  Fix tray item position
  Update House to bring patch for history restoration error
  Tighten up
  Restore additional missing routes removed in c0f3ff46d7
  Retore route removed in c0f3ff46d7
  Fix visual regression in popup menus
  Perma cards should not always be 100% width
  ...
2025-04-09 14:17:39 -05:00
Andy Smith 7b8ed815cd Address PR feedback 2025-04-09 14:09:08 -05:00
Jorge Manrubia b035c8506e Fix issues with styling card__ components 2025-04-09 15:10:48 +02:00
Jorge Manrubia 221bbb3247 Fix renames that the scripts missed 2025-04-09 14:56:59 +02:00
Jorge Manrubia 6f00e1a79a Reorganize templates to remove cards/cards redundancy 2025-04-09 14:53:46 +02:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Jason Zimdars df408bfd03 Use a number field, and improve focus styles 2025-04-08 16:20:02 -05:00
Jason Zimdars f6288ca026 Fix boosting via number input
- Regression in c06802856e which moved text field outside of form element
2025-04-08 16:19:40 -05:00
Andy Smith 22ff4ee18c Cleanup, phew! 2025-04-08 16:17:05 -05:00
Andy Smith ab88f5549e Working with longer text 2025-04-08 16:09:53 -05:00
Andy Smith 9975ed96f4 WIP: Partially working 2025-04-08 16:01:45 -05:00
Jason Zimdars f58c6792e0 Fix that notifications weren't marked as read
- Move create template into `/bubbles`
- Looks like this file was missed when refactoring `readings` under `bubbles` in 23892296da
2025-04-08 15:50:01 -05:00
Andy Smith d6b985b8ef Basic, non-animated version 2025-04-08 14:23:45 -05:00
Andy Smith 1715e9a9ee WIP 2025-04-08 10:52:20 -05:00
Jason Zimdars 7a545f5afd Tighten up 2025-04-07 21:48:17 -05:00
Andy Smith 8bcd5394a3 Remove unused class and markup 2025-04-07 15:53:53 -05:00
Andy Smith 620c0b885a Position "close as" dialog 2025-04-07 15:49:36 -05:00
Jason Zimdars c3c4823c95 Fix visual regression in popup menus 2025-04-07 15:44:38 -05:00
Andy Smith d992ba7ede Perma cards should not always be 100% width 2025-04-07 15:01:06 -05:00
Andy Smith e9726c481a WIP 2025-04-07 14:50:24 -05:00
Andy Smith e8f85df720 Merge branch 'main' into cascade-layers-2
* main: (104 commits)
  Default collection permissions to "all access"
  dep: update active_record-tenanted to 8758240b
  dep: bump Rails to 32d96235
  Test for `Bubbles::RecoversController`
  Move readings under bubbles and out of double nesting
  Move bubble stagings out from double nesting
  Correct alpha ordering
  Fix indention
  Move bubble recovery out from double nesting
  Move bubbles publish out from the double nesting
  Move bubble pops out from double nesting
  Move controller to delete bubble image out from double nesting under bucket
  Revert "Scope searches by user"
  Scope searches by user
  Few more lazy loading avatars!
  Another lazy loading point
  Remove double nesting under bubbles for engagement
  Lets just preload all avatars for now
  No need for an array when there is only one dependency
  Scope data by account
  ...
2025-04-07 14:15:55 -05:00
David Heinemeier Hansson 23892296da Move readings under bubbles and out of double nesting 2025-04-07 14:06:56 +02:00
David Heinemeier Hansson 3b32b40264 Move bubble recovery out from double nesting 2025-04-07 13:57:00 +02:00
David Heinemeier Hansson 481be72162 Move bubbles publish out from the double nesting 2025-04-07 13:55:12 +02:00
David Heinemeier Hansson ce0c6146be Move bubble pops out from double nesting 2025-04-07 13:45:51 +02:00
David Heinemeier Hansson c60b86cbaa Move controller to delete bubble image out from double nesting under bucket 2025-04-07 13:43:51 +02:00
Jorge Manrubia 93b9f08d58 Merge pull request #373 from basecamp/engagement-nesting
Remove nesting under "bucket" for engagements
2025-04-07 13:35:18 +02:00
David Heinemeier Hansson 86a360f6a0 Few more lazy loading avatars! 2025-04-07 13:32:10 +02:00
David Heinemeier Hansson 7e9b851f64 Another lazy loading point 2025-04-07 13:31:14 +02:00
Jorge Manrubia e4f7837ebe Remove double nesting under bubbles for engagement 2025-04-07 13:30:31 +02:00
David Heinemeier Hansson 8e0394a090 Lets just preload all avatars for now
They are small, they cache well, scrolling will be less jittery. Small
cost in bandwidth for that.
2025-04-07 13:29:59 +02:00
David Heinemeier Hansson 84c0ec8a35 No need for an array when there is only one dependency 2025-04-07 13:23:16 +02:00
Jorge Manrubia a7aae833d1 Extract helper with fallback for the "go to back" and use consistently 2025-04-07 11:28:03 +02:00
Jorge Manrubia a0579f7b6f Inject a span with a class with the value so that we can style it
https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008854
2025-04-07 10:46:24 +02:00
Jorge Manrubia 8e01a277ad Add daysago formatter and extract common helper to reuse with indays formatter 2025-04-07 10:46:22 +02:00
David Heinemeier Hansson 26c123c41c Template dependency should be closest to direct use 2025-04-06 21:05:28 +02:00
David Heinemeier Hansson c06802856e Move boosts under bubbles
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
David Heinemeier Hansson d925c64c59 Remove anemic partial 2025-04-06 20:07:21 +02:00
David Heinemeier Hansson 4fd1472fae Move bubble watch out from the needless bucket nesting 2025-04-06 19:22:40 +02:00
David Heinemeier Hansson 352ba6e05e No longer need the turbo frame designation as this isnt wrapped in a frame 2025-04-06 19:17:26 +02:00
David Heinemeier Hansson 084c4d8948 Spacing and indention 2025-04-06 13:50:15 +02:00
David Heinemeier Hansson 7fe87bfce5 This neednt be a turbo frame
Just because we are targeting something with a stream update does not
mean it needs to be a frame. The frame is only necessary when there is
lazy loading or we are creating a closed update loop.
2025-04-06 13:47:27 +02:00
David Heinemeier Hansson 7900c475e9 This is going to churn too much
Depends directly on the Current.account. If we need something like this,
we need a much more narrow key.
2025-04-06 13:32:30 +02:00
David Heinemeier Hansson a58fcd3123 Nicer API 2025-04-06 13:26:10 +02:00
David Heinemeier Hansson ee22e69e6e Move taggings to bubbles 2025-04-05 22:19:12 +02:00
David Heinemeier Hansson 540316e639 Move taggings under bubbles 2025-04-05 21:54:48 +02:00
David Heinemeier Hansson 5134985418 Simplify the assignments flow
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.

This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
David Heinemeier Hansson 77f412f875 Cache is going to churn too frequently to matter
Anything that touches the bucket, and thats almost everything, will
churn the cache. This is already hidden behind a turbo frame, so thats
enough to get it out of the rendering hot path.
2025-04-05 16:23:47 +02:00
David Heinemeier Hansson 64c00aea30 Extract helper for bubble_assignee_checkbox 2025-04-05 16:20:31 +02:00