Commit Graph

178 Commits

Author SHA1 Message Date
Jason Zimdars 5aa2e5016d Tighten filter input 2025-10-03 18:02:10 -05:00
Jason Zimdars d591166f01 Merge pull request #1212 from basecamp/column-perma
Column perma
2025-10-03 16:09:42 -05:00
Jorge Manrubia 711609bd51 Remove cache for the settings form
It is sensitive to the screen, it is causing trouble and it is not really justified

https://fizzy.37signals.com/5986089/cards/2159
2025-10-03 15:54:40 +02:00
Jorge Manrubia 4527dcbeda Remove unnecessary filtering code
After removing collections from the filtering menu, there was quite a good cleanup here pending
2025-10-03 10:56:34 +02:00
Jason Zimdars 159a96a339 Formatting 2025-10-02 14:31:14 -05:00
Jason Zimdars 6c06da6624 Fix missing close bracket from merge 2025-10-02 14:31:07 -05:00
Jason Zimdars 4ab2d971f9 Merge branch 'main' into collections-filter
* main: (24 commits)
  Move load-balancer to fizzy-lb-101
  Add otel_collector accessory for load balancer
  Fix: this was getting idiomorph confused as it was being invoked on many subtree elements
  Keep column popups during page refreshes
  Don't render next link unless there is more activity
  Live updates for the collection perma
  Keep filter panel during page refreshes
  Add pagination to the list of filtered cards
  Use frame based pagination for the users timeline too
  Use frame-based pagination for the activity timeline
  Don't broadcast updates of cards unless published
  Live updates for the timeline
  Make permanent to avoid losing menu on page refreshes
  Use the new required attribute that now Lexxy supports
  Use controller to disable empty comment submit
  Dynamic height for pins based on viewport height
  Position lexxy language picker
  Replace old link with proper collection path
  No longer needed
  Prevent card bubbles getting clipped in grid layout
  ...
2025-10-02 14:26:45 -05:00
Jorge Manrubia dbc2f47f80 Keep filter panel during page refreshes 2025-10-02 15:58:27 +02:00
Jorge Manrubia 6b10d23fa9 Fix: deselect collections in the collections filter 2025-10-02 14:24:57 +02:00
Jorge Manrubia a198cb1e27 Make permanent to avoid losing menu on page refreshes 2025-10-02 14:04:05 +02:00
Jorge Manrubia 2f38cb3ecd Wire up collection filtering: it should be performed in the generic cards view 2025-10-02 10:30:32 +02:00
Jason Zimdars e046227ebc No need for a prefix here 2025-10-01 16:15:15 -05:00
Jason Zimdars 69a8e41ff7 Fix link 2025-10-01 15:58:35 -05:00
Jason Zimdars 7e43cc3ab4 Stub collections filter UI 2025-10-01 15:38:32 -05:00
Jason Zimdars a1e650fb50 Remove filtering checkboxes, replace with icon; modify icon 2025-10-01 13:58:15 -05:00
Jason Zimdars aca06d4fdf Don't break inside this clause 2025-10-01 13:38:32 -05:00
Jason Zimdars 113f8f299d Remove note about selection 2025-10-01 13:37:48 -05:00
Jason Zimdars 8627f8829f Prefer single key hotkeys
We'll still support cmd/ctrl + J for legacy muscle memory but new
customer should just use `J`
2025-10-01 13:24:29 -05:00
Jorge Manrubia 0347806ce1 Fix: Keep the previous filtering when navigating back from cards
https://fizzy.37signals.com/5986089/cards/1760/edit

This also adds a proper resource for filtered collections, instead of changing the URL to cards for filtering cards.
2025-09-30 15:48:56 +02:00
Jorge Manrubia e97c085a57 Fix: proper filtering by collection in the collection perma
https://fizzy.37signals.com/5986089/cards/2020
2025-09-29 18:42:29 +02:00
Jorge Manrubia 2d029d075e Fix: include collection filter in the collection perma 2025-09-29 16:59:43 +02:00
Jorge Manrubia 859a016a2e No need to use extra method here 2025-09-29 13:03:54 +02:00
Jorge Manrubia 24f1394ca3 Remove workflows code, remove more unused code 2025-09-28 20:39:47 +02:00
Jorge Manrubia 4e05992e54 triaging should make sure the card gets resumed 2025-09-26 19:39:34 +02:00
Jorge Manrubia b94af96e8f Merge branch 'collapsing-columns' into collapsing-columns+domain
# Conflicts:
#	app/helpers/cards_helper.rb
2025-09-26 18:48:48 +02:00
Jorge Manrubia 0e8bf9b03f Link to the new collection perma 2025-09-26 18:31:01 +02:00
Jorge Manrubia 6ec394434c Make filters work with the new columns screen 2025-09-26 18:06:35 +02:00
Andy Smith 684af83c0e Wider filters input 2025-09-24 11:32:43 -05:00
Jorge Manrubia 0d03cd1ec0 Fix changed ID 2025-09-22 13:15:31 +02:00
Jorge Manrubia 72525e7d92 Make toggle visibility sensible to filters too 2025-09-22 13:05:33 +02:00
Jorge Manrubia ce80c843d0 Several fixes for saving filters
- Unify terms with the settings form so that terms are saved normally in the same form.
- Fix filter normalization since it was sometimes failing to match the saved filters due to using quotes around number strings.
2025-09-22 12:55:19 +02:00
Jorge Manrubia 717f921a73 Refresh save filter toggle when changing filter 2025-09-19 18:37:02 +02:00
Jorge Manrubia 17c6009a3a Keep collection_id filter when filtering 2025-09-19 17:51:58 +02:00
Jorge Manrubia 3b83d218ea Restore filter targets so that search works! 2025-09-19 17:42:48 +02:00
Jorge Manrubia 64b46d37e4 Toggle filters in the hey menu too
This also fixes a problem where the label in the menu for the filters was wrong
2025-09-19 16:52:13 +02:00
Jorge Manrubia f77aef968b Don't submit empty params with the filter
They result in garbled URLs
2025-09-19 16:51:11 +02:00
Jorge Manrubia d13dd58a78 Make filter toggle save/destroy work 2025-09-19 16:51:11 +02:00
Jorge Manrubia ced51c2cac Use single form for terms and settings 2025-09-19 16:51:11 +02:00
Jorge Manrubia 33a3d856b5 Add prefix for multi select labels 2025-09-19 16:51:11 +02:00
Jorge Manrubia 2d575737b5 Fixes for multi selection 2025-09-19 16:51:11 +02:00
Jorge Manrubia 81cae9cbe0 Fix default handling 2025-09-19 16:51:11 +02:00
Jorge Manrubia cb7d260545 Multi selection combos working 2025-09-19 16:51:11 +02:00
Jorge Manrubia 8d2a191a91 manage a hidden template instead since this will come handy when dealing with multiple selection 2025-09-19 16:51:11 +02:00
Jorge Manrubia 7a916c295a Controlling the manage filter section with JS too 2025-09-19 16:51:11 +02:00
Jorge Manrubia 408374ff33 Submitting form from the new combos 2025-09-19 16:51:11 +02:00
Jorge Manrubia 66b0a4f2e7 Adapt indexed_at too 2025-09-19 16:51:11 +02:00
Jorge Manrubia 7b60c6959a WIP with a combobox controller to handle filters with pure JS 2025-09-19 16:51:11 +02:00
Jorge Manrubia e33f1a6333 Use existing method 2025-09-19 16:51:11 +02:00
Andy Smith 85cddb91f0 Remove the search option from the nav 2025-09-18 16:43:39 -05:00
Andy Smith ec0433d721 Remember localStorage state after filtering 2025-09-16 14:46:21 -05:00