75a46356cc
Merge branch 'main' into consolidate-cards
...
* main:
Show more of the summary before truncating
Improve event summaries
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
Show more of the summary before truncating
Improve event summaries
Remove shadows from notifications you can't see
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
2025-04-11 15:38:57 -05:00
3ff938f174
Show more of the summary before truncating
2025-04-11 13:21:47 -05:00
188ebc3110
Improve event summaries
2025-04-11 13:21:47 -05:00
5e608d33e1
Add this for debugging empty event cards
2025-04-11 13:21:47 -05:00
d3584adf35
Some actions shouldn't be available to closed cards
2025-04-11 13:21:47 -05:00
89f76a080a
Nicer spacing when the large button isn't present
2025-04-11 13:21:47 -05:00
c5fc847372
Update card-color in a couple more places
2025-04-11 13:21:47 -05:00
a76488fd49
Don't show the engagement toggle on closed cards
2025-04-11 13:21:47 -05:00
26106f12e4
Remove shadows from notifications you can't see
2025-04-11 13:16:29 -05:00
d678ce1f60
Cleanup after merge
2025-04-11 12:43:16 -05:00
c853d3c570
Merge branch 'main' into consolidate-cards
...
* main: (31 commits)
Style drafted cards
Considering needs to include drafted cards or you'll never be able to see them
This item makes no sense until it's saved
Tighten engagement switch design, only display it for published cards
Needed to come first
In order of appearance
Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones
Move comments under cards
Fix indention
Refresh timers when morphing happens
Extract helper for card articles, use classes to determine when to show golden status
Only consider golden those cards in "doing"
Fix recently completed order for good!
Place recently closed cards first
Monkey patch a prepend_order method
Rename inconsistency: go with goldness
Touch
Use gild/ungild
Format
Fix test
...
2025-04-11 12:43:05 -05:00
29fbfe3b9f
Remove comments
2025-04-11 12:27:15 -05:00
df96ee80fa
Style drafted cards
2025-04-11 12:21:14 -05:00
5997ef2c70
Considering needs to include drafted cards or you'll never be able to see them
2025-04-11 12:08:05 -05:00
76336a52d6
This item makes no sense until it's saved
2025-04-11 11:56:26 -05:00
ee8559343a
Tighten engagement switch design, only display it for published cards
2025-04-11 11:50:09 -05:00
09dd073cf7
Record lookup works here
2025-04-11 18:47:11 +02:00
51341c36d1
New partial isnt cached
2025-04-11 18:45:44 +02:00
c8fe83e8f3
Indention
2025-04-11 18:43:52 +02:00
6effc1568f
No need for a separate body partial
2025-04-11 18:41:26 +02:00
6f1c802292
Content being required via UI and db constraint is enough
...
We are not using/displaying model validations anywhere
2025-04-11 18:28:23 +02:00
9ecb85013b
Spacing
2025-04-11 18:25:49 +02:00
442fe6087c
Use form object so we dont have to manually set the text_field name
2025-04-11 18:25:24 +02:00
aefae634c3
Anemic params method
...
Wont ever get reused here since there is no update
2025-04-11 18:21:44 +02:00
8d36f13fab
No longer needing that extra local
2025-04-11 18:20:28 +02:00
06a636bd8d
Did need to separate them out for the broadcast
2025-04-11 18:19:33 +02:00
5fa8007397
Loaded directly in the partial
2025-04-11 18:19:10 +02:00
f0aa48b75d
Indention
2025-04-11 18:13:29 +02:00
fadf167630
Avoid needing to pass an extra variable to the reactions partial
...
Thanks to inverse_of, there's no extra query getting the comment from
the reaction.
2025-04-11 18:12:52 +02:00
4a8398e318
Remove unused partials
2025-04-11 11:11:31 -05:00
227d5a8757
It is both reacting and reactions
...
So stick with the simpler dom id scope
2025-04-11 18:10:26 +02:00
c9b1d6d868
Style pinned cards
2025-04-11 11:09:04 -05:00
73f1989861
Fix indention
2025-04-11 18:05:50 +02:00
3b711161d7
No need for a manual dom_id
...
turbo_frame_tag can do this directly
2025-04-11 18:04:21 +02:00
1145260890
No idea why this was here
2025-04-11 18:01:21 +02:00
5aa2b7da84
No need to cache individual reactions
...
Both because the reactions partial actually depends on multiple
variables but also because its just not worth it when we are caching the
comment.
2025-04-11 17:58:48 +02:00
7861b7c087
Just open one turbo stream per card
...
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
263b3336db
Add missing CR
2025-04-11 17:50:53 +02:00
0954cfe008
Add CR
2025-04-11 17:48:01 +02:00
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
eec76d0d4f
Use modern params#expect
2025-04-11 17:43:31 +02:00
f9bb779b61
Use local vars so ivar dependency is only from before actions
2025-04-11 17:42:30 +02:00
3ecf150636
Use proper access control
...
Otherwise you could react to any comment on the entire account. And then
you might as well just do Comment.find.
2025-04-11 17:41:28 +02:00
dc4e50fba5
Move messages partial under cards
2025-04-11 17:34:49 +02:00
5084bbf3b7
Use modern params#expect syntax
2025-04-11 17:01:19 +02:00
8a4a087a00
Fine to let destroying something destroyed be a no-op
...
Would be an edge-casey race condition, but its possible
2025-04-11 17:00:08 +02:00
256d536009
Always use _path unless we are changing domains
2025-04-11 16:58:56 +02:00
16c1583133
Usually the order comes last
2025-04-11 16:58:47 +02:00
5ecf0ce3f6
Stick with one term
2025-04-11 16:57:03 +02:00
a8aa2c4f80
Clean up the controller
2025-04-11 16:49:55 +02:00
Andy Smith