Commit Graph

460 Commits

Author SHA1 Message Date
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Jorge Manrubia 2106fb464a Revert "Scope searches by user"
This reverts commit 47552dd8d7.
2025-04-07 13:42:57 +02:00
Jorge Manrubia 47552dd8d7 Scope searches by user 2025-04-07 13:42:27 +02:00
Jorge Manrubia 16e8041524 Add unique constraint for keeping tags unique on a per-account basis 2025-04-07 11:36:34 +02:00
Jorge Manrubia f403ed070c Downcase tag titles 2025-04-07 10:43:23 +02:00
Jorge Manrubia 99584a17f4 Ignore case when trying to match tags 2025-04-07 06:01:43 +02:00
David Heinemeier Hansson eb0614c44f Use a more ergonomic API for watching
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson 5e78a1dab1 Make it clearer that this takes a title string not a tag object 2025-04-06 13:28:52 +02:00
David Heinemeier Hansson a58fcd3123 Nicer API 2025-04-06 13:26:10 +02:00
David Heinemeier Hansson cdd78b41ee Tag exclusively by title 2025-04-06 13:19:22 +02:00
David Heinemeier Hansson ee22e69e6e Move taggings to bubbles 2025-04-05 22:19:12 +02:00
Jorge Manrubia 0e3f756a27 Merge pull request #351 from basecamp/close-with-label
Close as...
2025-04-04 15:09:47 +02:00
Jorge Manrubia be4a738f1d Make reason not null 2025-04-04 15:06:43 +02:00
Jorge Manrubia f960b3fc83 Add tests 2025-04-04 13:35:54 +02:00
Jorge Manrubia de8a1120eb Move constant to new concern to group labels together 2025-04-04 12:24:11 +02:00
Jorge Manrubia afcc65d6fb Create default pop reasons when creating accounts 2025-04-04 12:10:28 +02:00
Jorge Manrubia 1f4be8ed67 Only pop bubbles in a considering state 2025-04-04 12:04:54 +02:00
Jorge Manrubia 6f93d4b72a Add system to auto reconsider inactive bubbles after 30 days 2025-04-04 10:04:39 +02:00
Jorge Manrubia 08cb69aca5 Replace auto_pop_at with generic last_activity column
so that we can use it in other scenarios
2025-04-04 09:45:56 +02:00
Jorge Manrubia dbae700554 Merge pull request #346 from basecamp/two-columns-refactor
Refactor collections perma + support for doing/considering
2025-04-04 08:29:17 +02:00
Jorge Manrubia 05fc73e2ae Merge pull request #334 from basecamp/user-admins
Add admin role and animate admin toggle
2025-04-04 08:29:03 +02:00
Jason Zimdars 1ea70d7d3b Merge branch 'main' into two-columns-refactor
* main:
  Fix image icons
  Revert "Merge pull request #345 from basecamp/cascade-layers"
  Fine tune notifications states
  Remove empty helper
  Use an icon for the button
  Show button on collection page and notif settings
  Add involvement types to accesses
  Extract a couple components
  Add cascade layers to all CSS files
2025-04-03 19:30:37 -05:00
Jorge Manrubia 2af619176e Format 2025-04-03 18:16:21 +02:00
Jorge Manrubia 0c458ef893 Add tests to make sure popping and engagement play well together 2025-04-03 18:03:34 +02:00
Jorge Manrubia cfe91c25c9 Add admin role, make sure only admins can remove and promote other users 2025-04-03 17:43:29 +02:00
Jorge Manrubia 7cb2a476c4 Fix tests 2025-04-03 17:41:55 +02:00
Kevin McConnell 0820badcc3 Add involvement types to accesses
This provides a way to set the level of involvement that a user has with
a collection, and from which we determine the level of notifications to
send. Users can be access-only, watching, or being notified about
everything.

If you're access-only, you won't get an notifications. If you're
watching, you'll only get notifications for the items you're watching
(which includes the items you've been assigned, have commented on, etc).
If you're set to everything you'll get notifications about all activity
in that collection.

This change replaces our previous concept of subscriptions. Where
previously you'd subscribe to a collection to get notifications in it,
now you'll simply set the notification level on your access.
2025-04-03 16:35:13 +01:00
Jorge Manrubia dc527e8f8a Format 2025-04-03 15:03:31 +02:00
Jorge Manrubia ac0baed663 Add some missing tests 2025-04-03 14:46:35 +02:00
Jorge Manrubia 4fcb5a9c85 Add basic models for tracking engagement 2025-04-03 12:11:06 +02:00
Jason Zimdars bbcbb77082 Update tests 2025-03-27 17:09:05 -05:00
Kevin McConnell 3ea7da26ab "Stalled" not "Stale"
The latter sounds like old bread.
2025-03-27 12:22:55 +00:00
Kevin McConnell 47156c42e0 Add a sort order to represent "staleness" 2025-03-27 10:41:03 +00:00
Mike Dalessio 506f74144b Touch Account when adding or removing a Tag
so we can properly cache the tags partial using account as part of the key.
2025-03-24 16:48:11 -04:00
Mike Dalessio 473703df3d Invalidate the bubble cache when the bucket name changes
by including the bucket name as part of the bubble cache key.

ref: https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008709

Co-authored-by: Kevin McConnell <kevin@37signals.com>
2025-03-20 12:46:23 -04:00
Jason Zimdars 264d78b21a Update test 2025-03-19 16:37:06 -05:00
Kevin McConnell e9ae2772e4 Add tests to validate notification recipients 2025-03-18 17:46:57 +00:00
Mike Dalessio 2c87c2fb15 Update schema files and fix some trivial test failures. 2025-03-18 09:14:16 -04:00
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Mike Dalessio 3e374f4661 fix: Send assignment notifications only to the assignee(s)
ref: https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008619
2025-03-13 12:16:47 -04:00
Mike Dalessio e0fa376d4f Update scoreable to return a large positive number when score==0 (#290)
Avoid infinite activity score orders

Items with a zero activity score were getting an activity sorting score
of -infinity, because we base the value on log2(score). Adjusting the
calculation avoids this edge case, by always basing the sorting score on
a non-zero number.

---------

Co-authored-by: Kevin McConnell <kevin@37signals.com>
2025-03-11 07:39:17 -04:00
Kevin McConnell 16a80ff3a6 More dynamic activity scores
This introduces a more dynamic system of activity scoring, to improve
the way bubbles "bubble up" due to their activity. There are a few
different parts we can tune here, and it's likely we'll need to make
adjustments once we get a feel for how this works in practice.

The basic idea here is:

- We assign points for certain types of event that happen on a bubble. A
  boost gets 1 point, a comment gets 10 points, and so on.
- These points decay over time, at a rate of 50% per day. So old
  activity is worth much less than new activity. Bubbles should rise up
  quickly when acted upon, bit will float back down if left idle.
- Some comments can score higher than others: the first comment from
  each person on a bubble is worth more (20) because it signals that
  more people are getting involved; and comments that follow a comment
  by a different author are also worth more (15) because that signals
  there's ongoing conversation between people, not just a series of
  notes being left by one individual.

In terms of implementation, we persist the score on the bubble
whenever it changes, but we handle the decay on the client side. That
allows us to cache the bubble representation without having to
continually change it while its activity decays.

We also keep a separate `activity_score_order` attribute on the model.
This can be used to sort the bubbles in order of "most active", without
having to think about the decay.
2025-03-05 17:16:31 +00:00
Kevin McConnell eaf4903afc Formatting 2025-02-28 11:48:29 +00:00
Kevin McConnell 93474002b7 Add test for watchers_and_subscribers 2025-02-27 16:27:12 +00:00
Kevin McConnell f54119f477 Add missing test 2025-02-26 10:58:56 +00:00
Kevin McConnell 84d06c7f0b Creators watch their own bubble by default 2025-02-26 10:53:03 +00:00
Kevin McConnell f22742c431 watched_by? should reflect subscriptions too 2025-02-26 10:53:03 +00:00
Kevin McConnell d29e999552 Make Buckets subscribable 2025-02-26 10:53:03 +00:00
Kevin McConnell 6157d8b4bd Start watching when participating on a bubble
If you're added as an assignee, or if you comment, then your watching
preference will be toggled on.
2025-02-26 10:53:03 +00:00
Kevin McConnell 2d0c9d309b All notifiers use same recipients 2025-02-26 10:53:03 +00:00