8d7d8e76f2
Avoid # since it confuses screen readers
2025-04-07 12:45:53 +02:00
a7aae833d1
Extract helper with fallback for the "go to back" and use consistently
2025-04-07 11:28:03 +02:00
598d933565
Merge pull request #369 from basecamp/unique-tags
...
Ignore case when matching tags
2025-04-07 10:47:38 +02:00
a0579f7b6f
Inject a span with a class with the value so that we can style it
...
https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008854
2025-04-07 10:46:24 +02:00
8e01a277ad
Add daysago formatter and extract common helper to reuse with indays formatter
2025-04-07 10:46:22 +02:00
f403ed070c
Downcase tag titles
2025-04-07 10:43:23 +02:00
99584a17f4
Ignore case when trying to match tags
2025-04-07 06:01:43 +02:00
2e917b90a2
Fix the DaysAgoFormatter output to say "days ago"
...
and not "in N days" 😅
2025-04-06 22:08:51 -04:00
565ee0f548
Dont have to spell this out when there are no other formats
2025-04-06 21:09:49 +02:00
26c123c41c
Template dependency should be closest to direct use
2025-04-06 21:05:28 +02:00
c06802856e
Move boosts under bubbles
...
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
d925c64c59
Remove anemic partial
2025-04-06 20:07:21 +02:00
4fd1472fae
Move bubble watch out from the needless bucket nesting
2025-04-06 19:22:40 +02:00
eb0614c44f
Use a more ergonomic API for watching
...
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
352ba6e05e
No longer need the turbo frame designation as this isnt wrapped in a frame
2025-04-06 19:17:26 +02:00
95cd60b919
Style
2025-04-06 18:49:19 +02:00
78c82584cf
Reads nicer now that we are using long form operations
2025-04-06 18:45:58 +02:00
21211cedca
These really are anemic too
2025-04-06 18:16:47 +02:00
cc0c88d999
Remove anemic finder
2025-04-06 18:15:13 +02:00
084c4d8948
Spacing and indention
2025-04-06 13:50:15 +02:00
7fe87bfce5
This neednt be a turbo frame
...
Just because we are targeting something with a stream update does not
mean it needs to be a frame. The frame is only necessary when there is
lazy loading or we are creating a closed update loop.
2025-04-06 13:47:27 +02:00
7900c475e9
This is going to churn too much
...
Depends directly on the Current.account. If we need something like this,
we need a much more narrow key.
2025-04-06 13:32:30 +02:00
eb047aec4d
Neater
2025-04-06 13:30:20 +02:00
b8bcfdee40
This is not just param extraction, we sanitize too
2025-04-06 13:29:43 +02:00
5e78a1dab1
Make it clearer that this takes a title string not a tag object
2025-04-06 13:28:52 +02:00
a58fcd3123
Nicer API
2025-04-06 13:26:10 +02:00
cdd78b41ee
Tag exclusively by title
2025-04-06 13:19:22 +02:00
ee22e69e6e
Move taggings to bubbles
2025-04-05 22:19:12 +02:00
540316e639
Move taggings under bubbles
2025-04-05 21:54:48 +02:00
5134985418
Simplify the assignments flow
...
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.
This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
6990f1eb05
Alpha sort regardless of capitalization
2025-04-05 16:27:22 +02:00
77f412f875
Cache is going to churn too frequently to matter
...
Anything that touches the bucket, and thats almost everything, will
churn the cache. This is already hidden behind a turbo frame, so thats
enough to get it out of the rendering hot path.
2025-04-05 16:23:47 +02:00
64c00aea30
Extract helper for bubble_assignee_checkbox
2025-04-05 16:20:31 +02:00
e825f1d33f
No need for the partial indirection
2025-04-05 16:06:44 +02:00
d0953d6f87
Pull assignments out of the double nesting
2025-04-05 15:59:51 +02:00
3b5f8c2e6a
Note the security oddity of finding straight off root
2025-04-05 15:56:12 +02:00
851be126ab
Emphasize where this pin is showing up
2025-04-05 15:55:11 +02:00
ec36e52b25
No longer used
2025-04-05 15:52:15 +02:00
b4c0fec7a6
Move Assignments under Bubble
...
Since that what we are assigning
2025-04-05 15:51:53 +02:00
e69c1bd0a1
Break pins out of the double nesting
...
Its cumbersome and needless
2025-04-05 15:45:16 +02:00
f725a69dee
Let BubbleScoped find its own bucket
...
Then it will be easier to break things that are double nested out of
that nesting.
2025-04-05 15:44:47 +02:00
8708ff04c1
Fix indention
2025-04-05 15:27:40 +02:00
e4c6fe4b55
Shape up pinning API and broadcast in the controller
2025-04-05 15:15:48 +02:00
bfb7ed1216
Move pins to my space
...
We used the my/ space in HEY to reflect anything that was primarily
hinged off Current.user. Good to use here too.
2025-04-05 14:57:24 +02:00
7494dad91e
Drop the toggles scope for taggings as well
2025-04-05 14:20:06 +02:00
384de24132
Get rid of odd toggles concept
...
This is just assignments.
2025-04-05 14:16:04 +02:00
f063116df4
Group related associations together
2025-04-05 13:19:30 +02:00
aefbac9c14
Get rid of single-use and slight awkward model scope
...
Really dont like that raw Arel.sql wrapping that is required.
2025-04-05 13:17:42 +02:00
61dfa5ecce
Spacing
2025-04-05 12:58:56 +02:00
821f4c43d8
Excess CR
2025-04-05 12:49:19 +02:00
Jorge Manrubia