where the closure no longer exists, possibly due to being
reopened.
Previously, fragment caching generally prevented any problems, but if
the cache is busted for any reason (like Andy did in c7eeb56c), then
the previous logic would raise an exception like "undefined method
'reason' for nil".
So, if the closure no longer exists, let's just note that it was
closed, and by who.
* main:
Clear the comments cache
Add context for search screens
Needs changed for both states
Use lighter icon and update asset
Add btn--circle class to user edit form
Organize button variants
Untangle `avatar btn` crossover styles
Remove redundant classes and styles for avatars
Adjust footer line height
Tweak padding
I went with placing htis logic at the command level since it plays well with the composite structure, where you don't know whether you are handling one command or many commands, and you want to aggregate all the errors. I didn't leverage the existing support with rails' model errors because that customizing those message is cumbersome (either i18n or using custom validation logic for everything).
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
* main:
Need to return all collections so it's not blank
Button to add a new filter
Update test for new redirect
Comparing params is fragile, use `id` for saved filters
Update summary tests
Improve summary display in menu
Add keyboard navigation and filtering to quick filters
Copy
Keep stage when clearing
Keep the current filter params after deleting a saved filter so you can change your mind
Update test because we now drop all filters on destroy
New UI for exposing filter options and saving/deleting them
Unnecessary
These aren't actually in the events namespace, use utility class
Andy Smith