9f7bbbef58
Split draft commenting back out to a dedicated concern
2025-04-12 11:05:56 +02:00
27d90abbd6
Reduce the direct knowledge of comments inside the card
2025-04-12 11:04:16 +02:00
b698eefa06
Messageables already have access to the card
2025-04-12 11:00:15 +02:00
24b02c42fd
Comments are dependents of messages, so need to destroy the latter to get the former
2025-04-12 10:59:59 +02:00
60a0360203
Remove more activity scoring related to comments
2025-04-12 10:52:48 +02:00
fb733b9a60
No more tracking commenting as an activity for sorting
...
We are doing away with all the automated activity scoring, but for now
lets just get rid of it for comments.
2025-04-12 10:50:25 +02:00
81f431d946
Comment-specific behavior needs to live in the comment
...
This really is a bit of a tangled mess. Everyone knows everything about
everyone else.
2025-04-12 10:39:56 +02:00
bb64adfd1b
Most important methods first
2025-04-12 10:39:19 +02:00
4d2ba5b432
Use the explicit method for now
2025-04-12 10:27:57 +02:00
80bc1dd163
Reactions dont have any callbacks so can just be deleted
2025-04-12 10:15:38 +02:00
6f3ac772ea
Merge branch 'main' into comments-refactoring
...
* main:
Show more of the summary before truncating
Improve event summaries
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
Show more of the summary before truncating
Improve event summaries
Remove shadows from notifications you can't see
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
Style drafted cards
Considering needs to include drafted cards or you'll never be able to see them
This item makes no sense until it's saved
Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
384e159df9
Merge branch 'noon-commits-11-4-2025'
...
* noon-commits-11-4-2025:
Show more of the summary before truncating
Improve event summaries
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
2025-04-11 13:21:51 -05:00
3ff938f174
Show more of the summary before truncating
2025-04-11 13:21:47 -05:00
188ebc3110
Improve event summaries
2025-04-11 13:21:47 -05:00
5e608d33e1
Add this for debugging empty event cards
2025-04-11 13:21:47 -05:00
d3584adf35
Some actions shouldn't be available to closed cards
2025-04-11 13:21:47 -05:00
89f76a080a
Nicer spacing when the large button isn't present
2025-04-11 13:21:47 -05:00
c5fc847372
Update card-color in a couple more places
2025-04-11 13:21:47 -05:00
a76488fd49
Don't show the engagement toggle on closed cards
2025-04-11 13:21:47 -05:00
be51e63417
Show more of the summary before truncating
2025-04-11 13:20:24 -05:00
8416a17213
Improve event summaries
2025-04-11 13:20:14 -05:00
05b34bc073
Merge pull request #400 from basecamp/notification-shadows
...
Remove shadows from notifications you can't see
2025-04-11 13:18:53 -05:00
26106f12e4
Remove shadows from notifications you can't see
2025-04-11 13:16:29 -05:00
c5bdf851e0
Add this for debugging empty event cards
2025-04-11 13:08:51 -05:00
2934eb03f9
Some actions shouldn't be available to closed cards
2025-04-11 13:04:19 -05:00
0f103afb12
Nicer spacing when the large button isn't present
2025-04-11 12:56:53 -05:00
0c5b875ded
Update card-color in a couple more places
2025-04-11 12:55:11 -05:00
239b0a430d
Don't show the engagement toggle on closed cards
2025-04-11 12:48:24 -05:00
df96ee80fa
Style drafted cards
2025-04-11 12:21:14 -05:00
5997ef2c70
Considering needs to include drafted cards or you'll never be able to see them
2025-04-11 12:08:05 -05:00
76336a52d6
This item makes no sense until it's saved
2025-04-11 11:56:26 -05:00
ee8559343a
Tighten engagement switch design, only display it for published cards
2025-04-11 11:50:09 -05:00
09dd073cf7
Record lookup works here
2025-04-11 18:47:11 +02:00
51341c36d1
New partial isnt cached
2025-04-11 18:45:44 +02:00
c8fe83e8f3
Indention
2025-04-11 18:43:52 +02:00
6effc1568f
No need for a separate body partial
2025-04-11 18:41:26 +02:00
6f1c802292
Content being required via UI and db constraint is enough
...
We are not using/displaying model validations anywhere
2025-04-11 18:28:23 +02:00
9ecb85013b
Spacing
2025-04-11 18:25:49 +02:00
442fe6087c
Use form object so we dont have to manually set the text_field name
2025-04-11 18:25:24 +02:00
aefae634c3
Anemic params method
...
Wont ever get reused here since there is no update
2025-04-11 18:21:44 +02:00
8d36f13fab
No longer needing that extra local
2025-04-11 18:20:28 +02:00
06a636bd8d
Did need to separate them out for the broadcast
2025-04-11 18:19:33 +02:00
5fa8007397
Loaded directly in the partial
2025-04-11 18:19:10 +02:00
f0aa48b75d
Indention
2025-04-11 18:13:29 +02:00
fadf167630
Avoid needing to pass an extra variable to the reactions partial
...
Thanks to inverse_of, there's no extra query getting the comment from
the reaction.
2025-04-11 18:12:52 +02:00
227d5a8757
It is both reacting and reactions
...
So stick with the simpler dom id scope
2025-04-11 18:10:26 +02:00
73f1989861
Fix indention
2025-04-11 18:05:50 +02:00
3b711161d7
No need for a manual dom_id
...
turbo_frame_tag can do this directly
2025-04-11 18:04:21 +02:00
1145260890
No idea why this was here
2025-04-11 18:01:21 +02:00
5aa2b7da84
No need to cache individual reactions
...
Both because the reactions partial actually depends on multiple
variables but also because its just not worth it when we are caching the
comment.
2025-04-11 17:58:48 +02:00
David Heinemeier Hansson