Commit Graph

68 Commits

Author SHA1 Message Date
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Bruno Prieto 10cdb8c1a8 Improve accessibility of comments and reactions 2025-03-14 02:29:44 +01:00
Kevin McConnell 748d09a5f7 Cache comment partial 2025-03-03 17:04:16 +00:00
Kevin McConnell 49fa8b21a6 Move current user check to controller
This is necessary to a) ensure people can't edit/delete comments they
don't own, and b) make the comment partial cacheable.
2025-03-03 17:04:16 +00:00
Kevin McConnell 4d13db0f8b Rename to local-save-controller 2025-02-28 15:13:23 +00:00
Jason Zimdars a0ffbc807f Auto save comments to local storage to prevent losing work 2025-02-26 17:37:49 -06:00
Jason Zimdars 302427f17b This isn't necessary 2025-02-21 10:54:18 -06:00
Jason Zimdars 5beb851904 Whitespace 2025-02-19 11:23:14 -06:00
Jason Zimdars 8b429ddb84 Move method to Reaction class 2025-02-19 10:16:31 -06:00
Jason Zimdars 000bd158eb Reactions on comments 2025-02-18 17:08:56 -06:00
Jason Zimdars d9444f18dd House seems to expect a placeholder value
Fixes that the placeholder would display `null` if you clear the content while editing a comment. See also: https://fizzy.37signals.com/buckets/693169850/bubbles/999008493#comment_994776744
2025-02-13 17:48:37 -06:00
Jason Zimdars 3e5b531d12 Extract into a single-purpose controller 2025-02-13 17:40:18 -06:00
Jason Zimdars 3ee0ce67bb Make it transparent 2025-02-06 14:43:29 -06:00
Jason Zimdars 34bb61c3ea Campfire style comments, fix button 2025-02-06 14:33:08 -06:00
Jason Zimdars 16e62fe121 Fix invisible edit comment button in dark mode 2025-01-31 18:24:57 -06:00
Jason Zimdars 6f351b956c Allow pasting files in comments 2025-01-31 18:07:12 -06:00
Jason Zimdars bd0fb52ffe We no longer color *my* comments, missed this 2025-01-30 15:29:02 -06:00
Jason Zimdars 9ef781dacb Submit comments with command or control + enter 2025-01-30 15:27:15 -06:00
Kevin McConnell b320b72bc6 Use local time helper for comment dates
Also has the advantage you can hover to see the time.
2025-01-30 17:10:58 +00:00
Jason Zimdars e7819328e8 A little janky but we probably don't want to navigate when you're typing a comment 2025-01-14 17:00:32 -06:00
Jason Zimdars 6a40256969 Prevent back navigation when cancelling comment edits 2025-01-14 16:57:29 -06:00
Kevin McConnell 93536c3e41 Don't reload entire page when creating comment 2025-01-07 14:47:31 +00:00
Kevin McConnell 4a4b4113c8 Don't use a new request for every comment 2025-01-07 14:14:12 +00:00
Jason Zimdars 0a6b5571c0 Merge pull request #167 from basecamp/users
Account users
2024-12-19 11:11:41 -06:00
Jason Zimdars 114e651d25 Link to profile 2024-12-18 16:40:41 -06:00
Jose Farias 0d2e4ed604 Merge branch 'main' into house
* main:
  Add hotwire-spark
  Fix for Safari which doesn't support `field-sizing: content`
  Add button and action to delete a bubble
  Indicate draggable element
  Stub draggable collection size divider
  Make close and trash more distinct
2024-12-18 16:27:07 -06:00
Jason Zimdars fdf93b2bc0 Make close and trash more distinct 2024-12-17 10:10:31 -06:00
Jose Farias 9ce4a73214 Use MD for comment CRUD 2024-12-17 00:36:37 -06:00
Jose Farias fdea6d4248 Merge branch 'main' into house
* main:
  Update test
  Wire up comment deletion
  Whitespace
  Wire up editing comments
  Open the title field for editing after creating a new bubble
2024-12-17 00:34:00 -06:00
Jason Zimdars 33d2d098f1 Wire up comment deletion 2024-12-16 17:46:01 -06:00
Jason Zimdars bcc57d66dd Whitespace 2024-12-16 17:29:07 -06:00
Jason Zimdars 4644fe43ee Wire up editing comments 2024-12-16 17:28:27 -06:00
Jose Farias a74dd7a081 Merge branch 'main' into house
* main:
  Adjust position of settings buttons
  Actually, no need for a max-size, just let it grow
  Improve comment form design
  Same style as combobox pop-ups
  Ensure bubbles are clickable anyplace in windshield
  Deal with truncation in the list layout, too
  Ensure tags don't affect the bubble shape or spill out of the container
  Style pop-up UI for selecting assignments and tags
  Adjust position now that bubbles won't be so vertical
  Fix that bubbles could collapse in some situations
  dep: bump rexml to address dependabot alert
  dep: bump rails to edge
2024-12-09 10:39:09 -06:00
Jason Zimdars 4d383c7a77 Improve comment form design 2024-12-06 17:01:25 -06:00
Jose Farias 2b9c4d9b71 Sanitize rendered markdown 2024-11-29 18:00:50 -06:00
Jose Farias 0e8d4104f8 Implement lightbox 2024-11-29 15:52:45 -06:00
Jose Farias ce3db053c2 Sanitize comment html 2024-11-29 14:34:39 -06:00
Jose Farias 45e94e4484 Support search on markdown fields 2024-11-29 14:28:37 -06:00
Jose Farias d556e21287 Use House for MD comments 2024-11-27 18:59:15 -06:00
Jason Zimdars 43fa91fc05 Needs a little structure 2024-11-22 14:19:50 -06:00
Jason Zimdars 8d41b3e410 Pull back comment decoration 2024-11-22 13:51:46 -06:00
Jose Farias 79869858da Pull out new_comment_placeholder helper 2024-10-28 10:23:40 -06:00
Jose Farias e6622a1e7d Use targets for created-by-current-user-controller 2024-10-28 10:14:39 -06:00
Jose Farias 0727414017 Lean into delegated types APIs 2024-10-27 17:39:30 -06:00
Jose Farias 8233254de3 Make comments cache-safe 2024-10-23 18:58:10 -06:00
David Heinemeier Hansson 53afd0d93c Note that Current.user cannot be referenced within partials that must be cached 2024-10-19 17:51:09 -07:00
Jose Farias f4b5210ca1 Spike persisted filters 2024-10-16 16:41:11 -06:00
Jose Farias 1d6acb6119 Stop caching threads — YAGNI 2024-10-12 23:23:12 -06:00
Jose Farias ec7fc75054 Spike events system 2024-10-11 20:14:09 -05:00
Jason Zimdars 9e28359587 Add proper avatars for users 2024-10-04 10:54:11 -05:00