Commit Graph

2143 Commits

Author SHA1 Message Date
Andy Smith ff6464ffef Stub out closing soon badge 2025-04-14 17:02:50 -05:00
Andy Smith a88264ed0a Merge branch 'main' into consolidate-cards
* main: (94 commits)
  Source order seems to be significant
  Use `card.title`
  Nicer flow
  Fix string interpolation
  Fix constant
  Use record lookup
  Always use sole
  Explained less and extracted nothing of value
  Weird double negative
  Remove anemic and indirect method that explained nothing
  Can use record lookup for workflows
  Access control has already been done through the card
  Style
  Use _path in all cases where we are not potentially changing the domain
  Clearer
  Spacing
  Get rid of card_title
  Join the two users controllers but split out role setting
  Ensure user is returned
  We are not using the parameter
  ...
2025-04-14 09:40:22 -05:00
David Heinemeier Hansson 5b524254b9 Merge pull request #403 from basecamp/commit-to-single-account
The tenanted db is the account scope
2025-04-13 07:58:12 +02:00
David Heinemeier Hansson cf93da6886 Get rid of card_title
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
David Heinemeier Hansson a106b1b6a7 Join the two users controllers but split out role setting 2025-04-12 20:30:47 +02:00
David Heinemeier Hansson 6bbf68a4f9 The tenanted db is the account scope 2025-04-12 20:06:34 +02:00
David Heinemeier Hansson 760cbb6c99 Drop boosts
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson 9359cac330 Style 2025-04-12 11:24:02 +02:00
David Heinemeier Hansson b2b9c99745 Style 2025-04-12 11:23:48 +02:00
David Heinemeier Hansson b8c3ac8145 Cache busting should happen as a comment in the partial, not as an actual key component 2025-04-12 11:22:31 +02:00
David Heinemeier Hansson 6f3ac772ea Merge branch 'main' into comments-refactoring
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
Andy Smith 019c16b3e3 Fix issues after merge 2025-04-11 16:09:44 -05:00
Andy Smith 11ecc5d489 Merge in latest from main 2025-04-11 15:39:07 -05:00
Andy Smith 75a46356cc Merge branch 'main' into consolidate-cards
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
2025-04-11 15:38:57 -05:00
Jason Zimdars 5e608d33e1 Add this for debugging empty event cards 2025-04-11 13:21:47 -05:00
Jason Zimdars d3584adf35 Some actions shouldn't be available to closed cards 2025-04-11 13:21:47 -05:00
Jason Zimdars 89f76a080a Nicer spacing when the large button isn't present 2025-04-11 13:21:47 -05:00
Jason Zimdars c5fc847372 Update card-color in a couple more places 2025-04-11 13:21:47 -05:00
Jason Zimdars a76488fd49 Don't show the engagement toggle on closed cards 2025-04-11 13:21:47 -05:00
Andy Smith d678ce1f60 Cleanup after merge 2025-04-11 12:43:16 -05:00
Andy Smith c853d3c570 Merge branch 'main' into consolidate-cards
* main: (31 commits)
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
  Needed to come first
  In order of appearance
  Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones
  Move comments under cards
  Fix indention
  Refresh timers when morphing happens
  Extract helper for card articles, use classes to determine when to show golden status
  Only consider golden those cards in "doing"
  Fix recently completed order for good!
  Place recently closed cards first
  Monkey patch a prepend_order method
  Rename inconsistency: go with goldness
  Touch
  Use gild/ungild
  Format
  Fix test
  ...
2025-04-11 12:43:05 -05:00
Jason Zimdars df96ee80fa Style drafted cards 2025-04-11 12:21:14 -05:00
Jason Zimdars 76336a52d6 This item makes no sense until it's saved 2025-04-11 11:56:26 -05:00
Jason Zimdars ee8559343a Tighten engagement switch design, only display it for published cards 2025-04-11 11:50:09 -05:00
David Heinemeier Hansson 09dd073cf7 Record lookup works here 2025-04-11 18:47:11 +02:00
David Heinemeier Hansson 51341c36d1 New partial isnt cached 2025-04-11 18:45:44 +02:00
David Heinemeier Hansson c8fe83e8f3 Indention 2025-04-11 18:43:52 +02:00
David Heinemeier Hansson 6effc1568f No need for a separate body partial 2025-04-11 18:41:26 +02:00
David Heinemeier Hansson 9ecb85013b Spacing 2025-04-11 18:25:49 +02:00
David Heinemeier Hansson 442fe6087c Use form object so we dont have to manually set the text_field name 2025-04-11 18:25:24 +02:00
David Heinemeier Hansson 06a636bd8d Did need to separate them out for the broadcast 2025-04-11 18:19:33 +02:00
David Heinemeier Hansson f0aa48b75d Indention 2025-04-11 18:13:29 +02:00
David Heinemeier Hansson fadf167630 Avoid needing to pass an extra variable to the reactions partial
Thanks to inverse_of, there's no extra query getting the comment from
the reaction.
2025-04-11 18:12:52 +02:00
Andy Smith 4a8398e318 Remove unused partials 2025-04-11 11:11:31 -05:00
David Heinemeier Hansson 227d5a8757 It is both reacting and reactions
So stick with the simpler dom id scope
2025-04-11 18:10:26 +02:00
Andy Smith c9b1d6d868 Style pinned cards 2025-04-11 11:09:04 -05:00
David Heinemeier Hansson 73f1989861 Fix indention 2025-04-11 18:05:50 +02:00
David Heinemeier Hansson 3b711161d7 No need for a manual dom_id
turbo_frame_tag can do this directly
2025-04-11 18:04:21 +02:00
David Heinemeier Hansson 1145260890 No idea why this was here 2025-04-11 18:01:21 +02:00
David Heinemeier Hansson 5aa2b7da84 No need to cache individual reactions
Both because the reactions partial actually depends on multiple
variables but also because its just not worth it when we are caching the
comment.
2025-04-11 17:58:48 +02:00
David Heinemeier Hansson 7861b7c087 Just open one turbo stream per card
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
David Heinemeier Hansson 263b3336db Add missing CR 2025-04-11 17:50:53 +02:00
David Heinemeier Hansson 0954cfe008 Add CR 2025-04-11 17:48:01 +02:00
David Heinemeier Hansson 79700162fc Use correct stream name
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
David Heinemeier Hansson dc4e50fba5 Move messages partial under cards 2025-04-11 17:34:49 +02:00
David Heinemeier Hansson f4ce57e308 Move comments under cards 2025-04-11 16:21:44 +02:00
Jorge Manrubia ba6eab509c Refresh timers when morphing happens 2025-04-11 13:26:01 +02:00
Jorge Manrubia 825bbf808e Extract helper for card articles, use classes to determine when to show golden status 2025-04-11 12:01:52 +02:00
Jorge Manrubia aef75feead Only consider golden those cards in "doing" 2025-04-11 11:49:52 +02:00
Jorge Manrubia 4f3f322528 Rename inconsistency: go with goldness 2025-04-11 10:22:18 +02:00