Andy Smith
d6b985b8ef
Basic, non-animated version
2025-04-08 14:23:45 -05:00
Andy Smith
1715e9a9ee
WIP
2025-04-08 10:52:20 -05:00
Jason Zimdars
7a545f5afd
Tighten up
2025-04-07 21:48:17 -05:00
Andy Smith
8bcd5394a3
Remove unused class and markup
2025-04-07 15:53:53 -05:00
Andy Smith
620c0b885a
Position "close as" dialog
2025-04-07 15:49:36 -05:00
Jason Zimdars
c3c4823c95
Fix visual regression in popup menus
2025-04-07 15:44:38 -05:00
Andy Smith
d992ba7ede
Perma cards should not always be 100% width
2025-04-07 15:01:06 -05:00
Andy Smith
e9726c481a
WIP
2025-04-07 14:50:24 -05:00
Andy Smith
e8f85df720
Merge branch 'main' into cascade-layers-2
...
* main: (104 commits)
Default collection permissions to "all access"
dep: update active_record-tenanted to 8758240b
dep: bump Rails to 32d96235
Test for `Bubbles::RecoversController`
Move readings under bubbles and out of double nesting
Move bubble stagings out from double nesting
Correct alpha ordering
Fix indention
Move bubble recovery out from double nesting
Move bubbles publish out from the double nesting
Move bubble pops out from double nesting
Move controller to delete bubble image out from double nesting under bucket
Revert "Scope searches by user"
Scope searches by user
Few more lazy loading avatars!
Another lazy loading point
Remove double nesting under bubbles for engagement
Lets just preload all avatars for now
No need for an array when there is only one dependency
Scope data by account
...
2025-04-07 14:15:55 -05:00
David Heinemeier Hansson
23892296da
Move readings under bubbles and out of double nesting
2025-04-07 14:06:56 +02:00
David Heinemeier Hansson
3b32b40264
Move bubble recovery out from double nesting
2025-04-07 13:57:00 +02:00
David Heinemeier Hansson
481be72162
Move bubbles publish out from the double nesting
2025-04-07 13:55:12 +02:00
David Heinemeier Hansson
ce0c6146be
Move bubble pops out from double nesting
2025-04-07 13:45:51 +02:00
David Heinemeier Hansson
c60b86cbaa
Move controller to delete bubble image out from double nesting under bucket
2025-04-07 13:43:51 +02:00
Jorge Manrubia
93b9f08d58
Merge pull request #373 from basecamp/engagement-nesting
...
Remove nesting under "bucket" for engagements
2025-04-07 13:35:18 +02:00
David Heinemeier Hansson
86a360f6a0
Few more lazy loading avatars!
2025-04-07 13:32:10 +02:00
David Heinemeier Hansson
7e9b851f64
Another lazy loading point
2025-04-07 13:31:14 +02:00
Jorge Manrubia
e4f7837ebe
Remove double nesting under bubbles for engagement
2025-04-07 13:30:31 +02:00
David Heinemeier Hansson
8e0394a090
Lets just preload all avatars for now
...
They are small, they cache well, scrolling will be less jittery. Small
cost in bandwidth for that.
2025-04-07 13:29:59 +02:00
David Heinemeier Hansson
84c0ec8a35
No need for an array when there is only one dependency
2025-04-07 13:23:16 +02:00
Jorge Manrubia
a7aae833d1
Extract helper with fallback for the "go to back" and use consistently
2025-04-07 11:28:03 +02:00
Jorge Manrubia
a0579f7b6f
Inject a span with a class with the value so that we can style it
...
https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008854
2025-04-07 10:46:24 +02:00
Jorge Manrubia
8e01a277ad
Add daysago formatter and extract common helper to reuse with indays formatter
2025-04-07 10:46:22 +02:00
David Heinemeier Hansson
26c123c41c
Template dependency should be closest to direct use
2025-04-06 21:05:28 +02:00
David Heinemeier Hansson
c06802856e
Move boosts under bubbles
...
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
David Heinemeier Hansson
d925c64c59
Remove anemic partial
2025-04-06 20:07:21 +02:00
David Heinemeier Hansson
4fd1472fae
Move bubble watch out from the needless bucket nesting
2025-04-06 19:22:40 +02:00
David Heinemeier Hansson
352ba6e05e
No longer need the turbo frame designation as this isnt wrapped in a frame
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson
084c4d8948
Spacing and indention
2025-04-06 13:50:15 +02:00
David Heinemeier Hansson
7fe87bfce5
This neednt be a turbo frame
...
Just because we are targeting something with a stream update does not
mean it needs to be a frame. The frame is only necessary when there is
lazy loading or we are creating a closed update loop.
2025-04-06 13:47:27 +02:00
David Heinemeier Hansson
7900c475e9
This is going to churn too much
...
Depends directly on the Current.account. If we need something like this,
we need a much more narrow key.
2025-04-06 13:32:30 +02:00
David Heinemeier Hansson
a58fcd3123
Nicer API
2025-04-06 13:26:10 +02:00
David Heinemeier Hansson
ee22e69e6e
Move taggings to bubbles
2025-04-05 22:19:12 +02:00
David Heinemeier Hansson
540316e639
Move taggings under bubbles
2025-04-05 21:54:48 +02:00
David Heinemeier Hansson
5134985418
Simplify the assignments flow
...
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.
This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
David Heinemeier Hansson
77f412f875
Cache is going to churn too frequently to matter
...
Anything that touches the bucket, and thats almost everything, will
churn the cache. This is already hidden behind a turbo frame, so thats
enough to get it out of the rendering hot path.
2025-04-05 16:23:47 +02:00
David Heinemeier Hansson
64c00aea30
Extract helper for bubble_assignee_checkbox
2025-04-05 16:20:31 +02:00
David Heinemeier Hansson
e825f1d33f
No need for the partial indirection
2025-04-05 16:06:44 +02:00
David Heinemeier Hansson
d0953d6f87
Pull assignments out of the double nesting
2025-04-05 15:59:51 +02:00
David Heinemeier Hansson
ec36e52b25
No longer used
2025-04-05 15:52:15 +02:00
David Heinemeier Hansson
e69c1bd0a1
Break pins out of the double nesting
...
Its cumbersome and needless
2025-04-05 15:45:16 +02:00
David Heinemeier Hansson
8708ff04c1
Fix indention
2025-04-05 15:27:40 +02:00
David Heinemeier Hansson
bfb7ed1216
Move pins to my space
...
We used the my/ space in HEY to reflect anything that was primarily
hinged off Current.user. Good to use here too.
2025-04-05 14:57:24 +02:00
David Heinemeier Hansson
7494dad91e
Drop the toggles scope for taggings as well
2025-04-05 14:20:06 +02:00
David Heinemeier Hansson
384de24132
Get rid of odd toggles concept
...
This is just assignments.
2025-04-05 14:16:04 +02:00
David Heinemeier Hansson
aefbac9c14
Get rid of single-use and slight awkward model scope
...
Really dont like that raw Arel.sql wrapping that is required.
2025-04-05 13:17:42 +02:00
David Heinemeier Hansson
61dfa5ecce
Spacing
2025-04-05 12:58:56 +02:00
Jason Zimdars
43c4ff55b4
Try a switch control for considering||doing
2025-04-04 17:20:22 -05:00
Jason Zimdars
0d6b9b7519
Stub star feature
2025-04-04 16:34:25 -05:00
Jason Zimdars
0a7c7e7889
Use a variant of the bubble color for the perma surround
2025-04-04 16:06:21 -05:00