I proposed this upstream in https://github.com/rails/rails/pull/55250,
but it's not clear if the presence of script_name should _always_
prefix generated URLs, so for now it's local to Fizzy.
where the closure no longer exists, possibly due to being
reopened.
Previously, fragment caching generally prevented any problems, but if
the cache is busted for any reason (like Andy did in c7eeb56c), then
the previous logic would raise an exception like "undefined method
'reason' for nil".
So, if the closure no longer exists, let's just note that it was
closed, and by who.
* main:
Clear the comments cache
Add context for search screens
Needs changed for both states
Use lighter icon and update asset
Add btn--circle class to user edit form
Organize button variants
Untangle `avatar btn` crossover styles
Remove redundant classes and styles for avatars
Adjust footer line height
Tweak padding
I went with placing htis logic at the command level since it plays well with the composite structure, where you don't know whether you are handling one command or many commands, and you want to aggregate all the errors. I didn't leverage the existing support with rails' model errors because that customizing those message is cumbersome (either i18n or using custom validation logic for everything).
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
* main: (54 commits)
Remove creation and closure params
Support viewing user profiles and activity
Support downcase
refresh fixtures
Always downcase names
Remove vcr_record call
Support closing soon and falling back soon via natural language
Add scopes and filters for falling back soon and auto closing soon
Fix label
Add chip filters for the new time window filters
Fix: creator_ids is an array, not a single value
Add support for filtering by creation or completion windows of times
Adjust spacing
Use new logo placeholder
Update logo assets
Need to return all collections so it's not blank
Button to add a new filter
Update test for new redirect
Comparing params is fragile, use `id` for saved filters
Update summary tests
...
Andy Smith