Revert "fix(broadcasting): broadcast on mark_helped! even when already false"

This reverts commit 4ad701c1a5.
2026-05-17 20:12:22 +02:00
parent 4ad701c1a5
commit 02df03282e
1 changed files with 9 additions and 7 deletions
@@ -236,21 +236,23 @@ class List

  def mark_helped!
    self.needs_help = false
-    save
-    broadcast_users 'list_helped', id: id
-    broadcast_supplier supplier_id, 'list_helped', id: id
+    if save
+      broadcast_users 'list_helped', id: id
+      broadcast_supplier supplier_id, 'list_helped', id: id
+    end
  end

  def remove_needs_payment!
    self.needs_payment = false
-    save
-    broadcast_users 'remove_list_needs_payment', id: id
-    broadcast_supplier supplier_id, 'remove_list_needs_payment', id: id
+    if save
+      broadcast_users 'remove_list_needs_payment', id: id
+      broadcast_supplier supplier_id, 'remove_list_needs_payment', id: id
+    end
  end

  def needs_payment!
    self.needs_payment = true
-    save
+    if save
      broadcast_users 'list_needs_payment', id: id
      broadcast_supplier supplier_id, 'list_needs_payment', id: id
    end