0866eb6948
Excess CR
2025-04-05 17:33:37 +02:00
537cb7680e
Add Bundler Audit for Local CI
2025-04-05 17:20:51 +02:00
5316a6b821
It is Local CI now
2025-04-05 17:18:54 +02:00
aaa4dd2967
Use modern CI setup
2025-04-05 17:18:26 +02:00
25b89ce8a9
Trailing CR
2025-04-05 17:18:18 +02:00
338ff496da
No system tests yet
2025-04-05 17:15:47 +02:00
5134985418
Simplify the assignments flow
...
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.
This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
6990f1eb05
Alpha sort regardless of capitalization
2025-04-05 16:27:22 +02:00
77f412f875
Cache is going to churn too frequently to matter
...
Anything that touches the bucket, and thats almost everything, will
churn the cache. This is already hidden behind a turbo frame, so thats
enough to get it out of the rendering hot path.
2025-04-05 16:23:47 +02:00
64c00aea30
Extract helper for bubble_assignee_checkbox
2025-04-05 16:20:31 +02:00
6166c91759
Not needed
...
The Dockerfile enforces the Ruby version in production, and mise does so
in development.
2025-04-05 16:09:45 +02:00
233538c722
Going to remove Hotwire Spark for a second
...
It does not work well with turbo frames that error out during
development, since it changes the URL on the error to the location of
the frame. Find that more annoying than I find Spark helpful.
2025-04-05 16:07:42 +02:00
e825f1d33f
No need for the partial indirection
2025-04-05 16:06:44 +02:00
d0953d6f87
Pull assignments out of the double nesting
2025-04-05 15:59:51 +02:00
3b5f8c2e6a
Note the security oddity of finding straight off root
2025-04-05 15:56:12 +02:00
851be126ab
Emphasize where this pin is showing up
2025-04-05 15:55:11 +02:00
ec36e52b25
No longer used
2025-04-05 15:52:15 +02:00
b4c0fec7a6
Move Assignments under Bubble
...
Since that what we are assigning
2025-04-05 15:51:53 +02:00
e69c1bd0a1
Break pins out of the double nesting
...
Its cumbersome and needless
2025-04-05 15:45:16 +02:00
f725a69dee
Let BubbleScoped find its own bucket
...
Then it will be easier to break things that are double nested out of
that nesting.
2025-04-05 15:44:47 +02:00
8708ff04c1
Fix indention
2025-04-05 15:27:40 +02:00
866a80e133
Fix up the tests
2025-04-05 15:26:49 +02:00
e4c6fe4b55
Shape up pinning API and broadcast in the controller
2025-04-05 15:15:48 +02:00
bfb7ed1216
Move pins to my space
...
We used the my/ space in HEY to reflect anything that was primarily
hinged off Current.user. Good to use here too.
2025-04-05 14:57:24 +02:00
7494dad91e
Drop the toggles scope for taggings as well
2025-04-05 14:20:06 +02:00
384de24132
Get rid of odd toggles concept
...
This is just assignments.
2025-04-05 14:16:04 +02:00
f063116df4
Group related associations together
2025-04-05 13:19:30 +02:00
aefbac9c14
Get rid of single-use and slight awkward model scope
...
Really dont like that raw Arel.sql wrapping that is required.
2025-04-05 13:17:42 +02:00
61dfa5ecce
Spacing
2025-04-05 12:58:56 +02:00
821f4c43d8
Excess CR
2025-04-05 12:49:19 +02:00
1463fa68f4
Sessions only depend on user and have no callback, so use the faster delete_all
2025-04-05 12:48:52 +02:00
8ff017fc5b
Only one invocation of this, not carrying the worth of its indirection
...
Generally I am wary of including global state checks in the belly of
models. It is one thing to do it as a default parameter, but I think it
is too far to do it inside an actual method.
2025-04-05 12:40:08 +02:00
d237885bd4
Extract User::Assignee role
...
Keep slimming down that User
2025-04-05 12:37:18 +02:00
17bdfb5df5
Already included in the Avatar concern
2025-04-05 12:35:41 +02:00
92ce80cc32
Extract User::Accessor concern
...
Our User model is getting overloaded
2025-04-05 12:34:39 +02:00
4c344d2c36
Use Rails 8.1 defaults
...
Avoids deprecation warnings during test runs
2025-04-05 12:34:02 +02:00
9cae6bb75a
Some browsers can't do this
2025-04-04 17:22:01 -05:00
adb04bf4df
No need for special case here
2025-04-04 17:20:32 -05:00
43c4ff55b4
Try a switch control for considering||doing
2025-04-04 17:20:22 -05:00
0d6b9b7519
Stub star feature
2025-04-04 16:34:25 -05:00
1f31ca597f
Reset value here
2025-04-04 16:19:04 -05:00
90d67654ea
This is a bit narrow
2025-04-04 16:16:47 -05:00
d2d8c2121f
Crisp edges
2025-04-04 16:14:38 -05:00
0a7c7e7889
Use a variant of the bubble color for the perma surround
2025-04-04 16:06:21 -05:00
61553b77aa
Merge pull request #359 from basecamp/picture-icon-repair
...
Make sure the picture-add icon is square so it doesn't get clipped
2025-04-04 16:01:05 -05:00
a4cccb70a7
Make sure the picture-add icon is square so it doesn't get clipped
2025-04-04 15:21:33 -05:00
4ecb5db6a9
Fix misalignment
2025-04-04 15:17:48 -05:00
77ad92c807
Restore missing link to navigate to cards
2025-04-04 18:12:02 +02:00
42f6412541
Merge pull request #356 from basecamp/show-stage
...
Fixes for permas
2025-04-04 18:01:14 +02:00
6512b8c726
Only consider in doing/considering published cards
2025-04-04 17:58:27 +02:00
David Heinemeier Hansson