Jorge Manrubia
950aebb409
Script to merge duplicated tags
2025-04-07 06:18:01 +02:00
Jorge Manrubia
99584a17f4
Ignore case when trying to match tags
2025-04-07 06:01:43 +02:00
Mike Dalessio
e30ddca439
Merge pull request #367 from basecamp/flavorjones/fix-days-ago-formatter
...
Fix the DaysAgoFormatter output to say "days ago"
2025-04-06 22:09:30 -04:00
Mike Dalessio
2e917b90a2
Fix the DaysAgoFormatter output to say "days ago"
...
and not "in N days" 😅
2025-04-06 22:08:51 -04:00
David Heinemeier Hansson
1e303c9108
Merge pull request #366 from basecamp/move-boosts-under-bubbles
...
Move boosts under bubbles
2025-04-06 21:13:49 +02:00
David Heinemeier Hansson
8def7c5003
Excess CR
2025-04-06 21:11:04 +02:00
David Heinemeier Hansson
565ee0f548
Dont have to spell this out when there are no other formats
2025-04-06 21:09:49 +02:00
David Heinemeier Hansson
26c123c41c
Template dependency should be closest to direct use
2025-04-06 21:05:28 +02:00
David Heinemeier Hansson
c06802856e
Move boosts under bubbles
...
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
David Heinemeier Hansson
5c9f630fee
Rearrange
2025-04-06 20:13:20 +02:00
David Heinemeier Hansson
5275394c2d
Move resolves to the bottom for a cleaner reading
2025-04-06 20:13:09 +02:00
David Heinemeier Hansson
d925c64c59
Remove anemic partial
2025-04-06 20:07:21 +02:00
David Heinemeier Hansson
4fd1472fae
Move bubble watch out from the needless bucket nesting
2025-04-06 19:22:40 +02:00
David Heinemeier Hansson
eb0614c44f
Use a more ergonomic API for watching
...
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson
352ba6e05e
No longer need the turbo frame designation as this isnt wrapped in a frame
2025-04-06 19:17:26 +02:00
Mike Dalessio
c450371ff4
Merge pull request #365 from basecamp/flavorjones/async-query
...
Enable Active Record load_async
2025-04-06 13:16:21 -04:00
Mike Dalessio
9e1eba6bfb
Enable Active Record load_async
...
Use of load_async was introduced in 49ef811d , but the feature has not
been enabled until this change.
2025-04-06 13:13:16 -04:00
David Heinemeier Hansson
95cd60b919
Style
2025-04-06 18:49:19 +02:00
David Heinemeier Hansson
78c82584cf
Reads nicer now that we are using long form operations
2025-04-06 18:45:58 +02:00
David Heinemeier Hansson
21211cedca
These really are anemic too
2025-04-06 18:16:47 +02:00
David Heinemeier Hansson
cc0c88d999
Remove anemic finder
2025-04-06 18:15:13 +02:00
David Heinemeier Hansson
084c4d8948
Spacing and indention
2025-04-06 13:50:15 +02:00
David Heinemeier Hansson
7fe87bfce5
This neednt be a turbo frame
...
Just because we are targeting something with a stream update does not
mean it needs to be a frame. The frame is only necessary when there is
lazy loading or we are creating a closed update loop.
2025-04-06 13:47:27 +02:00
David Heinemeier Hansson
ad53ae0ba1
Merge pull request #364 from basecamp/move-taggings-to-bubbles
...
Move taggings to bubbles
2025-04-06 13:40:52 +02:00
David Heinemeier Hansson
7900c475e9
This is going to churn too much
...
Depends directly on the Current.account. If we need something like this,
we need a much more narrow key.
2025-04-06 13:32:30 +02:00
David Heinemeier Hansson
eb047aec4d
Neater
2025-04-06 13:30:20 +02:00
David Heinemeier Hansson
b8bcfdee40
This is not just param extraction, we sanitize too
2025-04-06 13:29:43 +02:00
David Heinemeier Hansson
5e78a1dab1
Make it clearer that this takes a title string not a tag object
2025-04-06 13:28:52 +02:00
David Heinemeier Hansson
a58fcd3123
Nicer API
2025-04-06 13:26:10 +02:00
David Heinemeier Hansson
cdd78b41ee
Tag exclusively by title
2025-04-06 13:19:22 +02:00
David Heinemeier Hansson
ee22e69e6e
Move taggings to bubbles
2025-04-05 22:19:12 +02:00
David Heinemeier Hansson
540316e639
Move taggings under bubbles
2025-04-05 21:54:48 +02:00
David Heinemeier Hansson
18419c52b8
Latest schema
2025-04-05 21:46:50 +02:00
Mike Dalessio
e8c11dc73f
Merge pull request #363 from basecamp/dependabot/bundler/development-dependencies-21d84de0a3
...
Bump the development-dependencies group across 1 directory with 2 updates
2025-04-05 13:06:31 -04:00
David Heinemeier Hansson
0866eb6948
Excess CR
2025-04-05 17:33:37 +02:00
dependabot[bot]
d2e4b0e9a3
Bump the development-dependencies group across 1 directory with 2 updates
...
Bumps the development-dependencies group with 2 updates in the / directory: [brakeman](https://github.com/presidentbeef/brakeman ) and [selenium-webdriver](https://github.com/SeleniumHQ/selenium ).
Updates `brakeman` from 7.0.0 to 7.0.2
- [Release notes](https://github.com/presidentbeef/brakeman/releases )
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md )
- [Commits](https://github.com/presidentbeef/brakeman/compare/v7.0.0...v7.0.2 )
Updates `selenium-webdriver` from 4.30.1 to 4.31.0
- [Release notes](https://github.com/SeleniumHQ/selenium/releases )
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES )
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.31.0 )
---
updated-dependencies:
- dependency-name: brakeman
dependency-version: 7.0.2
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: development-dependencies
- dependency-name: selenium-webdriver
dependency-version: 4.31.0
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: development-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-04-05 15:23:15 +00:00
David Heinemeier Hansson
537cb7680e
Add Bundler Audit for Local CI
2025-04-05 17:20:51 +02:00
David Heinemeier Hansson
5316a6b821
It is Local CI now
2025-04-05 17:18:54 +02:00
David Heinemeier Hansson
aaa4dd2967
Use modern CI setup
2025-04-05 17:18:26 +02:00
David Heinemeier Hansson
25b89ce8a9
Trailing CR
2025-04-05 17:18:18 +02:00
David Heinemeier Hansson
338ff496da
No system tests yet
2025-04-05 17:15:47 +02:00
David Heinemeier Hansson
5134985418
Simplify the assignments flow
...
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.
This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
David Heinemeier Hansson
6990f1eb05
Alpha sort regardless of capitalization
2025-04-05 16:27:22 +02:00
David Heinemeier Hansson
77f412f875
Cache is going to churn too frequently to matter
...
Anything that touches the bucket, and thats almost everything, will
churn the cache. This is already hidden behind a turbo frame, so thats
enough to get it out of the rendering hot path.
2025-04-05 16:23:47 +02:00
David Heinemeier Hansson
64c00aea30
Extract helper for bubble_assignee_checkbox
2025-04-05 16:20:31 +02:00
David Heinemeier Hansson
6166c91759
Not needed
...
The Dockerfile enforces the Ruby version in production, and mise does so
in development.
2025-04-05 16:09:45 +02:00
David Heinemeier Hansson
233538c722
Going to remove Hotwire Spark for a second
...
It does not work well with turbo frames that error out during
development, since it changes the URL on the error to the location of
the frame. Find that more annoying than I find Spark helpful.
2025-04-05 16:07:42 +02:00
David Heinemeier Hansson
e825f1d33f
No need for the partial indirection
2025-04-05 16:06:44 +02:00
David Heinemeier Hansson
d0953d6f87
Pull assignments out of the double nesting
2025-04-05 15:59:51 +02:00
David Heinemeier Hansson
3b5f8c2e6a
Note the security oddity of finding straight off root
2025-04-05 15:56:12 +02:00