Commit Graph

5088 Commits

Author SHA1 Message Date
Jorge Manrubia ce80c843d0 Several fixes for saving filters
- Unify terms with the settings form so that terms are saved normally in the same form.
- Fix filter normalization since it was sometimes failing to match the saved filters due to using quotes around number strings.
2025-09-22 12:55:19 +02:00
Jorge Manrubia 717f921a73 Refresh save filter toggle when changing filter 2025-09-19 18:37:02 +02:00
Jorge Manrubia f1a5aeb7c2 Merge pull request #1144 from basecamp/collection-filtering
Keep collection_id filter when filtering
2025-09-19 17:52:55 +02:00
Jorge Manrubia 17c6009a3a Keep collection_id filter when filtering 2025-09-19 17:51:58 +02:00
Jorge Manrubia 5a8bfbfdb0 Merge pull request #1143 from basecamp/restore-search
Restore filter targets so that search works!
2025-09-19 17:44:02 +02:00
Jorge Manrubia 3b83d218ea Restore filter targets so that search works! 2025-09-19 17:42:48 +02:00
Jorge Manrubia e7912fbb58 Merge pull request #1133 from basecamp/filtering-nicer
Higher fidelity for filters
2025-09-19 16:55:54 +02:00
Jorge Manrubia de60b198bd Fix tests 2025-09-19 16:52:13 +02:00
Jorge Manrubia 64b46d37e4 Toggle filters in the hey menu too
This also fixes a problem where the label in the menu for the filters was wrong
2025-09-19 16:52:13 +02:00
Jorge Manrubia 0703263664 Save/delete filter working properly and fast 2025-09-19 16:51:11 +02:00
Jorge Manrubia f77aef968b Don't submit empty params with the filter
They result in garbled URLs
2025-09-19 16:51:11 +02:00
Jorge Manrubia d13dd58a78 Make filter toggle save/destroy work 2025-09-19 16:51:11 +02:00
Jorge Manrubia 1633c56a08 Move cache_key to the new cacheable concern 2025-09-19 16:51:11 +02:00
Jorge Manrubia b87badaf33 Extract method 2025-09-19 16:51:11 +02:00
Jorge Manrubia 9b61b0af3b Fix: detect hidden fields dynamically as they are added 2025-09-19 16:51:11 +02:00
Jorge Manrubia fcbc0dcd59 Fix: initialize multiselect on connect 2025-09-19 16:51:11 +02:00
Jorge Manrubia ced51c2cac Use single form for terms and settings 2025-09-19 16:51:11 +02:00
Jorge Manrubia 33a3d856b5 Add prefix for multi select labels 2025-09-19 16:51:11 +02:00
Jorge Manrubia 2d575737b5 Fixes for multi selection 2025-09-19 16:51:11 +02:00
Jorge Manrubia 81cae9cbe0 Fix default handling 2025-09-19 16:51:11 +02:00
Jorge Manrubia cb7d260545 Multi selection combos working 2025-09-19 16:51:11 +02:00
Jorge Manrubia 8d2a191a91 manage a hidden template instead since this will come handy when dealing with multiple selection 2025-09-19 16:51:11 +02:00
Jorge Manrubia 7a916c295a Controlling the manage filter section with JS too 2025-09-19 16:51:11 +02:00
Jorge Manrubia 408374ff33 Submitting form from the new combos 2025-09-19 16:51:11 +02:00
Jorge Manrubia 66b0a4f2e7 Adapt indexed_at too 2025-09-19 16:51:11 +02:00
Jorge Manrubia 7b60c6959a WIP with a combobox controller to handle filters with pure JS 2025-09-19 16:51:11 +02:00
Jorge Manrubia e33f1a6333 Use existing method 2025-09-19 16:51:11 +02:00
Andy Smith 130ae0cbb5 Merge pull request #1142 from basecamp/remove-nav-search
Remove the search option from the nav
2025-09-18 16:59:50 -05:00
Andy Smith 85cddb91f0 Remove the search option from the nav 2025-09-18 16:43:39 -05:00
Mike Dalessio b1610f58bc Merge pull request #1141 from basecamp/flavorjones/script-prod-to-beta
script to stitch beta accounts together from a prod backup
2025-09-18 17:40:35 -04:00
Mike Dalessio b22a490f3a script to stitch beta accounts together from a prod backup 2025-09-18 17:38:41 -04:00
Andy Smith 6da9e918ef Merge pull request #1140 from basecamp/public-column-markup
Use the same markup for public card columns
2025-09-18 16:30:58 -05:00
Andy Smith 2404d6d0f9 Use the same markup for public card columns 2025-09-18 16:18:06 -05:00
Andy Smith 1367e7b263 Merge pull request #1139 from basecamp/card-column-min-size
Keep card columns from expanding too much
2025-09-18 16:12:31 -05:00
Andy Smith 1e3684adb4 Keep card columns from expanding too much 2025-09-18 16:05:36 -05:00
Andy Smith 4097fc37ad Merge pull request #1138 from basecamp/mobile-notification-settings-layout
Ensure settings panels don't expand too much
2025-09-18 16:03:04 -05:00
Andy Smith b3a12de809 Ensure settings panels don't expand too much 2025-09-18 15:24:26 -05:00
Andy Smith 1630354813 Merge pull request #1136 from basecamp/404-back-link
Link to home page instead of browser history
2025-09-18 14:52:29 -05:00
Andy Smith 9b06a2cc79 Link to home page instead of browser history 2025-09-18 14:35:24 -05:00
Mike Dalessio 0519749576 Merge pull request #1129 from basecamp/flavorjones/perf-collection-clean-inaccessible-data
Improved performance of cleaning inaccessible data
2025-09-18 15:23:38 -04:00
Jorge Manrubia b5ed5d8fd3 Remove unused module 2025-09-18 21:22:47 +02:00
Andy Smith 695615dfb9 Merge pull request #1135 from basecamp/bubble-position
Position bubbles within On Deck
2025-09-18 14:22:06 -05:00
Mike Dalessio 53ae8a33e3 Improved performance of cleaning inaccessible data
ref: https://fizzy.37signals.com/5986089/cards/1865
2025-09-18 15:20:54 -04:00
Andy Smith cc09029587 Position bubbles within On Deck 2025-09-18 14:15:04 -05:00
Andy Smith d527548621 Merge pull request #1134 from basecamp/bump-golden-ticket
Bump golden ticket
2025-09-18 14:06:35 -05:00
Andy Smith 0670ee8eeb Make golden cards brighter in dark mode 2025-09-18 13:54:31 -05:00
Andy Smith ccf4442562 Merge pull request #1119 from basecamp/nav-filter-handle-collapsed-sections
Nav filter handle collapsed sections
2025-09-18 13:32:01 -05:00
Andy Smith d8bdbc9a65 WIP: Touch up considering BG in dark mode 2025-09-18 13:10:58 -05:00
Jorge Manrubia 4484ca29b7 Fix pagination not working because the filter was lost 2025-09-18 12:47:54 +02:00
Jorge Manrubia 217f5ca5c1 Merge pull request #1132 from basecamp/invalidation-cache
Fix several caching issues when viewing card permas
2025-09-18 12:21:22 +02:00